d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tests/cmdline: fix memory leaks

Browse Source 
Fixes for a few memory leaks in the cmdline_autotest unit test.

All of the leaks were related to not freeing the commandline struct
after testing had completed.

Fixes: dbb860e03e ("cmdline: tests")
Cc: stable@dpdk.org

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
This commit is contained in:
Owen Hilyard 2021-06-23 14:06:45 -04:00 committed by David Marchand
parent 03b8372a9a
commit ca7204b921
1 changed files with 27 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
app/test/test_cmdline_lib.c
View File

@ -71,10 +71,12 @@ test_cmdline_parse_fns(void)
if (cmdline_complete(cl, "buffer", &i, NULL, sizeof(dst)) >= 0) if (cmdline_complete(cl, "buffer", &i, NULL, sizeof(dst)) >= 0)
goto error; goto error;
cmdline_free(cl);
return 0; return 0;
error: error:
printf("Error: function accepted null parameter!\n"); printf("Error: function accepted null parameter!\n");
cmdline_free(cl);
return -1; return -1;
} }
@ -140,22 +142,31 @@ static int
test_cmdline_socket_fns(void) test_cmdline_socket_fns(void)
{ {
cmdline_parse_ctx_t ctx; cmdline_parse_ctx_t ctx;
struct cmdline *cl;
if (cmdline_stdin_new(NULL, "prompt") != NULL) cl = cmdline_stdin_new(NULL, "prompt");
if (cl != NULL)
goto error; goto error;
if (cmdline_stdin_new(&ctx, NULL) != NULL) cl = cmdline_stdin_new(&ctx, NULL);
if (cl != NULL)
goto error; goto error;
if (cmdline_file_new(NULL, "prompt", "/dev/null") != NULL) cl = cmdline_file_new(NULL, "prompt", "/dev/null");
if (cl != NULL)
goto error; goto error;
if (cmdline_file_new(&ctx, NULL, "/dev/null") != NULL) cl = cmdline_file_new(&ctx, NULL, "/dev/null");
if (cl != NULL)
goto error; goto error;
if (cmdline_file_new(&ctx, "prompt", NULL) != NULL) cl = cmdline_file_new(&ctx, "prompt", NULL);
if (cl != NULL)
goto error; goto error;
if (cmdline_file_new(&ctx, "prompt", "-/invalid/~/path") != NULL) { cl = cmdline_file_new(&ctx, "prompt", "-/invalid/~/path");
if (cl != NULL) {
printf("Error: succeeded in opening invalid file for reading!"); printf("Error: succeeded in opening invalid file for reading!");
cmdline_free(cl);
return -1; return -1;
} }
if (cmdline_file_new(&ctx, "prompt", "/dev/null") == NULL) { cl = cmdline_file_new(&ctx, "prompt", "/dev/null");
if (cl == NULL) {
printf("Error: failed to open /dev/null for reading!"); printf("Error: failed to open /dev/null for reading!");
return -1; return -1;
} }
@ -163,9 +174,11 @@ test_cmdline_socket_fns(void)
/* void functions */ /* void functions */
cmdline_stdin_exit(NULL); cmdline_stdin_exit(NULL);
cmdline_free(cl);
return 0; return 0;
error: error:
printf("Error: function accepted null parameter!\n"); printf("Error: function accepted null parameter!\n");
cmdline_free(cl);
return -1; return -1;
} }
@ -176,14 +189,15 @@ test_cmdline_fns(void)
struct cmdline *cl; struct cmdline *cl;
memset(&ctx, 0, sizeof(ctx)); memset(&ctx, 0, sizeof(ctx));
cl = cmdline_new(NULL, "prompt", 0, 0);
if (cl != NULL)
goto error;
cl = cmdline_new(&ctx, NULL, 0, 0);
if (cl != NULL)
goto error;
cl = cmdline_new(&ctx, "test", -1, -1); cl = cmdline_new(&ctx, "test", -1, -1);
if (cl == NULL) if (cl == NULL)
goto error; goto error;
if (cmdline_new(NULL, "prompt", 0, 0) != NULL)
goto error;
if (cmdline_new(&ctx, NULL, 0, 0) != NULL)
goto error;
if (cmdline_in(NULL, "buffer", CMDLINE_TEST_BUFSIZE) >= 0) if (cmdline_in(NULL, "buffer", CMDLINE_TEST_BUFSIZE) >= 0)
goto error; goto error;
if (cmdline_in(cl, NULL, CMDLINE_TEST_BUFSIZE) >= 0) if (cmdline_in(cl, NULL, CMDLINE_TEST_BUFSIZE) >= 0)
@ -198,6 +212,7 @@ test_cmdline_fns(void)
cmdline_interact(NULL); cmdline_interact(NULL);
cmdline_quit(NULL); cmdline_quit(NULL);
cmdline_free(cl);
return 0; return 0;
error: error: