d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hash: remove unnecessary locks in lock-free

Browse Source 
Remove __hash_rw_reader_unlock() calls from lock free hash lookup

Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
This commit is contained in:
Dharmik Thakkar 2019-11-21 12:17:59 -06:00 committed by Thomas Monjalon
parent 94f73b5b6e
commit cd723fc70c
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/librte_hash/rte_cuckoo_hash.c
View File

@ -1286,10 +1286,8 @@ __rte_hash_lookup_with_hash_lf(const struct rte_hash *h, const void *key,
/* Check if key is in primary location */
bkt = &h->buckets[prim_bucket_idx];
ret = search_one_bucket_lf(h, key, short_sig, data, bkt);
if (ret != -1) {
__hash_rw_reader_unlock(h);
if (ret != -1)
return ret;
}
/* Calculate secondary hash */
bkt = &h->buckets[sec_bucket_idx];
@ -1297,11 +1295,9 @@ __rte_hash_lookup_with_hash_lf(const struct rte_hash *h, const void *key,
FOR_EACH_BUCKET(cur_bkt, bkt) {
ret = search_one_bucket_lf(h, key, short_sig,
data, cur_bkt);
if (ret != -1) {
__hash_rw_reader_unlock(h);
if (ret != -1)
return ret;
}
}
/* The loads of sig_current in search_one_bucket
* should not move below the load from tbl_chng_cnt.