d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/qede/base: fix index printing of multi-bit attentions

Browse Source 
Fix the logic for identifying which bit amongst the Multi-bit
attention sources is set.

Fixes: e6051bd6b07d ("qede: add interrupt handling support")

Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
This commit is contained in:
Rasesh Mody 2017-03-17 23:50:22 -07:00 committed by Ferruh Yigit
parent d9237ae227
commit cf584e02a7
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/net/qede/base/ecore_int.c
View File

@ -913,18 +913,24 @@ static enum _ecore_status_t ecore_int_deassertion(struct ecore_hwfn *p_hwfn,
bit = bit_idx; bit = bit_idx;
bit_len = ATTENTION_LENGTH(p_aeu->flags); bit_len = ATTENTION_LENGTH(p_aeu->flags);
if (p_aeu->flags & ATTENTION_PAR_INT) { if (p_aeu->flags & ATTENTION_PAR) {
/* Skip Parity */ /* Skip Parity */
bit++; bit++;
bit_len--; bit_len--;
} }
/* Find the bits relating to HW-block, then
* shift so they'll become LSB.
*/
bitmask = bits & (((1 << bit_len) - 1) << bit); bitmask = bits & (((1 << bit_len) - 1) << bit);
bitmask >>= bit;
if (bitmask) { if (bitmask) {
u32 flags = p_aeu->flags; u32 flags = p_aeu->flags;
char bit_name[30]; char bit_name[30];
u8 num;
bit = (u8)OSAL_FIND_FIRST_BIT(&bitmask, num = (u8)OSAL_FIND_FIRST_BIT(&bitmask,
bit_len); bit_len);
/* Some bits represent more than a /* Some bits represent more than a
@ -936,11 +942,17 @@ static enum _ecore_status_t ecore_int_deassertion(struct ecore_hwfn *p_hwfn,
ATTENTION_LENGTH(flags) > 1)) ATTENTION_LENGTH(flags) > 1))
OSAL_SNPRINTF(bit_name, 30, OSAL_SNPRINTF(bit_name, 30,
p_aeu->bit_name, p_aeu->bit_name,
bit); num);
else else
OSAL_STRNCPY(bit_name, OSAL_STRNCPY(bit_name,
p_aeu->bit_name, p_aeu->bit_name,
30); 30);
/* We now need to pass bitmask in its
* correct position.
*/
bitmask <<= bit;
/* Handle source of the attention */ /* Handle source of the attention */
ecore_int_deassertion_aeu_bit(p_hwfn, ecore_int_deassertion_aeu_bit(p_hwfn,
p_aeu, p_aeu,