d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

bus/pci: enhance driver pointer documentation

Browse Source 
Setting driver pointer before mapping required for write combining
support since commit 4a928ef9f6 ("bus/pci: enable write combining
during mapping").

Move comments that got separated after different changes.
Also change the condition relying on dev->driver itself.

Signed-off-by: David Marchand <david.marchand@redhat.com>
This commit is contained in:
David Marchand 2022-03-01 11:53:54 +01:00 committed by Thomas Monjalon
parent 917229c24e
commit d1ef517dc0
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/bus/pci/pci_common.c
View File

@ -207,11 +207,6 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
RTE_LOG(DEBUG, EAL, " probe driver: %x:%x %s\n", dev->id.vendor_id,
dev->id.device_id, dr->driver.name);
/*
* reference driver structure
* This needs to be before rte_pci_map_device(), as it enables to use
* driver flags for adjusting configuration.
*/
if (!already_probed) {
enum rte_iova_mode dev_iova_mode;
enum rte_iova_mode iova_mode;
@ -247,9 +242,13 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
return -ENOMEM;
}
/*
* Reference driver structure.
* This needs to be before rte_pci_map_device(), as it enables
* to use driver flags for adjusting configuration.
*/
dev->driver = dr;
if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) {
if (dev->driver->drv_flags & RTE_PCI_DRV_NEED_MAPPING) {
ret = rte_pci_map_device(dev);
if (ret != 0) {
dev->driver = NULL;