d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

vhost: validate index in inflight API

Browse Source 
This patch validates the queue index parameter, in order
to ensure neither out-of-bound accesses nor NULL pointer
dereferencing happen.

Fixes: 4d891f77dd ("vhost: add APIs to get inflight ring")
Cc: stable@dpdk.org

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
This commit is contained in:
Maxime Coquelin 2020-10-19 19:34:13 +02:00 committed by Ferruh Yigit
parent 943daec05c
commit d2475e8903
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/librte_vhost/vhost.c
View File

@ -1523,15 +1523,23 @@ rte_vhost_get_vring_base_from_inflight(int vid,
uint16_t *last_used_idx)
{
struct rte_vhost_inflight_info_packed *inflight_info;
struct vhost_virtqueue *vq;
struct virtio_net *dev = get_device(vid);
if (dev == NULL || last_avail_idx == NULL || last_used_idx == NULL)
return -1;
if (queue_id >= VHOST_MAX_VRING)
return -1;
vq = dev->virtqueue[queue_id];
if (!vq)
return -1;
if (!vq_is_packed(dev))
return -1;
inflight_info = dev->virtqueue[queue_id]->inflight_packed;
inflight_info = vq->inflight_packed;
if (!inflight_info)
return -1;