d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/ipn3ke: remove useless if statement

Browse Source 
Coverity complains that this statement is not needed as the goto
label is on the next line anyway. Remove the if statement.

653        ret = ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name);
   CID 337930 (#1 of 1): Identical code for different branches
   (IDENTICAL_BRANCHES)identical_branches: The same code is executed
   when the condition ret is true or false, because the code in the
   if-then branch and after the if statement is identical. Should
   the if statement be removed?
654        if (ret)
655                goto end;
   implicit_else: The code from the above if-then branch is identical
   to the code after the if statement.
656end:

Coverity issue: 337930
Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver")
Cc: stable@dpdk.org

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Rosen Xu <rosen.xu@intel.com>
This commit is contained in:
Kevin Traynor 2019-11-06 19:01:59 +00:00 committed by Thomas Monjalon
parent 841a0b7aed
commit d28ae28eb7
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/ipn3ke/ipn3ke_ethdev.c
View File

@ -737,8 +737,7 @@ ipn3ke_cfg_probe(struct rte_vdev_device *dev)
}
ret = ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name);
if (ret)
goto end;
end:
if (kvlist)
rte_kvargs_free(kvlist);