d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

power: check frequencies count before filling array

Browse Source 
The freqs array size is RTE_MAX_LCORE_FREQS. Before filling the
array with num_freqs elements, restrict the total num to
RTE_MAX_LCORE_FREQS. This fix aims to fix the coverity scan issue
like:
Overrunning array "pi->freqs" of 256 bytes by passing it to a
function which accesses it at byte offset 464.

Coverity issue: 371913
Fixes: ef1cc88f18 ("power: support cppc_cpufreq driver")
Cc: stable@dpdk.org

Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
Acked-by: David Hunt <david.hunt@intel.com>
This commit is contained in:
Richael Zhuang 2021-07-23 10:22:42 +08:00 committed by Thomas Monjalon
parent 128c22b998
commit d37462e56c
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/power/power_cppc_cpufreq.c
View File

@ -246,6 +246,11 @@ power_get_available_freqs(struct cppc_power_info *pi)
pi->nominal_perf * UNIT_DIFF : pi->nominal_perf; pi->nominal_perf * UNIT_DIFF : pi->nominal_perf;
num_freqs = (nominal_perf - scaling_min_freq) / BUS_FREQ + 1 + num_freqs = (nominal_perf - scaling_min_freq) / BUS_FREQ + 1 +
pi->turbo_available; pi->turbo_available;
if (num_freqs >= RTE_MAX_LCORE_FREQS) {
RTE_LOG(ERR, POWER, "Too many available frequencies: %d\n",
num_freqs);
goto out;
}
/* Generate the freq bucket array. */ /* Generate the freq bucket array. */
for (i = 0, pi->nb_freqs = 0; i < num_freqs; i++) { for (i = 0, pi->nb_freqs = 0; i < num_freqs; i++) {

5
lib/power/power_pstate_cpufreq.c
View File

@ -419,6 +419,11 @@ power_get_available_freqs(struct pstate_power_info *pi)
*/ */
num_freqs = (base_max_freq - sys_min_freq) / BUS_FREQ + 1 + num_freqs = (base_max_freq - sys_min_freq) / BUS_FREQ + 1 +
pi->turbo_available; pi->turbo_available;
if (num_freqs >= RTE_MAX_LCORE_FREQS) {
RTE_LOG(ERR, POWER, "Too many available frequencies: %d\n",
num_freqs);
goto out;
}
/* Generate the freq bucket array. /* Generate the freq bucket array.
* If turbo is available the freq bucket[0] value is base_max +1 * If turbo is available the freq bucket[0] value is base_max +1