d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/iavf: fix null pointer dereference in eCPRI rule

Browse Source 
A pointer has already been dereferenced before checking if it is NULL.
It doesn't make any sense, so correct to avoid it.

Coverity issue: 365290
Fixes: f57ebdae3cd0 ("net/iavf: support eCPRI message type 0 for RSS")

Signed-off-by: Simei Su <simei.su@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
This commit is contained in:
Simei Su 2021-01-14 13:23:24 +08:00 committed by Ferruh Yigit
parent 5171b4ee6b
commit d62be9ce13
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/iavf/iavf_hash.c
View File

@ -597,11 +597,12 @@ iavf_hash_parse_pattern(const struct rte_flow_item pattern[], uint64_t *phint,
break;
case RTE_FLOW_ITEM_TYPE_ECPRI:
ecpri = item->spec;
ecpri_common.u32 = rte_be_to_cpu_32(
ecpri->hdr.common.u32);
if (!ecpri)
break;
else if (ecpri_common.type !=
ecpri_common.u32 = rte_be_to_cpu_32(ecpri->hdr.common.u32);
if (ecpri_common.type !=
RTE_ECPRI_MSG_TYPE_IQ_DATA) {
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ITEM, item,