d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/e1000: do not error out if Rx drop enable is set

Browse Source 
rx_drop_en is an optimization that does nothing on single-queue
devices like e1000. Do not force applications that do not care to
select per-devices optimizations flags by returning an error, just
log it and carry on.

Fixes: 805803445a ("e1000: support EM devices (also known as e1000/e1000e)")
Cc: stable@dpdk.org

Signed-off-by: Luca Boccassi <bluca@debian.org>
Acked-by: Wei Zhao <wei.zhao1@intel.com>
This commit is contained in:
Luca Boccassi 2018-07-27 18:26:07 +01:00 committed by Ferruh Yigit
parent 2ed2fe5f0a
commit d7812ffd83
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/e1000/em_rxtx.c
View File

@ -1417,12 +1417,13 @@ eth_em_rx_queue_setup(struct rte_eth_dev *dev,
}
/*
* EM devices don't support drop_en functionality
* EM devices don't support drop_en functionality.
* It's an optimization that does nothing on single-queue devices,
* so just log the issue and carry on.
*/
if (rx_conf->rx_drop_en) {
PMD_INIT_LOG(ERR, "drop_en functionality not supported by "
PMD_INIT_LOG(NOTICE, "drop_en functionality not supported by "
"device");
return -EINVAL;
}
/* Free memory prior to re-allocation if needed. */