d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mem: use more restrictive permissions on hugepages

Browse Source 
There is no need for the page files to be readable (and executable) by
other users. This can be exploited by non-privileged users to access the
working memory of a DPDK app.

Open the files with 0600.

Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
This commit is contained in:
Robin Jarry 2016-08-10 16:52:54 +02:00 committed by Thomas Monjalon
parent 2f45703c17
commit da5d107207
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/librte_eal/linuxapp/eal/eal_memory.c
View File

@ -442,7 +442,7 @@ map_all_hugepages(struct hugepage_file *hugepg_tbl,
#endif #endif
/* try to create hugepage file */ /* try to create hugepage file */
fd = open(hugepg_tbl[i].filepath, O_CREAT | O_RDWR, 0755); fd = open(hugepg_tbl[i].filepath, O_CREAT | O_RDWR, 0600);
if (fd < 0) { if (fd < 0) {
RTE_LOG(DEBUG, EAL, "%s(): open failed: %s\n", __func__, RTE_LOG(DEBUG, EAL, "%s(): open failed: %s\n", __func__,
strerror(errno)); strerror(errno));
@ -581,7 +581,7 @@ remap_all_hugepages(struct hugepage_file *hugepg_tbl, struct hugepage_info *hpi)
hugepg_tbl[page_idx].file_id); hugepg_tbl[page_idx].file_id);
/* try to create hugepage file */ /* try to create hugepage file */
fd = open(filepath, O_CREAT | O_RDWR, 0755); fd = open(filepath, O_CREAT | O_RDWR, 0600);
if (fd < 0) { if (fd < 0) {
RTE_LOG(ERR, EAL, "%s(): open failed: %s\n", __func__, strerror(errno)); RTE_LOG(ERR, EAL, "%s(): open failed: %s\n", __func__, strerror(errno));
return -1; return -1;