d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/mlx5: fix RSS validation for meter hierarchy

Browse Source 
In a meter hierarchy, all the meters are marked with having RSS if
the final meter's termination action is RSS.

When validating a flow rule with meter hierarchy, the RSS action
should not be fetched from the current meter if it is not the final
one.

The fate action union is next meter ID instead of the pointer to the
RSS action. By using the final meter in the hierarchy, the flow rule
validation will succeed without any crash caused by the invalid RSS
action pointer access.

Fixes: 1ce19ab1f4 ("net/mlx5: fix RSS validation with meter policy")
Cc: stable@dpdk.org

Signed-off-by: Bing Zhao <bingz@nvidia.com>
Reviewed-by: Li Zhang <lizh@nvidia.com>
Reviewed-by: Shun Hao <shunh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
This commit is contained in:
Bing Zhao 2021-11-23 18:05:19 +02:00 committed by Raslan Darawsheh
parent 693c7d4b1e
commit db3ec06e7a
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/net/mlx5/mlx5_flow_dv.c
View File

@ -5254,13 +5254,21 @@ mlx5_flow_validate_action_meter(struct rte_eth_dev *dev,
"Flow and meter policy "
"have different src port.");
} else if (mtr_policy->is_rss) {
struct mlx5_meter_policy_action_container *acg =
&mtr_policy->act_cnt[RTE_COLOR_GREEN];
struct mlx5_meter_policy_action_container *acy =
&mtr_policy->act_cnt[RTE_COLOR_YELLOW];
struct mlx5_flow_meter_policy *fp;
struct mlx5_meter_policy_action_container *acg;
struct mlx5_meter_policy_action_container *acy;
const struct rte_flow_action *rss_act;
int ret;
fp = mlx5_flow_meter_hierarchy_get_final_policy(dev,
mtr_policy);
if (fp == NULL)
return rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION, NULL,
"Unable to get the final "
"policy in the hierarchy");
acg = &fp->act_cnt[RTE_COLOR_GREEN];
acy = &fp->act_cnt[RTE_COLOR_YELLOW];
MLX5_ASSERT(acg->fate_action ==
MLX5_FLOW_FATE_SHARED_RSS ||
acy->fate_action ==