d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

service: fix parameter type for attribute

Browse Source 
The type of value parameter to rte_service_attr_get
should be uint64_t *, since the attributes
are of type uint64_t.

Fixes: 4d55194d76 ("service: add attribute get function")

Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Reviewed-by: Gage Eads <gage.eads@intel.com>
Reviewed-by: Rami Rosen <ramirose@gmail.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
This commit is contained in:
Nikhil Rao 2019-03-28 11:59:03 +05:30 committed by Thomas Monjalon
parent 90fefe78bf
commit db9f4430c2
8 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/test/test_service_cores.c
View File

@ -259,7 +259,7 @@ service_attr_get(void)
rte_service_set_stats_enable(id, 1);
uint32_t attr_id = UINT32_MAX;
uint32_t attr_value = 0xdead;
uint64_t attr_value = 0xdead;
/* check error return values */
TEST_ASSERT_EQUAL(-EINVAL, rte_service_attr_get(id, attr_id,
&attr_value),

4
doc/guides/rel_notes/deprecation.rst
View File

@ -20,10 +20,6 @@ Deprecation Notices
* kvargs: The function ``rte_kvargs_process`` will get a new parameter
for returning key match count. It will ease handling of no-match case.
* eal: The ``attr_value`` parameter of ``rte_service_attr_get()``
will be changed from ``uint32_t *`` to ``uint64_t *``
as the attributes are of type ``uint64_t``.
* eal: both declaring and identifying devices will be streamlined in v18.11.
New functions will appear to query a specific port from buses, classes of
device and device drivers. Device declaration will be made coherent with the

6
doc/guides/rel_notes/release_19_05.rst
View File

@ -134,6 +134,10 @@ API Changes
Also, make sure to start the actual text at the margin.
=========================================================
* eal: the type of the ``attr_value`` parameter of the function
``rte_service_attr_get()`` has been changed
from ``uint32_t *`` to ``uint64_t *``.
ABI Changes
-----------
@ -190,7 +194,7 @@ The libraries prepended with a plus sign were incremented in this version.
librte_compressdev.so.1
+ librte_cryptodev.so.7
librte_distributor.so.1
librte_eal.so.9
+ librte_eal.so.10
librte_efd.so.1
librte_ethdev.so.11
librte_eventdev.so.6

2
lib/librte_eal/common/include/rte_service.h
View File

@ -372,7 +372,7 @@ int32_t rte_service_dump(FILE *f, uint32_t id);
* -EINVAL Invalid id, attr_id or attr_value was NULL.
*/
int32_t rte_service_attr_get(uint32_t id, uint32_t attr_id,
uint32_t *attr_value);
uint64_t *attr_value);
/**
* Reset all attribute values of a service.

2
lib/librte_eal/common/rte_service.c
View File

@ -734,7 +734,7 @@ rte_service_lcore_stop(uint32_t lcore)
}
int32_t
rte_service_attr_get(uint32_t id, uint32_t attr_id, uint32_t *attr_value)
rte_service_attr_get(uint32_t id, uint32_t attr_id, uint64_t *attr_value)
{
struct rte_service_spec_impl *s;
SERVICE_VALID_GET_OR_ERR_RET(id, s, -EINVAL);

2
lib/librte_eal/freebsd/eal/Makefile
View File

@ -22,7 +22,7 @@ LDLIBS += -lrte_kvargs
EXPORT_MAP := ../../rte_eal_version.map
LIBABIVER := 9
LIBABIVER := 10
# specific to freebsd exec-env
SRCS-$(CONFIG_RTE_EXEC_ENV_FREEBSD) := eal.c

2
lib/librte_eal/linux/eal/Makefile
View File

@ -10,7 +10,7 @@ ARCH_DIR ?= $(RTE_ARCH)
EXPORT_MAP := ../../rte_eal_version.map
VPATH += $(RTE_SDK)/lib/librte_eal/common/arch/$(ARCH_DIR)
LIBABIVER := 9
LIBABIVER := 10
VPATH += $(RTE_SDK)/lib/librte_eal/common

2
lib/librte_eal/meson.build
View File

@ -21,7 +21,7 @@ else
error('unsupported system type "@0@"'.format(host_machine.system()))
endif
version = 9 # the version of the EAL API
version = 10 # the version of the EAL API
allow_experimental_apis = true
deps += 'kvargs'
if dpdk_conf.has('RTE_USE_LIBBSD')