d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

pipeline: add check against loops

Browse Source 
Detect when a jump instruction, either conditional or unconditional,
is jumping to itself, thus creating a loop, which is not allowed in
data plane code.

Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Signed-off-by: Harshad Narayane <harshad.suresh.narayane@intel.com>
This commit is contained in:
Cristian Dumitrescu 2021-12-01 12:21:19 +00:00 committed by Thomas Monjalon
parent 96b37959fb
commit dbce95e363
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/pipeline/rte_swx_pipeline.c
View File

@ -6000,6 +6000,19 @@ instr_label_check(struct instruction_data *instruction_data,
CHECK(strcmp(label, instruction_data[j].label), EINVAL);
}
/* Check that no jump instruction (either conditional or not) can jump to itself (loop). */
for (i = 0; i < n_instructions; i++) {
struct instruction_data *data = &instruction_data[i];
char *label = data->label;
char *jmp_label = data->jmp_label;
/* Continue if this instruction does not have a label or it is not a jump. */
if (!label[0] || !jmp_label[0])
continue;
CHECK(strcmp(label, jmp_label), EINVAL);
}
/* Get users for each instruction label. */
for (i = 0; i < n_instructions; i++) {
struct instruction_data *data = &instruction_data[i];