d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/testpmd: fix hotplug removal

Browse Source 
After removing rte_eth_devices from testpmd the vm_hotplug no longer
recovered after removal of a device, because the port was closed
before querying it.

Fixes: 0a0821bcf312 ("app/testpmd: remove most uses of internal ethdev array")

Signed-off-by: Paulis Gributs <paulis.gributs@intel.com>
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
This commit is contained in:
Paulis Gributs 2021-07-28 13:48:48 +00:00 committed by Thomas Monjalon
parent b2a9e4a855
commit e1d38504e1
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/test-pmd/testpmd.c
View File

@ -3197,14 +3197,16 @@ rmv_port_callback(void *arg)
stop_port(port_id);
no_link_check = org_no_link_check;
close_port(port_id);
ret = eth_dev_info_get_print_err(port_id, &dev_info);
if (ret != 0)
TESTPMD_LOG(ERR,
"Failed to get device info for port %d, not detaching\n",
port_id);
else
detach_device(dev_info.device); /* might be already removed or have more ports */
else {
struct rte_device *device = dev_info.device;
close_port(port_id);
detach_device(device); /* might be already removed or have more ports */
}
if (need_to_start)
start_packet_forwarding(0);
}