d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/mlx5/hws: fix possible negative return on SQ create

Browse Source 
The sysconf call can return a negative value (-1) on failure
this will lead to posix_memalign to fail. This is not a realistic
case which was found by the static checkers.

Coverity issue: 381674
Fixes: 3eb748869d2d ("net/mlx5/hws: add send layer")

Signed-off-by: Alex Vesker <valex@nvidia.com>
Reviewed-by: Erez Shitrit <erezsh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
This commit is contained in:
Alex Vesker 2022-11-07 12:08:51 +02:00 committed by Raslan Darawsheh
parent 719eb23d44
commit e280f92408
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/mlx5/hws/mlx5dr_send.c
View File

@ -524,6 +524,7 @@ static int mlx5dr_send_ring_open_sq(struct mlx5dr_context *ctx,
size_t sq_log_buf_sz;
size_t buf_aligned;
size_t sq_buf_sz;
size_t page_size;
size_t buf_sz;
int err;
@ -532,8 +533,9 @@ static int mlx5dr_send_ring_open_sq(struct mlx5dr_context *ctx,
sq_buf_sz = 1 << (sq_log_buf_sz + log2above(MLX5_SEND_WQE_BB));
sq->reg_addr = queue->uar->reg_addr;
buf_aligned = align(sq_buf_sz, sysconf(_SC_PAGESIZE));
err = posix_memalign((void **)&sq->buf, sysconf(_SC_PAGESIZE), buf_aligned);
page_size = sysconf(_SC_PAGESIZE);
buf_aligned = align(sq_buf_sz, page_size);
err = posix_memalign((void **)&sq->buf, page_size, buf_aligned);
if (err) {
rte_errno = ENOMEM;
return err;