d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

igb_uio: prevent reset for bnx2x devices

Browse Source 
Some devices are having problem on device reset that happens during DPDK
application exit [1].

Create a static list of devices and exclude them from device reset.

[1]
http://dpdk.org/ml/archives/dev/2017-November/080927.html

Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
This commit is contained in:
Ferruh Yigit 2017-11-06 18:48:15 +00:00 committed by Thomas Monjalon
parent c52dd39411
commit e3a64deae2
2 changed files with 25 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lib/librte_eal/linuxapp/igb_uio/compat.h
View File

@ -133,4 +133,21 @@ static bool pci_check_and_mask_intx(struct pci_dev *pdev)
#define HAVE_PCI_MSI_MASK_IRQ 1 #define HAVE_PCI_MSI_MASK_IRQ 1
#endif #endif
#define BROADCOM_PCI_VENDOR_ID 0x14E4
static const struct pci_device_id no_reset_pci_tbl[] = {
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x164f) }, /* 57711 */
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x168a) }, /* 57800 */
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x168e) }, /* 57810 */
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x163d) }, /* 57811 */
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x168d) }, /* 57840_OBS */
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a1) }, /* 57840_4_10 */
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a2) }, /* 57840_2_20 */
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16ae) }, /* 57810_MF */
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x163e) }, /* 57811_MF */
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a4) }, /* 57840_MF */
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a9) }, /* 57800_VF */
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16af) }, /* 57810_VF */
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x163f) }, /* 57811_VF */
{ PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16ad) }, /* 57840_VF */
{ 0 },
};

8
lib/librte_eal/linuxapp/igb_uio/igb_uio.c
View File

@ -348,6 +348,11 @@ igbuio_pci_open(struct uio_info *info, struct inode *inode)
return 0; return 0;
} }
static bool is_device_excluded_from_reset(struct pci_dev *pdev)
{
return !!pci_match_id(no_reset_pci_tbl, pdev);
}
static int static int
igbuio_pci_release(struct uio_info *info, struct inode *inode) igbuio_pci_release(struct uio_info *info, struct inode *inode)
{ {
@ -360,7 +365,8 @@ igbuio_pci_release(struct uio_info *info, struct inode *inode)
/* stop the device from further DMA */ /* stop the device from further DMA */
pci_clear_master(dev); pci_clear_master(dev);
pci_reset_function(dev); if (!is_device_excluded_from_reset(dev))
pci_reset_function(dev);
return 0; return 0;
} }