d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mbuf: remove atomic reference counters

Browse Source 
Remove the deprecated refcnt_atomic union fields in
rte_mbuf and rte_mbuf_ext_shared_info structures.

Signed-off-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
This commit is contained in:
Phil Yang 2020-09-11 15:35:51 +08:00 committed by Thomas Monjalon
parent 25efc61539
commit e41d27a68d
3 changed files with 7 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
doc/guides/rel_notes/deprecation.rst
View File

@ -148,13 +148,7 @@ Deprecation Notices
avoiding impact on vectorized implementation of the driver datapaths, avoiding impact on vectorized implementation of the driver datapaths,
while evaluating performance gains of a better use of the first cache line. while evaluating performance gains of a better use of the first cache line.
The deprecated unioned fields ``buf_physaddr`` and ``refcnt_atomic`` The deprecated unioned field ``buf_physaddr`` will be removed in DPDK 20.11.
(as explained below) will be removed in DPDK 20.11.
* mbuf: ``refcnt_atomic`` member in structures ``rte_mbuf`` and
``rte_mbuf_ext_shared_info`` is of type ``rte_atomic16_t``.
Due to adoption of C11 atomic builtins, the field ``refcnt_atomic``
will be replaced with ``refcnt`` of type ``uint16_t`` in DPDK 20.11.
* ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible * ethdev: Split the ``struct eth_dev_ops`` struct to hide it as much as possible
will be done in 20.11. will be done in 20.11.

4
doc/guides/rel_notes/release_20_11.rst
View File

@ -84,6 +84,10 @@ API Changes
Also, make sure to start the actual text at the margin. Also, make sure to start the actual text at the margin.
======================================================= =======================================================
* mbuf: Removed the unioned field ``refcnt_atomic`` from
the structures ``rte_mbuf`` and ``rte_mbuf_ext_shared_info``.
The field ``refcnt`` is remaining from the old unions.
* rawdev: Added a structure size parameter to the functions * rawdev: Added a structure size parameter to the functions
``rte_rawdev_queue_setup()``, ``rte_rawdev_queue_conf_get()``, ``rte_rawdev_queue_setup()``, ``rte_rawdev_queue_conf_get()``,
``rte_rawdev_info_get()`` and ``rte_rawdev_configure()``, ``rte_rawdev_info_get()`` and ``rte_rawdev_configure()``,

13
lib/librte_mbuf/rte_mbuf_core.h
View File

@ -495,12 +495,7 @@ struct rte_mbuf {
* or non-atomic) is controlled by the CONFIG_RTE_MBUF_REFCNT_ATOMIC * or non-atomic) is controlled by the CONFIG_RTE_MBUF_REFCNT_ATOMIC
* config option. * config option.
*/ */
RTE_STD_C11 uint16_t refcnt;
union {
rte_atomic16_t refcnt_atomic; /**< Atomically accessed refcnt */
/** Non-atomically accessed refcnt */
uint16_t refcnt;
};
uint16_t nb_segs; /**< Number of segments. */ uint16_t nb_segs; /**< Number of segments. */
/** Input port (16 bits to support more than 256 virtual ports). /** Input port (16 bits to support more than 256 virtual ports).
@ -679,11 +674,7 @@ typedef void (*rte_mbuf_extbuf_free_callback_t)(void *addr, void *opaque);
struct rte_mbuf_ext_shared_info { struct rte_mbuf_ext_shared_info {
rte_mbuf_extbuf_free_callback_t free_cb; /**< Free callback function */ rte_mbuf_extbuf_free_callback_t free_cb; /**< Free callback function */
void *fcb_opaque; /**< Free callback argument */ void *fcb_opaque; /**< Free callback argument */
RTE_STD_C11 uint16_t refcnt;
union {
rte_atomic16_t refcnt_atomic; /**< Atomically accessed refcnt */
uint16_t refcnt;
};
}; };
/**< Maximum number of nb_segs allowed. */ /**< Maximum number of nb_segs allowed. */