d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

vhost: fix missing cache logging NUMA realloc

Browse Source 
When the guest allocates virtqueues on a different NUMA node
than the one the Vhost metadata are allocated, both the Vhost
device struct and the virtqueues struct are reallocated.

However, reallocating the log cache on the new NUMA node was
not done. This patch fixes this by reallocating it if it has
been allocated already, which means a live-migration is
on-going.

Fixes: 1818a63147fb ("vhost: move dirty logging cache out of virtqueue")
Cc: stable@dpdk.org

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
This commit is contained in:
Maxime Coquelin 2021-06-29 18:11:29 +02:00 committed by Chenbo Xia
parent 57589cdfd7
commit eb40c50c17
1 changed files with 10 additions and 0 deletions

10
lib/vhost/vhost_user.c

@ -545,6 +545,16 @@ numa_realloc(struct virtio_net *dev, int index)
vq->batch_copy_elems = new_batch_copy_elems;
}
if (vq->log_cache) {
struct log_cache_entry *log_cache;
log_cache = rte_realloc_socket(vq->log_cache,
sizeof(struct log_cache_entry) * VHOST_LOG_CACHE_NR,
0, newnode);
if (log_cache)
vq->log_cache = log_cache;
}
rte_free(old_vq);
}