d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/test: fix devargs tests

Browse Source 
Add missing free for devargs->args and fix tests.

Signed-off-by: David Marchand <david.marchand@6wind.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
This commit is contained in:
David Marchand 2015-02-13 16:03:15 +01:00 committed by Thomas Monjalon
parent c2ce3924cc
commit edef7d1f4d
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/test/test_devargs.c
View File

@ -48,6 +48,8 @@ static void free_devargs_list(void)
while (!TAILQ_EMPTY(&devargs_list)) {
devargs = TAILQ_FIRST(&devargs_list);
TAILQ_REMOVE(&devargs_list, devargs, next);
if (devargs->args)
free(devargs->args);
free(devargs);
}
}
@ -92,7 +94,7 @@ test_devargs(void)
if (strncmp(devargs->virtual.drv_name, "eth_ring1",
sizeof(devargs->virtual.drv_name)) != 0)
goto fail;
if (strncmp(devargs->args, "k1=val,k2=val2", sizeof(devargs->args)) != 0)
if (!devargs->args || strcmp(devargs->args, "k1=val,k2=val2") != 0)
goto fail;
free_devargs_list();
@ -105,7 +107,7 @@ test_devargs(void)
devargs->pci.addr.devid != 0 ||
devargs->pci.addr.function != 1)
goto fail;
if (strncmp(devargs->args, "", sizeof(devargs->args)) != 0)
if (devargs->args)
goto fail;
free_devargs_list();

2
app/test/test_pci.c
View File

@ -139,6 +139,8 @@ static void free_devargs_list(void)
while (!TAILQ_EMPTY(&devargs_list)) {
devargs = TAILQ_FIRST(&devargs_list);
TAILQ_REMOVE(&devargs_list, devargs, next);
if (devargs->args)
free(devargs->args);
free(devargs);
}
}