d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test/lpm: remove unneeded checks in RCU perf tests

Browse Source 
Remove redundant error checking for reader threads
since they never return error.

Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
Cc: stable@dpdk.org

Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
This commit is contained in:
Dharmik Thakkar 2020-11-04 12:58:57 -06:00 committed by David Marchand
parent 57db1feb78
commit f02383671a
1 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
app/test/test_lpm_perf.c
View File

@ -556,11 +556,10 @@ test_lpm_rcu_perf_multi_writer(void)
__atomic_load_n(&gwrite_cycles, __ATOMIC_RELAXED) __atomic_load_n(&gwrite_cycles, __ATOMIC_RELAXED)
/ TOTAL_WRITES); / TOTAL_WRITES);
/* Wait and check return value from reader threads */
writer_done = 1; writer_done = 1;
/* Wait until all readers have exited */
for (i = 2; i < num_cores; i++) for (i = 2; i < num_cores; i++)
if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) rte_eal_wait_lcore(enabled_core_ids[i]);
goto error;
rte_lpm_free(lpm); rte_lpm_free(lpm);
rte_free(rv); rte_free(rv);
@ -605,10 +604,9 @@ test_lpm_rcu_perf_multi_writer(void)
/ TOTAL_WRITES); / TOTAL_WRITES);
writer_done = 1; writer_done = 1;
/* Wait and check return value from reader threads */ /* Wait until all readers have exited */
for (i = 2; i < num_cores; i++) for (i = 2; i < num_cores; i++)
if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) rte_eal_wait_lcore(enabled_core_ids[i]);
goto error;
rte_lpm_free(lpm); rte_lpm_free(lpm);
@ -712,10 +710,9 @@ test_lpm_rcu_perf(void)
(double)total_cycles / TOTAL_WRITES); (double)total_cycles / TOTAL_WRITES);
writer_done = 1; writer_done = 1;
/* Wait and check return value from reader threads */ /* Wait until all readers have exited */
for (i = 0; i < num_cores; i++) for (i = 0; i < num_cores; i++)
if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) rte_eal_wait_lcore(enabled_core_ids[i]);
goto error;
rte_lpm_free(lpm); rte_lpm_free(lpm);
rte_free(rv); rte_free(rv);
@ -771,11 +768,9 @@ test_lpm_rcu_perf(void)
(double)total_cycles / TOTAL_WRITES); (double)total_cycles / TOTAL_WRITES);
writer_done = 1; writer_done = 1;
/* Wait and check return value from reader threads */ /* Wait until all readers have exited */
for (i = 0; i < num_cores; i++) for (i = 0; i < num_cores; i++)
if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) rte_eal_wait_lcore(enabled_core_ids[i]);
printf("Warning: lcore %u not finished.\n",
enabled_core_ids[i]);
rte_lpm_free(lpm); rte_lpm_free(lpm);