d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/cxgbe: increase completion wait time for flow operations

Browse Source 
Under heavy load, flow related operations can take more time to
complete. Increase max completion wait time to 10 seconds. Also
increase max receive budget to read more replies from firmware
in every cycle.

Fixes: 9eb2c9a480 ("net/cxgbe: implement flow create operation")
Cc: stable@dpdk.org

Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
This commit is contained in:
Rahul Lakkireddy 2018-11-09 13:26:26 +05:30 committed by Ferruh Yigit
parent 15fb77f62c
commit f1e9d2afea
3 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/cxgbe/cxgbe_flow.c
View File

@ -797,7 +797,7 @@ static int __cxgbe_flow_create(struct rte_eth_dev *dev, struct rte_flow *flow)
/* Poll the FW for reply */
err = cxgbe_poll_for_completion(&adap->sge.fw_evtq,
CXGBE_FLOW_POLL_US,
CXGBE_FLOW_POLL_MS,
CXGBE_FLOW_POLL_CNT,
&ctx.completion);
if (err) {
@ -883,7 +883,7 @@ static int __cxgbe_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow)
/* Poll the FW for reply */
err = cxgbe_poll_for_completion(&adap->sge.fw_evtq,
CXGBE_FLOW_POLL_US,
CXGBE_FLOW_POLL_MS,
CXGBE_FLOW_POLL_CNT,
&ctx.completion);
if (err) {

5
drivers/net/cxgbe/cxgbe_flow.h
View File

@ -10,8 +10,9 @@
#include "mps_tcam.h"
#include "cxgbe.h"
#define CXGBE_FLOW_POLL_US 10
#define CXGBE_FLOW_POLL_CNT 10
/* Max poll time is 100 * 100msec = 10 sec */
#define CXGBE_FLOW_POLL_MS 100 /* 100 milliseconds */
#define CXGBE_FLOW_POLL_CNT 100 /* Max number of times to poll */
struct chrte_fparse {
int (*fptr)(const void *mask, /* currently supported mask */

8
drivers/net/cxgbe/cxgbe_main.c
View File

@ -157,18 +157,18 @@ int setup_sge_ctrl_txq(struct adapter *adapter)
/**
* cxgbe_poll_for_completion: Poll rxq for completion
* @q: rxq to poll
* @us: microseconds to delay
* @ms: milliseconds to delay
* @cnt: number of times to poll
* @c: completion to check for 'done' status
*
* Polls the rxq for reples until completion is done or the count
* expires.
*/
int cxgbe_poll_for_completion(struct sge_rspq *q, unsigned int us,
int cxgbe_poll_for_completion(struct sge_rspq *q, unsigned int ms,
unsigned int cnt, struct t4_completion *c)
{
unsigned int i;
unsigned int work_done, budget = 4;
unsigned int work_done, budget = 32;
if (!c)
return -EINVAL;
@ -181,7 +181,7 @@ int cxgbe_poll_for_completion(struct sge_rspq *q, unsigned int us,
return 0;
}
t4_os_unlock(&c->lock);
udelay(us);
rte_delay_ms(ms);
}
return -ETIMEDOUT;
}