d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eal: hide internal hotplug function

Browse Source 
This API was experimental and not properly marked in the map file.
But looking more closely, this is just an internal wrapper for EAL init.
Hide it in the hotplug code.

Fixes: 244d513071 ("eal: enable hotplug on multi-process")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
This commit is contained in:
David Marchand 2019-06-29 13:58:44 +02:00 committed by Thomas Monjalon
parent 21c17c1556
commit f319d99379
4 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/librte_eal/common/hotplug_mp.c
View File

@ -438,7 +438,7 @@ int eal_dev_hotplug_request_to_secondary(struct eal_dev_mp_req *req)
return 0;
}
int rte_mp_dev_hotplug_init(void)
int eal_mp_dev_hotplug_init(void)
{
int ret;

9
lib/librte_eal/common/hotplug_mp.h
View File

@ -28,6 +28,15 @@ struct eal_dev_mp_req {
int result;
};
/**
* Register all mp action callbacks for hotplug.
*
* @return
* 0 on success, negative on error.
*/
int
eal_mp_dev_hotplug_init(void);
/**
* This is a synchronous wrapper for secondary process send
* request to primary process, this is invoked when an attach

9
lib/librte_eal/common/include/rte_eal.h
View File

@ -408,15 +408,6 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,
int __rte_experimental
rte_mp_reply(struct rte_mp_msg *msg, const char *peer);
/**
* Register all mp action callbacks for hotplug.
*
* @return
* 0 on success, negative on error.
*/
int __rte_experimental
rte_mp_dev_hotplug_init(void);
/**
* Usage function typedef used by the application usage function.
*

3
lib/librte_eal/linux/eal/eal.c
View File

@ -59,6 +59,7 @@
#include "eal_hugepages.h"
#include "eal_options.h"
#include "eal_vfio.h"
#include "hotplug_mp.h"
#define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)
@ -1062,7 +1063,7 @@ rte_eal_init(int argc, char **argv)
}
/* register multi-process action callbacks for hotplug */
if (rte_mp_dev_hotplug_init() < 0) {
if (eal_mp_dev_hotplug_init() < 0) {
rte_eal_init_alert("failed to register mp callback for hotplug");
return -1;
}