devtools: add script to find duplicated includes

Based on Stephen's idea (originally implemented in a Perl script),
this is a shell script to find duplicated includes in a file.
It looks for all the .c and .h files of the git repository.

It is fast enough because automatically well parallelized.

Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Tested-by: Keith Wiles <keith.wiles@intel.com>
This commit is contained in:
Thomas Monjalon 2017-07-15 12:00:33 +02:00
parent 26857dabb3
commit f3cb39e882
2 changed files with 38 additions and 0 deletions

View File

@ -24,6 +24,7 @@ General Project Administration
M: Thomas Monjalon <thomas@monjalon.net>
T: git://dpdk.org/dpdk
F: MAINTAINERS
F: devtools/check-dup-includes.sh
F: devtools/check-maintainers.sh
F: devtools/check-git-log.sh
F: devtools/check-includes.sh

37
devtools/check-dup-includes.sh Executable file
View File

@ -0,0 +1,37 @@
#! /bin/sh -e
# Copyright 2017 Mellanox Technologies, Ltd. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
#
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in
# the documentation and/or other materials provided with the
# distribution.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
# IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
# CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
# TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
# SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
# Check C files in git repository for duplicated includes.
# Usage: devtools/check-dup-includes.sh [directory]
dir=${1:-$(dirname $(readlink -m $0))/..}
cd $dir
# speed up by ignoring Unicode details
export LC_ALL=C
for file in $(git ls-files '*.[ch]') ; do
sed -rn 's,^[[:space:]]*#include[[:space:]]*[<"](.*)[>"].*,\1,p' $file |
sort | uniq -d |
sed "s,^,$file: duplicated include: ,"
done