d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/nfp: fix checking function return value

Browse Source 
The fstat function could return a value that indicates an error condition.
If this is not checked, the error condition may not be handled correctly.

Coverity issue: 195019
Fixes: f37d8a4b67b2 ("net/nfp: add NSP FW upload command")

Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
This commit is contained in:
Alejandro Lucero 2017-11-08 12:19:48 +00:00 committed by Ferruh Yigit
parent eb04bc1052
commit f5cba91b09
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/nfp/nfp_nspu.c
View File

@ -341,7 +341,12 @@ nfp_fw_upload(nspu_desc_t *nspu_desc)
return -ENOENT;
}
fstat(fw_f, &file_stat);
if (fstat(fw_f, &file_stat) < 0) {
RTE_LOG(INFO, PMD, "Firmware file %s/%s size is unknown",
DEFAULT_FW_PATH, DEFAULT_FW_FILENAME);
close(fw_f);
return -ENOENT;
}
fsize = file_stat.st_size;
RTE_LOG(DEBUG, PMD, "Firmware file with size: %" PRIu64 "\n",