d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

mbuf: fix boundary check at dynamic field registration

Browse Source 
We should make sure off + size < sizeof(struct rte_mbuf) to avoid
possible out-of-bounds access of free_space array, there is no issue
currently due to the low bits of free_flags (which is adjacent to
free_space) are always set to 0. But we shouldn't rely on it since it's
fragile and layout of struct mbuf_dyn_shm may be changed in the future.
This patch adds boundary check explicitly to avoid potential risk of
out-of-bounds access.

Fixes: 4958ca3a44 ("mbuf: support dynamic fields and flags")
Cc: stable@dpdk.org

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
This commit is contained in:
Xiaolong Ye 2020-06-13 23:49:17 +08:00 committed by Thomas Monjalon
parent 54f3fb127d
commit f8eb26dda8
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/librte_mbuf/rte_mbuf_dyn.c
View File

@ -69,7 +69,8 @@ process_score(void)
for (off = 0; off < sizeof(struct rte_mbuf); off++) {
/* get the size of the free zone */
for (size = 0; shm->free_space[off + size]; size++)
for (size = 0; (off + size) < sizeof(struct rte_mbuf) &&
shm->free_space[off + size]; size++)
;
if (size == 0)
continue;