d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ethdev: fix MAC address in telemetry device info

Browse Source 
The right size for a human readable MAC is RTE_ETHER_ADDR_FMT_SIZE.
While at it, the net library provides a helper for MAC address
formatting. Prefer it.

Fixes: 58b43c1ddf ("ethdev: add telemetry endpoint for device info")
Cc: stable@dpdk.org

Reported-by: Christophe Fontaine <cfontain@redhat.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
This commit is contained in:
David Marchand 2022-02-16 15:13:16 +01:00 committed by Ferruh Yigit
parent 23abab4f14
commit ffe77e911f
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/ethdev/rte_ethdev.c
View File

@ -5631,7 +5631,7 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
struct rte_tel_data *d)
{
struct rte_tel_data *rxq_state, *txq_state;
char mac_addr[RTE_ETHER_ADDR_LEN];
char mac_addr[RTE_ETHER_ADDR_FMT_SIZE];
struct rte_eth_dev *eth_dev;
char *end_param;
int port_id, i;
@ -5672,13 +5672,8 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
eth_dev->data->min_rx_buf_size);
rte_tel_data_add_dict_int(d, "rx_mbuf_alloc_fail",
eth_dev->data->rx_mbuf_alloc_failed);
snprintf(mac_addr, RTE_ETHER_ADDR_LEN, "%02x:%02x:%02x:%02x:%02x:%02x",
eth_dev->data->mac_addrs->addr_bytes[0],
eth_dev->data->mac_addrs->addr_bytes[1],
eth_dev->data->mac_addrs->addr_bytes[2],
eth_dev->data->mac_addrs->addr_bytes[3],
eth_dev->data->mac_addrs->addr_bytes[4],
eth_dev->data->mac_addrs->addr_bytes[5]);
rte_ether_format_addr(mac_addr, sizeof(mac_addr),
eth_dev->data->mac_addrs);
rte_tel_data_add_dict_string(d, "mac_addr", mac_addr);
rte_tel_data_add_dict_int(d, "promiscuous",
eth_dev->data->promiscuous);