cb2587644e
checkpatches.sh current complains on a patch [1] adding
ALLOW_EXPERIMENTAL_API in an example while this check is for app, lib
and drivers directories:
Warning in examples/ethtool/ethtool-app/Makefile:
Using experimental build flag for in-tree compilation
The regexp on entering files concerned by this filter is incorrect.
In the [1] case, the file full name is matched against "app" rather than
"+++ b/app".
1: https://patchwork.dpdk.org/patch/83902/
Fixes: 7413e7f2ae ("devtools: alert on new calls to exit from libs")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
70 lines
1.6 KiB
Awk
Executable File
70 lines
1.6 KiB
Awk
Executable File
# SPDX-License-Identifier: BSD-3-Clause
|
|
# Copyright 2018 Arnon Warshavsky <arnon@qwilt.com>
|
|
|
|
# This awk script receives a list of expressions to monitor
|
|
# and a list of folders to search these expressions in
|
|
# - No search is done inside comments
|
|
# - Both additions and removals of the expressions are checked
|
|
# A positive balance of additions fails the check
|
|
|
|
BEGIN {
|
|
split(FOLDERS,deny_folders," ");
|
|
split(EXPRESSIONS,deny_expr," ");
|
|
in_file=0;
|
|
in_comment=0;
|
|
count=0;
|
|
comment_start="/*"
|
|
comment_end="*/"
|
|
}
|
|
# search for add/remove instances in current file
|
|
# state machine assumes the comments structure is enforced by
|
|
# checkpatches.pl
|
|
(in_file) {
|
|
# comment start
|
|
if (index($0,comment_start) > 0) {
|
|
in_comment = 1
|
|
}
|
|
# non comment code
|
|
if (in_comment == 0) {
|
|
for (i in deny_expr) {
|
|
forbidden_added = "^\\+.*" deny_expr[i];
|
|
forbidden_removed="^-.*" deny_expr[i];
|
|
current = expressions[deny_expr[i]]
|
|
if ($0 ~ forbidden_added) {
|
|
count = count + 1;
|
|
expressions[deny_expr[i]] = current + 1
|
|
}
|
|
if ($0 ~ forbidden_removed) {
|
|
count = count - 1;
|
|
expressions[deny_expr[i]] = current - 1
|
|
}
|
|
}
|
|
}
|
|
# comment end
|
|
if (index($0,comment_end) > 0) {
|
|
in_comment = 0
|
|
}
|
|
}
|
|
# switch to next file , check if the balance of add/remove
|
|
# of previous filehad new additions
|
|
($0 ~ "^\\+\\+\\+ b/") {
|
|
in_file = 0;
|
|
if (count > 0) {
|
|
exit;
|
|
}
|
|
for (i in deny_folders) {
|
|
re = "^\\+\\+\\+ b/" deny_folders[i];
|
|
if ($0 ~ re) {
|
|
in_file = 1
|
|
last_file = $0
|
|
}
|
|
}
|
|
}
|
|
END {
|
|
if (count > 0) {
|
|
print "Warning in " substr(last_file,7) ":"
|
|
print MESSAGE
|
|
exit RET_ON_FAIL
|
|
}
|
|
}
|