Go to file
Olivier Matz 2329a101f4 ethdev: fix xstats retrieval with a null array
Coverity reports an issue in ethdev:

  *** CID 124562:  Null pointer dereferences  (FORWARD_NULL)
  /lib/librte_ether/rte_ethdev.c: 1518 in rte_eth_xstats_get()
  1512
  1513		/* global stats */
  1514     	for (i = 0; i < RTE_NB_STATS; i++) {
  1515     	    stats_ptr = RTE_PTR_ADD(&eth_stats,
  1516
  rte_stats_strings[i].offset);
  1517			val = *stats_ptr;
  >>>     CID 124562:  Null pointer dereferences  (FORWARD_NULL)
  >>>     Dereferencing null pointer "xstats".
  1518     	      	   snprintf(xstats[count].name,
  sizeof(xstats[count].name),
  1519				"%s", rte_stats_strings[i].name);
  1520     			      xstats[count++].value = val;
  1521     			      }
  1522
  1523		/* per-rxq stats */

If a user calls rte_eth_xstats_get(portid, NULL, n) with n != 0,
it may result in a crash. Although the API documentation says that
n is the size of the table and xstats can be NULL if n == 0, we
can add an additional check here to make Coverity happy.

In that case, the return value is the same than when n == 0 is
passed, it returns the number of statistics.

Fixes: ce757f5c9a ("ethdev: new method to retrieve extended statistics")

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
2016-04-06 12:27:57 +02:00
app app/test: increase memory for group 2 2016-04-06 12:10:05 +02:00
config config: fix CPU and memory parameters on IBM POWER8 2016-04-01 12:44:58 +02:00
doc doc: fill nics features matrix for virtio 2016-04-06 11:08:42 +02:00
drivers ethdev: add 100G link speed 2016-04-01 21:38:34 +02:00
examples examples/l3fwd: fix crash with gcc 5 2016-04-06 11:35:33 +02:00
lib ethdev: fix xstats retrieval with a null array 2016-04-06 12:27:57 +02:00
mk port: clean up 2016-04-01 23:08:25 +02:00
pkg version: 2.2.0 2015-12-15 18:06:58 +01:00
scripts scripts: improve quiet checkpatch 2016-03-24 22:16:01 +01:00
tools tools: fix setup with built-in kernel modules 2016-03-24 22:04:10 +01:00
.gitignore init DPDK repository 2013-03-07 10:57:42 +01:00
GNUmakefile drivers: create new directory 2015-05-22 15:51:38 +02:00
LICENSE.GPL doc: GPL/LGPL licenses 2013-07-25 14:43:06 +02:00
LICENSE.LGPL doc: fix file format (dos to unix) 2013-09-06 11:43:07 +02:00
MAINTAINERS maintainers: claim responsibility for Intel i40e driver 2016-04-01 23:08:25 +02:00
Makefile remove trailing whitespaces 2014-06-11 00:29:34 +02:00
README doc: add readme file 2015-12-13 22:06:58 +01:00

DPDK is a set of libraries and drivers for fast packet processing.
It supports many processor architectures and both FreeBSD and Linux.

The DPDK uses the Open Source BSD license for the core libraries and
drivers. The kernel components are GPLv2 licensed.

Please check the doc directory for release notes,
API documentation, and sample application information.

For questions and usage discussions, subscribe to: users@dpdk.org
Report bugs and issues to the development mailing list: dev@dpdk.org