24252a60ad
A compiler can reuse a variable name and prefix it when instrumenting
with coverage.
Example:
$ make defconfig T=x86_64-native-linux-gcc O=master
$ make EXTRA_CFLAGS='--coverage' O=master
[...]
CC rte_flow.o
rte_flow_dynf_metadata_offs is not flagged as experimental but is listed
in version map
Please add __rte_experimental to the definition of
rte_flow_dynf_metadata_offs
$ objdump -t master/build/lib/librte_ethdev/rte_flow.o |grep _offs$
0000000000000000 l F .text.startup 000000000000000a
_GLOBAL__sub_I_65535_0_rte_flow_dynf_metadata_offs
0000000000000620 g O .data 0000000000000004
rte_flow_dynf_metadata_offs
Protect against this by adding a space character in the pattern.
Fixes: a4bcd61de8 ("buildtools: add script to check experimental API exports")
Cc: stable@dpdk.org
Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
58 lines
1.1 KiB
Bash
Executable File
58 lines
1.1 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
# SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
MAPFILE=$1
|
|
OBJFILE=$2
|
|
|
|
LIST_SYMBOL=$(dirname $(readlink -f $0))/map-list-symbol.sh
|
|
|
|
# added check for "make -C test/" usage
|
|
if [ ! -e $MAPFILE ] || [ ! -f $OBJFILE ]
|
|
then
|
|
exit 0
|
|
fi
|
|
|
|
if [ -d $MAPFILE ]
|
|
then
|
|
exit 0
|
|
fi
|
|
|
|
DUMPFILE=$(mktemp -t dpdk.${0##*/}.XXX.objdump)
|
|
trap 'rm -f "$DUMPFILE"' EXIT
|
|
objdump -t $OBJFILE >$DUMPFILE
|
|
|
|
ret=0
|
|
for SYM in `$LIST_SYMBOL -S EXPERIMENTAL $MAPFILE |cut -d ' ' -f 3`
|
|
do
|
|
if grep -q "\.text.*[[:space:]]$SYM$" $DUMPFILE &&
|
|
! grep -q "\.text\.experimental.*[[:space:]]$SYM$" $DUMPFILE
|
|
then
|
|
cat >&2 <<- END_OF_MESSAGE
|
|
$SYM is not flagged as experimental
|
|
but is listed in version map
|
|
Please add __rte_experimental to the definition of $SYM
|
|
END_OF_MESSAGE
|
|
ret=1
|
|
fi
|
|
done
|
|
|
|
# Filter out symbols suffixed with a . for icc
|
|
for SYM in `awk '{
|
|
if ($2 != "l" && $4 == ".text.experimental" && !($NF ~ /\.$/)) {
|
|
print $NF
|
|
}
|
|
}' $DUMPFILE`
|
|
do
|
|
$LIST_SYMBOL -S EXPERIMENTAL -s $SYM -q $MAPFILE || {
|
|
cat >&2 <<- END_OF_MESSAGE
|
|
$SYM is flagged as experimental
|
|
but is not listed in version map
|
|
Please add $SYM to the version map
|
|
END_OF_MESSAGE
|
|
ret=1
|
|
}
|
|
done
|
|
|
|
exit $ret
|