numam-dpdk/lib/librte_table
David Marchand 18218713bf enforce experimental tag at beginning of declarations
Putting a '__attribute__((deprecated))' in the middle of a function
prototype does not result in the expected result with gcc (while clang
is fine with this syntax).

$ cat deprecated.c
void * __attribute__((deprecated)) incorrect() { return 0; }
__attribute__((deprecated)) void *correct(void) { return 0; }
int main(int argc, char *argv[]) { incorrect(); correct(); return 0; }
$ gcc -o deprecated.o -c deprecated.c
deprecated.c: In function ‘main’:
deprecated.c:3:1: warning: ‘correct’ is deprecated (declared at
deprecated.c:2) [-Wdeprecated-declarations]
 int main(int argc, char *argv[]) { incorrect(); correct(); return 0; }
 ^

Move the tag on a separate line and make it the first thing of function
prototypes.
This is not perfect but we will trust reviewers to catch the other not
so easy to detect patterns.

sed -i \
     -e '/^\([^#].*\)\?__rte_experimental */{' \
     -e 's//\1/; s/ *$//; i\' \
     -e __rte_experimental \
     -e '/^$/d}' \
     $(git grep -l __rte_experimental -- '*.h')

Special mention for rte_mbuf_data_addr_default():

There is either a bug or a (not yet understood) issue with gcc.
gcc won't drop this inline when unused and rte_mbuf_data_addr_default()
calls rte_mbuf_buf_addr() which itself is experimental.
This results in a build warning when not accepting experimental apis
from sources just including rte_mbuf.h.

For this specific case, we hide the call to rte_mbuf_buf_addr() under
the ALLOW_EXPERIMENTAL_API flag.

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
2019-06-29 19:04:48 +02:00
..
Makefile lib/librte_table: add hash function headers 2018-10-12 17:58:53 +02:00
meson.build lib/librte_table: add hash function headers 2018-10-12 17:58:53 +02:00
rte_lru_arm64.h lib: use SPDX tag for Cavium copyright files 2018-01-09 16:19:01 +01:00
rte_lru_x86.h lib: fix missing includes in exported headers 2018-01-17 00:31:05 +01:00
rte_lru.h lib: fix missing includes in exported headers 2018-01-17 00:31:05 +01:00
rte_table_acl.c table: remove incorrect check for ACL 2018-04-04 12:26:20 +02:00
rte_table_acl.h lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_array.c lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_array.h lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_hash_cuckoo.c table: add dedicated params struct for cuckoo hash 2018-05-08 16:19:58 +02:00
rte_table_hash_cuckoo.h table: add dedicated params struct for cuckoo hash 2018-05-08 16:19:58 +02:00
rte_table_hash_ext.c lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_hash_func_arm64.h lib/librte_table: add hash function headers 2018-10-12 17:58:53 +02:00
rte_table_hash_func.h enforce experimental tag at beginning of declarations 2019-06-29 19:04:48 +02:00
rte_table_hash_key8.c lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_hash_key16.c lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_hash_key32.c lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_hash_lru.c lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_hash.h doc: fix spelling reported by aspell in comments 2019-05-03 00:38:14 +02:00
rte_table_lpm_ipv6.c lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_lpm_ipv6.h lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_lpm.c lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_lpm.h lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_stub.c lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_stub.h lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_table_version.map table: update library version 2017-10-24 13:38:31 +02:00
rte_table.h lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00