numam-dpdk/app
Lukasz Wojciechowski 048db4b6dc service: fix core mapping reset
The rte_service_lcore_reset_all function stops execution of services
on all lcores and switches them back from ROLE_SERVICE to ROLE_RTE.
However the thread loop for slave lcores (eal_thread_loop) distincts these
roles to set lcore state after processing delegated function.
It sets WAIT state for ROLE_SERVICE, but FINISHED for ROLE_RTE.
So changing the role to RTE before stopping work in slave lcores
causes lcores to end in FINISHED state. That is why the rte_eal_lcore_wait
must be run after rte_service_lcore_reset_all to bring back lcores to
launchable (WAIT) state.
This has been fixed in test app and clarified in API documentation.

Setting the state to WAIT in rte_service_runner_func is premature
as the rte_service_runner_func function is still a part of the lcore
function delegated to slave lcore. The state is overwritten anyway in
slave lcore thread loop. This premature setting state to WAIT might
however cause rte_eal_lcore_wait, that was called by the application,
to return before slave lcore thread set the FINISHED state. That's
why it is removed from librte_eal rte_service_runner_func function.

Bugzilla ID: 464
Fixes: 21698354c8 ("service: introduce service cores concept")
Fixes: f038a81e1c ("service: add unit tests")
Cc: stable@dpdk.org

Reported-by: Sarosh Arif <sarosh.arif@emumba.com>
Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
2020-07-08 18:52:49 +02:00
..
pdump app: fix usage help of options separated by dashes 2020-04-25 21:56:18 +02:00
proc-info
test service: fix core mapping reset 2020-07-08 18:52:49 +02:00
test-acl app: fix usage help of options separated by dashes 2020-04-25 21:56:18 +02:00
test-bbdev
test-cmdline
test-compress-perf
test-crypto-perf test/crypto-perf: add option to enable session HFN 2020-07-08 18:16:17 +02:00
test-eventdev app/eventdev: check Tx adapter service ID 2020-05-14 15:16:37 +02:00
test-fib app/fib: fix parsing of invalid line 2020-05-19 19:25:30 +02:00
test-flow-perf app/flow-perf: use macro for cache alignment 2020-06-30 11:57:46 +02:00
test-pipeline
test-pmd app/testpmd: fix error detection in MTU command 2020-06-16 19:21:07 +02:00
test-sad
Makefile app/flow-perf: add flow performance skeleton 2020-06-29 15:47:36 +02:00
meson.build build: remove unnecessary variable 2020-07-01 19:30:52 +02:00