18218713bf
Putting a '__attribute__((deprecated))' in the middle of a function
prototype does not result in the expected result with gcc (while clang
is fine with this syntax).
$ cat deprecated.c
void * __attribute__((deprecated)) incorrect() { return 0; }
__attribute__((deprecated)) void *correct(void) { return 0; }
int main(int argc, char *argv[]) { incorrect(); correct(); return 0; }
$ gcc -o deprecated.o -c deprecated.c
deprecated.c: In function ‘main’:
deprecated.c:3:1: warning: ‘correct’ is deprecated (declared at
deprecated.c:2) [-Wdeprecated-declarations]
int main(int argc, char *argv[]) { incorrect(); correct(); return 0; }
^
Move the tag on a separate line and make it the first thing of function
prototypes.
This is not perfect but we will trust reviewers to catch the other not
so easy to detect patterns.
sed -i \
-e '/^\([^#].*\)\?__rte_experimental */{' \
-e 's//\1/; s/ *$//; i\' \
-e __rte_experimental \
-e '/^$/d}' \
$(git grep -l __rte_experimental -- '*.h')
Special mention for rte_mbuf_data_addr_default():
There is either a bug or a (not yet understood) issue with gcc.
gcc won't drop this inline when unused and rte_mbuf_data_addr_default()
calls rte_mbuf_buf_addr() which itself is experimental.
This results in a build warning when not accepting experimental apis
from sources just including rte_mbuf.h.
For this specific case, we hide the call to rte_mbuf_buf_addr() under
the ALLOW_EXPERIMENTAL_API flag.
Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Signed-off-by: David Marchand <david.marchand@redhat.com>
125 lines
2.7 KiB
C
125 lines
2.7 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause
|
|
* Copyright(c) 2019 Intel Corporation
|
|
*/
|
|
|
|
#ifndef _RTE_STACK_STD_H_
|
|
#define _RTE_STACK_STD_H_
|
|
|
|
#include <rte_branch_prediction.h>
|
|
|
|
/**
|
|
* @internal Push several objects on the stack (MT-safe).
|
|
*
|
|
* @param s
|
|
* A pointer to the stack structure.
|
|
* @param obj_table
|
|
* A pointer to a table of void * pointers (objects).
|
|
* @param n
|
|
* The number of objects to push on the stack from the obj_table.
|
|
* @return
|
|
* Actual number of objects pushed (either 0 or *n*).
|
|
*/
|
|
__rte_experimental
|
|
static __rte_always_inline unsigned int
|
|
__rte_stack_std_push(struct rte_stack *s, void * const *obj_table,
|
|
unsigned int n)
|
|
{
|
|
struct rte_stack_std *stack = &s->stack_std;
|
|
unsigned int index;
|
|
void **cache_objs;
|
|
|
|
rte_spinlock_lock(&stack->lock);
|
|
cache_objs = &stack->objs[stack->len];
|
|
|
|
/* Is there sufficient space in the stack? */
|
|
if ((stack->len + n) > s->capacity) {
|
|
rte_spinlock_unlock(&stack->lock);
|
|
return 0;
|
|
}
|
|
|
|
/* Add elements back into the cache */
|
|
for (index = 0; index < n; ++index, obj_table++)
|
|
cache_objs[index] = *obj_table;
|
|
|
|
stack->len += n;
|
|
|
|
rte_spinlock_unlock(&stack->lock);
|
|
return n;
|
|
}
|
|
|
|
/**
|
|
* @internal Pop several objects from the stack (MT-safe).
|
|
*
|
|
* @param s
|
|
* A pointer to the stack structure.
|
|
* @param obj_table
|
|
* A pointer to a table of void * pointers (objects).
|
|
* @param n
|
|
* The number of objects to pull from the stack.
|
|
* @return
|
|
* Actual number of objects popped (either 0 or *n*).
|
|
*/
|
|
__rte_experimental
|
|
static __rte_always_inline unsigned int
|
|
__rte_stack_std_pop(struct rte_stack *s, void **obj_table, unsigned int n)
|
|
{
|
|
struct rte_stack_std *stack = &s->stack_std;
|
|
unsigned int index, len;
|
|
void **cache_objs;
|
|
|
|
rte_spinlock_lock(&stack->lock);
|
|
|
|
if (unlikely(n > stack->len)) {
|
|
rte_spinlock_unlock(&stack->lock);
|
|
return 0;
|
|
}
|
|
|
|
cache_objs = stack->objs;
|
|
|
|
for (index = 0, len = stack->len - 1; index < n;
|
|
++index, len--, obj_table++)
|
|
*obj_table = cache_objs[len];
|
|
|
|
stack->len -= n;
|
|
rte_spinlock_unlock(&stack->lock);
|
|
|
|
return n;
|
|
}
|
|
|
|
/**
|
|
* @internal Return the number of used entries in a stack.
|
|
*
|
|
* @param s
|
|
* A pointer to the stack structure.
|
|
* @return
|
|
* The number of used entries in the stack.
|
|
*/
|
|
__rte_experimental
|
|
static __rte_always_inline unsigned int
|
|
__rte_stack_std_count(struct rte_stack *s)
|
|
{
|
|
return (unsigned int)s->stack_std.len;
|
|
}
|
|
|
|
/**
|
|
* @internal Initialize a standard stack.
|
|
*
|
|
* @param s
|
|
* A pointer to the stack structure.
|
|
*/
|
|
void
|
|
rte_stack_std_init(struct rte_stack *s);
|
|
|
|
/**
|
|
* @internal Return the memory required for a standard stack.
|
|
*
|
|
* @param count
|
|
* The size of the stack.
|
|
* @return
|
|
* The bytes to allocate for a standard stack.
|
|
*/
|
|
ssize_t
|
|
rte_stack_std_get_memsize(unsigned int count);
|
|
|
|
#endif /* _RTE_STACK_STD_H_ */
|