b2bb3a5daa
Add RTE_DEVEL_BUILD make-variable which can be used to do things differently when doing development vs building a release, autodetected from source root .git presence and overridable via commandline. It is used it to enable -Werror compiler flag and may be extended to other checks. Failing build on warnings is a useful developer tool but its bad for release tarballs which can and do get built with newer compilers than what was used/available during development. Compilers routinely add new warnings so code which built silently with cc X might no longer do so with X+1. This doesn't make the existing code any more buggier and failing the build in this case does not help to improve the quality of an already released version either. This change the default flags which can be tuned with EXTRA_CFLAGS. Signed-off-by: Panu Matilainen <pmatilai@redhat.com> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
104 lines
3.7 KiB
Makefile
104 lines
3.7 KiB
Makefile
# BSD LICENSE
|
|
#
|
|
# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
|
|
# All rights reserved.
|
|
#
|
|
# Redistribution and use in source and binary forms, with or without
|
|
# modification, are permitted provided that the following conditions
|
|
# are met:
|
|
#
|
|
# * Redistributions of source code must retain the above copyright
|
|
# notice, this list of conditions and the following disclaimer.
|
|
# * Redistributions in binary form must reproduce the above copyright
|
|
# notice, this list of conditions and the following disclaimer in
|
|
# the documentation and/or other materials provided with the
|
|
# distribution.
|
|
# * Neither the name of Intel Corporation nor the names of its
|
|
# contributors may be used to endorse or promote products derived
|
|
# from this software without specific prior written permission.
|
|
#
|
|
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
#
|
|
# toolchain:
|
|
#
|
|
# - define CC, LD, AR, AS, ... (overriden by cmdline value)
|
|
# - define TOOLCHAIN_CFLAGS variable (overriden by cmdline value)
|
|
# - define TOOLCHAIN_LDFLAGS variable (overriden by cmdline value)
|
|
# - define TOOLCHAIN_ASFLAGS variable (overriden by cmdline value)
|
|
#
|
|
|
|
CC = $(CROSS)gcc
|
|
KERNELCC = $(CROSS)gcc
|
|
CPP = $(CROSS)cpp
|
|
# for now, we don't use as but nasm.
|
|
# AS = $(CROSS)as
|
|
AS = nasm
|
|
AR = $(CROSS)ar
|
|
LD = $(CROSS)ld
|
|
OBJCOPY = $(CROSS)objcopy
|
|
OBJDUMP = $(CROSS)objdump
|
|
STRIP = $(CROSS)strip
|
|
READELF = $(CROSS)readelf
|
|
GCOV = $(CROSS)gcov
|
|
|
|
ifeq ("$(origin CC)", "command line")
|
|
HOSTCC = $(CC)
|
|
else
|
|
HOSTCC = gcc
|
|
endif
|
|
HOSTAS = as
|
|
|
|
TOOLCHAIN_ASFLAGS =
|
|
TOOLCHAIN_CFLAGS =
|
|
TOOLCHAIN_LDFLAGS =
|
|
|
|
ifeq ($(CONFIG_RTE_LIBRTE_GCOV),y)
|
|
TOOLCHAIN_CFLAGS += --coverage
|
|
TOOLCHAIN_LDFLAGS += --coverage
|
|
ifeq (,$(findstring -O0,$(EXTRA_CFLAGS)))
|
|
$(warning "EXTRA_CFLAGS doesn't contains -O0, coverage will be inaccurate with optimizations enabled")
|
|
endif
|
|
endif
|
|
|
|
WERROR_FLAGS := -W -Wall -Wstrict-prototypes -Wmissing-prototypes
|
|
WERROR_FLAGS += -Wmissing-declarations -Wold-style-definition -Wpointer-arith
|
|
WERROR_FLAGS += -Wcast-align -Wnested-externs -Wcast-qual
|
|
WERROR_FLAGS += -Wformat-nonliteral -Wformat-security
|
|
WERROR_FLAGS += -Wundef -Wwrite-strings
|
|
|
|
ifeq ($(RTE_DEVEL_BUILD),y)
|
|
WERROR_FLAGS += -Werror
|
|
endif
|
|
|
|
# There are many issues reported for ARMv7 architecture
|
|
# which are not necessarily fatal. Report as warnings.
|
|
ifeq ($(CONFIG_RTE_ARCH_ARMv7),y)
|
|
WERROR_FLAGS += -Wno-error=cast-align
|
|
endif
|
|
|
|
# process cpu flags
|
|
include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk
|
|
|
|
# workaround GCC bug with warning "missing initializer" for "= {0}"
|
|
ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1)
|
|
WERROR_FLAGS += -Wno-missing-field-initializers
|
|
endif
|
|
# workaround GCC bug with warning "may be used uninitialized"
|
|
ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1)
|
|
WERROR_FLAGS += -Wno-uninitialized
|
|
endif
|
|
|
|
export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF
|
|
export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS
|