cf8a9e93ac
Hook check-symbol-maps.sh in the symbol check when in developer mode to help developers catch issues before submitting their changes. Signed-off-by: David Marchand <david.marchand@redhat.com> Reviewed-by: Ray Kinsella <mdr@ashroe.eu>
97 lines
2.1 KiB
Bash
Executable File
97 lines
2.1 KiB
Bash
Executable File
#!/bin/sh
|
|
|
|
# SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
MAPFILE=$1
|
|
OBJFILE=$2
|
|
|
|
ROOTDIR=$(readlink -f $(dirname $(readlink -f $0))/..)
|
|
LIST_SYMBOL=$ROOTDIR/buildtools/map-list-symbol.sh
|
|
CHECK_SYMBOL_MAPS=$ROOTDIR/devtools/check-symbol-maps.sh
|
|
|
|
# added check for "make -C test/" usage
|
|
if [ ! -e $MAPFILE ] || [ ! -f $OBJFILE ]
|
|
then
|
|
exit 0
|
|
fi
|
|
|
|
if [ -d $MAPFILE ]
|
|
then
|
|
exit 0
|
|
fi
|
|
|
|
DUMPFILE=$(mktemp -t dpdk.${0##*/}.objdump.XXXXXX)
|
|
trap 'rm -f "$DUMPFILE"' EXIT
|
|
objdump -t $OBJFILE >$DUMPFILE
|
|
|
|
ret=0
|
|
|
|
if ! $CHECK_SYMBOL_MAPS $MAPFILE; then
|
|
ret=1
|
|
fi
|
|
|
|
for SYM in `$LIST_SYMBOL -S EXPERIMENTAL $MAPFILE |cut -d ' ' -f 3`
|
|
do
|
|
if grep -q "\.text.*[[:space:]]$SYM$" $DUMPFILE &&
|
|
! grep -q "\.text\.experimental.*[[:space:]]$SYM$" $DUMPFILE &&
|
|
$LIST_SYMBOL -s $SYM $MAPFILE | grep -q EXPERIMENTAL
|
|
then
|
|
cat >&2 <<- END_OF_MESSAGE
|
|
$SYM is not flagged as experimental
|
|
but is listed in version map
|
|
Please add __rte_experimental to the definition of $SYM
|
|
END_OF_MESSAGE
|
|
ret=1
|
|
fi
|
|
done
|
|
|
|
# Filter out symbols suffixed with a . for icc
|
|
for SYM in `awk '{
|
|
if ($2 != "l" && $4 == ".text.experimental" && !($NF ~ /\.$/)) {
|
|
print $NF
|
|
}
|
|
}' $DUMPFILE`
|
|
do
|
|
$LIST_SYMBOL -S EXPERIMENTAL -s $SYM -q $MAPFILE || {
|
|
cat >&2 <<- END_OF_MESSAGE
|
|
$SYM is flagged as experimental
|
|
but is not listed in version map
|
|
Please add $SYM to the version map
|
|
END_OF_MESSAGE
|
|
ret=1
|
|
}
|
|
done
|
|
|
|
for SYM in `$LIST_SYMBOL -S INTERNAL $MAPFILE |cut -d ' ' -f 3`
|
|
do
|
|
if grep -q "\.text.*[[:space:]]$SYM$" $DUMPFILE &&
|
|
! grep -q "\.text\.internal.*[[:space:]]$SYM$" $DUMPFILE
|
|
then
|
|
cat >&2 <<- END_OF_MESSAGE
|
|
$SYM is not flagged as internal
|
|
but is listed in version map
|
|
Please add __rte_internal to the definition of $SYM
|
|
END_OF_MESSAGE
|
|
ret=1
|
|
fi
|
|
done
|
|
|
|
# Filter out symbols suffixed with a . for icc
|
|
for SYM in `awk '{
|
|
if ($2 != "l" && $4 == ".text.internal" && !($NF ~ /\.$/)) {
|
|
print $NF
|
|
}
|
|
}' $DUMPFILE`
|
|
do
|
|
$LIST_SYMBOL -S INTERNAL -s $SYM -q $MAPFILE || {
|
|
cat >&2 <<- END_OF_MESSAGE
|
|
$SYM is flagged as internal
|
|
but is not listed in version map
|
|
Please add $SYM to the version map
|
|
END_OF_MESSAGE
|
|
ret=1
|
|
}
|
|
done
|
|
|
|
exit $ret
|