There is a school of thought that rte_eth_dev_default_mac_addr_set() must call the PMD callback first and then save the new MAC address in dev->data->mac_addrs[0]. If this concept gets approved, it will break the current approach used in sfc driver as the latter relies on the assumption that the new MAC address is already contained in dev->data->mac_addrs[0], and, if adapter restart is needed to make the HW apply the new address, the outdated value will be retrieved from dev->data. In order to preclude any possible bugs, this patch adds device private storage for the up-to-date copy of the address. Fixes: c100fd464bb7 ("net/sfc: support main MAC address change") Cc: stable@dpdk.org Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
DPDK is a set of libraries and drivers for fast packet processing. It supports many processor architectures and both FreeBSD and Linux. The DPDK uses the Open Source BSD-3-Clause license for the core libraries and drivers. The kernel components are GPL-2.0 licensed. Please check the doc directory for release notes, API documentation, and sample application information. For questions and usage discussions, subscribe to: users@dpdk.org Report bugs and issues to the development mailing list: dev@dpdk.org
Description
Languages
C
99.1%
Meson
0.5%
Python
0.2%
Shell
0.1%