675911d033
Rearrangement of WQ and CQ creation for Verbs Rx queue: 1. Rename the allocation function. 2. Reduce the number of arguments that the creation functions receive. Signed-off-by: Michael Baum <michaelba@nvidia.com> Acked-by: Matan Azrad <matan@nvidia.com>
431 lines
12 KiB
C
431 lines
12 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause
|
|
* Copyright 2020 Mellanox Technologies, Ltd
|
|
*/
|
|
|
|
#include <stddef.h>
|
|
#include <errno.h>
|
|
#include <string.h>
|
|
#include <stdint.h>
|
|
#include <unistd.h>
|
|
#include <inttypes.h>
|
|
#include <sys/queue.h>
|
|
|
|
#include "mlx5_autoconf.h"
|
|
|
|
#include <rte_mbuf.h>
|
|
#include <rte_malloc.h>
|
|
#include <rte_ethdev_driver.h>
|
|
#include <rte_common.h>
|
|
|
|
#include <mlx5_glue.h>
|
|
#include <mlx5_common.h>
|
|
#include <mlx5_common_mr.h>
|
|
#include <mlx5_rxtx.h>
|
|
#include <mlx5_verbs.h>
|
|
#include <mlx5_utils.h>
|
|
#include <mlx5_malloc.h>
|
|
|
|
/**
|
|
* Register mr. Given protection domain pointer, pointer to addr and length
|
|
* register the memory region.
|
|
*
|
|
* @param[in] pd
|
|
* Pointer to protection domain context.
|
|
* @param[in] addr
|
|
* Pointer to memory start address.
|
|
* @param[in] length
|
|
* Length of the memory to register.
|
|
* @param[out] pmd_mr
|
|
* pmd_mr struct set with lkey, address, length and pointer to mr object
|
|
*
|
|
* @return
|
|
* 0 on successful registration, -1 otherwise
|
|
*/
|
|
static int
|
|
mlx5_reg_mr(void *pd, void *addr, size_t length,
|
|
struct mlx5_pmd_mr *pmd_mr)
|
|
{
|
|
return mlx5_common_verbs_reg_mr(pd, addr, length, pmd_mr);
|
|
}
|
|
|
|
/**
|
|
* Deregister mr. Given the mlx5 pmd MR - deregister the MR
|
|
*
|
|
* @param[in] pmd_mr
|
|
* pmd_mr struct set with lkey, address, length and pointer to mr object
|
|
*
|
|
*/
|
|
static void
|
|
mlx5_dereg_mr(struct mlx5_pmd_mr *pmd_mr)
|
|
{
|
|
mlx5_common_verbs_dereg_mr(pmd_mr);
|
|
}
|
|
|
|
/* verbs operations. */
|
|
const struct mlx5_verbs_ops mlx5_verbs_ops = {
|
|
.reg_mr = mlx5_reg_mr,
|
|
.dereg_mr = mlx5_dereg_mr,
|
|
};
|
|
|
|
/**
|
|
* Modify Rx WQ vlan stripping offload
|
|
*
|
|
* @param rxq_obj
|
|
* Rx queue object.
|
|
*
|
|
* @return 0 on success, non-0 otherwise
|
|
*/
|
|
static int
|
|
mlx5_rxq_obj_modify_wq_vlan_strip(struct mlx5_rxq_obj *rxq_obj, int on)
|
|
{
|
|
uint16_t vlan_offloads =
|
|
(on ? IBV_WQ_FLAGS_CVLAN_STRIPPING : 0) |
|
|
0;
|
|
struct ibv_wq_attr mod;
|
|
mod = (struct ibv_wq_attr){
|
|
.attr_mask = IBV_WQ_ATTR_FLAGS,
|
|
.flags_mask = IBV_WQ_FLAGS_CVLAN_STRIPPING,
|
|
.flags = vlan_offloads,
|
|
};
|
|
return mlx5_glue->modify_wq(rxq_obj->wq, &mod);
|
|
}
|
|
|
|
/**
|
|
* Create a CQ Verbs object.
|
|
*
|
|
* @param dev
|
|
* Pointer to Ethernet device.
|
|
* @param idx
|
|
* Queue index in DPDK Rx queue array.
|
|
*
|
|
* @return
|
|
* The Verbs CQ object initialized, NULL otherwise and rte_errno is set.
|
|
*/
|
|
static struct ibv_cq *
|
|
mlx5_rxq_ibv_cq_create(struct rte_eth_dev *dev, uint16_t idx)
|
|
{
|
|
struct mlx5_priv *priv = dev->data->dev_private;
|
|
struct mlx5_rxq_data *rxq_data = (*priv->rxqs)[idx];
|
|
struct mlx5_rxq_ctrl *rxq_ctrl =
|
|
container_of(rxq_data, struct mlx5_rxq_ctrl, rxq);
|
|
struct mlx5_rxq_obj *rxq_obj = rxq_ctrl->obj;
|
|
unsigned int cqe_n = mlx5_rxq_cqe_num(rxq_data);
|
|
struct {
|
|
struct ibv_cq_init_attr_ex ibv;
|
|
struct mlx5dv_cq_init_attr mlx5;
|
|
} cq_attr;
|
|
|
|
cq_attr.ibv = (struct ibv_cq_init_attr_ex){
|
|
.cqe = cqe_n,
|
|
.channel = rxq_obj->ibv_channel,
|
|
.comp_mask = 0,
|
|
};
|
|
cq_attr.mlx5 = (struct mlx5dv_cq_init_attr){
|
|
.comp_mask = 0,
|
|
};
|
|
if (priv->config.cqe_comp && !rxq_data->hw_timestamp) {
|
|
cq_attr.mlx5.comp_mask |=
|
|
MLX5DV_CQ_INIT_ATTR_MASK_COMPRESSED_CQE;
|
|
#ifdef HAVE_IBV_DEVICE_STRIDING_RQ_SUPPORT
|
|
cq_attr.mlx5.cqe_comp_res_format =
|
|
mlx5_rxq_mprq_enabled(rxq_data) ?
|
|
MLX5DV_CQE_RES_FORMAT_CSUM_STRIDX :
|
|
MLX5DV_CQE_RES_FORMAT_HASH;
|
|
#else
|
|
cq_attr.mlx5.cqe_comp_res_format = MLX5DV_CQE_RES_FORMAT_HASH;
|
|
#endif
|
|
/*
|
|
* For vectorized Rx, it must not be doubled in order to
|
|
* make cq_ci and rq_ci aligned.
|
|
*/
|
|
if (mlx5_rxq_check_vec_support(rxq_data) < 0)
|
|
cq_attr.ibv.cqe *= 2;
|
|
} else if (priv->config.cqe_comp && rxq_data->hw_timestamp) {
|
|
DRV_LOG(DEBUG,
|
|
"Port %u Rx CQE compression is disabled for HW"
|
|
" timestamp.",
|
|
dev->data->port_id);
|
|
}
|
|
#ifdef HAVE_IBV_MLX5_MOD_CQE_128B_PAD
|
|
if (priv->config.cqe_pad) {
|
|
cq_attr.mlx5.comp_mask |= MLX5DV_CQ_INIT_ATTR_MASK_FLAGS;
|
|
cq_attr.mlx5.flags |= MLX5DV_CQ_INIT_ATTR_FLAGS_CQE_PAD;
|
|
}
|
|
#endif
|
|
return mlx5_glue->cq_ex_to_cq(mlx5_glue->dv_create_cq(priv->sh->ctx,
|
|
&cq_attr.ibv,
|
|
&cq_attr.mlx5));
|
|
}
|
|
|
|
/**
|
|
* Create a WQ Verbs object.
|
|
*
|
|
* @param dev
|
|
* Pointer to Ethernet device.
|
|
* @param idx
|
|
* Queue index in DPDK Rx queue array.
|
|
*
|
|
* @return
|
|
* The Verbs WQ object initialized, NULL otherwise and rte_errno is set.
|
|
*/
|
|
static struct ibv_wq *
|
|
mlx5_rxq_ibv_wq_create(struct rte_eth_dev *dev, uint16_t idx)
|
|
{
|
|
struct mlx5_priv *priv = dev->data->dev_private;
|
|
struct mlx5_rxq_data *rxq_data = (*priv->rxqs)[idx];
|
|
struct mlx5_rxq_ctrl *rxq_ctrl =
|
|
container_of(rxq_data, struct mlx5_rxq_ctrl, rxq);
|
|
struct mlx5_rxq_obj *rxq_obj = rxq_ctrl->obj;
|
|
unsigned int wqe_n = 1 << rxq_data->elts_n;
|
|
struct {
|
|
struct ibv_wq_init_attr ibv;
|
|
#ifdef HAVE_IBV_DEVICE_STRIDING_RQ_SUPPORT
|
|
struct mlx5dv_wq_init_attr mlx5;
|
|
#endif
|
|
} wq_attr;
|
|
|
|
wq_attr.ibv = (struct ibv_wq_init_attr){
|
|
.wq_context = NULL, /* Could be useful in the future. */
|
|
.wq_type = IBV_WQT_RQ,
|
|
/* Max number of outstanding WRs. */
|
|
.max_wr = wqe_n >> rxq_data->sges_n,
|
|
/* Max number of scatter/gather elements in a WR. */
|
|
.max_sge = 1 << rxq_data->sges_n,
|
|
.pd = priv->sh->pd,
|
|
.cq = rxq_obj->ibv_cq,
|
|
.comp_mask = IBV_WQ_FLAGS_CVLAN_STRIPPING | 0,
|
|
.create_flags = (rxq_data->vlan_strip ?
|
|
IBV_WQ_FLAGS_CVLAN_STRIPPING : 0),
|
|
};
|
|
/* By default, FCS (CRC) is stripped by hardware. */
|
|
if (rxq_data->crc_present) {
|
|
wq_attr.ibv.create_flags |= IBV_WQ_FLAGS_SCATTER_FCS;
|
|
wq_attr.ibv.comp_mask |= IBV_WQ_INIT_ATTR_FLAGS;
|
|
}
|
|
if (priv->config.hw_padding) {
|
|
#if defined(HAVE_IBV_WQ_FLAG_RX_END_PADDING)
|
|
wq_attr.ibv.create_flags |= IBV_WQ_FLAG_RX_END_PADDING;
|
|
wq_attr.ibv.comp_mask |= IBV_WQ_INIT_ATTR_FLAGS;
|
|
#elif defined(HAVE_IBV_WQ_FLAGS_PCI_WRITE_END_PADDING)
|
|
wq_attr.ibv.create_flags |= IBV_WQ_FLAGS_PCI_WRITE_END_PADDING;
|
|
wq_attr.ibv.comp_mask |= IBV_WQ_INIT_ATTR_FLAGS;
|
|
#endif
|
|
}
|
|
#ifdef HAVE_IBV_DEVICE_STRIDING_RQ_SUPPORT
|
|
wq_attr.mlx5 = (struct mlx5dv_wq_init_attr){
|
|
.comp_mask = 0,
|
|
};
|
|
if (mlx5_rxq_mprq_enabled(rxq_data)) {
|
|
struct mlx5dv_striding_rq_init_attr *mprq_attr =
|
|
&wq_attr.mlx5.striding_rq_attrs;
|
|
|
|
wq_attr.mlx5.comp_mask |= MLX5DV_WQ_INIT_ATTR_MASK_STRIDING_RQ;
|
|
*mprq_attr = (struct mlx5dv_striding_rq_init_attr){
|
|
.single_stride_log_num_of_bytes = rxq_data->strd_sz_n,
|
|
.single_wqe_log_num_of_strides = rxq_data->strd_num_n,
|
|
.two_byte_shift_en = MLX5_MPRQ_TWO_BYTE_SHIFT,
|
|
};
|
|
}
|
|
rxq_obj->wq = mlx5_glue->dv_create_wq(priv->sh->ctx, &wq_attr.ibv,
|
|
&wq_attr.mlx5);
|
|
#else
|
|
rxq_obj->wq = mlx5_glue->create_wq(priv->sh->ctx, &wq_attr.ibv);
|
|
#endif
|
|
if (rxq_obj->wq) {
|
|
/*
|
|
* Make sure number of WRs*SGEs match expectations since a queue
|
|
* cannot allocate more than "desc" buffers.
|
|
*/
|
|
if (wq_attr.ibv.max_wr != (wqe_n >> rxq_data->sges_n) ||
|
|
wq_attr.ibv.max_sge != (1u << rxq_data->sges_n)) {
|
|
DRV_LOG(ERR,
|
|
"Port %u Rx queue %u requested %u*%u but got"
|
|
" %u*%u WRs*SGEs.",
|
|
dev->data->port_id, idx,
|
|
wqe_n >> rxq_data->sges_n,
|
|
(1 << rxq_data->sges_n),
|
|
wq_attr.ibv.max_wr, wq_attr.ibv.max_sge);
|
|
claim_zero(mlx5_glue->destroy_wq(rxq_obj->wq));
|
|
rxq_obj->wq = NULL;
|
|
rte_errno = EINVAL;
|
|
}
|
|
}
|
|
return rxq_obj->wq;
|
|
}
|
|
|
|
/**
|
|
* Create the Rx queue Verbs object.
|
|
*
|
|
* @param dev
|
|
* Pointer to Ethernet device.
|
|
* @param idx
|
|
* Queue index in DPDK Rx queue array.
|
|
*
|
|
* @return
|
|
* 0 on success, a negative errno value otherwise and rte_errno is set.
|
|
*/
|
|
static int
|
|
mlx5_rxq_ibv_obj_new(struct rte_eth_dev *dev, uint16_t idx)
|
|
{
|
|
struct mlx5_priv *priv = dev->data->dev_private;
|
|
struct mlx5_rxq_data *rxq_data = (*priv->rxqs)[idx];
|
|
struct mlx5_rxq_ctrl *rxq_ctrl =
|
|
container_of(rxq_data, struct mlx5_rxq_ctrl, rxq);
|
|
struct ibv_wq_attr mod;
|
|
struct mlx5_rxq_obj *tmpl = rxq_ctrl->obj;
|
|
struct mlx5dv_cq cq_info;
|
|
struct mlx5dv_rwq rwq;
|
|
int ret = 0;
|
|
struct mlx5dv_obj obj;
|
|
|
|
MLX5_ASSERT(rxq_data);
|
|
MLX5_ASSERT(tmpl);
|
|
priv->verbs_alloc_ctx.type = MLX5_VERBS_ALLOC_TYPE_RX_QUEUE;
|
|
priv->verbs_alloc_ctx.obj = rxq_ctrl;
|
|
tmpl->type = MLX5_RXQ_OBJ_TYPE_IBV;
|
|
tmpl->rxq_ctrl = rxq_ctrl;
|
|
if (rxq_ctrl->irq) {
|
|
tmpl->ibv_channel =
|
|
mlx5_glue->create_comp_channel(priv->sh->ctx);
|
|
if (!tmpl->ibv_channel) {
|
|
DRV_LOG(ERR, "Port %u: comp channel creation failure.",
|
|
dev->data->port_id);
|
|
rte_errno = ENOMEM;
|
|
goto error;
|
|
}
|
|
tmpl->fd = ((struct ibv_comp_channel *)(tmpl->ibv_channel))->fd;
|
|
}
|
|
/* Create CQ using Verbs API. */
|
|
tmpl->ibv_cq = mlx5_rxq_ibv_cq_create(dev, idx);
|
|
if (!tmpl->ibv_cq) {
|
|
DRV_LOG(ERR, "Port %u Rx queue %u CQ creation failure.",
|
|
dev->data->port_id, idx);
|
|
rte_errno = ENOMEM;
|
|
goto error;
|
|
}
|
|
obj.cq.in = tmpl->ibv_cq;
|
|
obj.cq.out = &cq_info;
|
|
ret = mlx5_glue->dv_init_obj(&obj, MLX5DV_OBJ_CQ);
|
|
if (ret) {
|
|
rte_errno = ret;
|
|
goto error;
|
|
}
|
|
if (cq_info.cqe_size != RTE_CACHE_LINE_SIZE) {
|
|
DRV_LOG(ERR,
|
|
"Port %u wrong MLX5_CQE_SIZE environment "
|
|
"variable value: it should be set to %u.",
|
|
dev->data->port_id, RTE_CACHE_LINE_SIZE);
|
|
rte_errno = EINVAL;
|
|
goto error;
|
|
}
|
|
/* Fill the rings. */
|
|
rxq_data->cqe_n = log2above(cq_info.cqe_cnt);
|
|
rxq_data->cq_db = cq_info.dbrec;
|
|
rxq_data->cqes = (volatile struct mlx5_cqe (*)[])(uintptr_t)cq_info.buf;
|
|
rxq_data->cq_uar = cq_info.cq_uar;
|
|
rxq_data->cqn = cq_info.cqn;
|
|
/* Create WQ (RQ) using Verbs API. */
|
|
tmpl->wq = mlx5_rxq_ibv_wq_create(dev, idx);
|
|
if (!tmpl->wq) {
|
|
DRV_LOG(ERR, "Port %u Rx queue %u WQ creation failure.",
|
|
dev->data->port_id, idx);
|
|
rte_errno = ENOMEM;
|
|
goto error;
|
|
}
|
|
/* Change queue state to ready. */
|
|
mod = (struct ibv_wq_attr){
|
|
.attr_mask = IBV_WQ_ATTR_STATE,
|
|
.wq_state = IBV_WQS_RDY,
|
|
};
|
|
ret = mlx5_glue->modify_wq(tmpl->wq, &mod);
|
|
if (ret) {
|
|
DRV_LOG(ERR,
|
|
"Port %u Rx queue %u WQ state to IBV_WQS_RDY failed.",
|
|
dev->data->port_id, idx);
|
|
rte_errno = ret;
|
|
goto error;
|
|
}
|
|
obj.rwq.in = tmpl->wq;
|
|
obj.rwq.out = &rwq;
|
|
ret = mlx5_glue->dv_init_obj(&obj, MLX5DV_OBJ_RWQ);
|
|
if (ret) {
|
|
rte_errno = ret;
|
|
goto error;
|
|
}
|
|
rxq_data->wqes = rwq.buf;
|
|
rxq_data->rq_db = rwq.dbrec;
|
|
rxq_data->cq_arm_sn = 0;
|
|
mlx5_rxq_initialize(rxq_data);
|
|
rxq_data->cq_ci = 0;
|
|
priv->verbs_alloc_ctx.type = MLX5_VERBS_ALLOC_TYPE_NONE;
|
|
dev->data->rx_queue_state[idx] = RTE_ETH_QUEUE_STATE_STARTED;
|
|
rxq_ctrl->wqn = ((struct ibv_wq *)(tmpl->wq))->wq_num;
|
|
return 0;
|
|
error:
|
|
ret = rte_errno; /* Save rte_errno before cleanup. */
|
|
if (tmpl->wq)
|
|
claim_zero(mlx5_glue->destroy_wq(tmpl->wq));
|
|
if (tmpl->ibv_cq)
|
|
claim_zero(mlx5_glue->destroy_cq(tmpl->ibv_cq));
|
|
if (tmpl->ibv_channel)
|
|
claim_zero(mlx5_glue->destroy_comp_channel(tmpl->ibv_channel));
|
|
rte_errno = ret; /* Restore rte_errno. */
|
|
priv->verbs_alloc_ctx.type = MLX5_VERBS_ALLOC_TYPE_NONE;
|
|
return -rte_errno;
|
|
}
|
|
|
|
/**
|
|
* Release an Rx verbs queue object.
|
|
*
|
|
* @param rxq_obj
|
|
* Verbs Rx queue object.
|
|
*/
|
|
static void
|
|
mlx5_rxq_ibv_obj_release(struct mlx5_rxq_obj *rxq_obj)
|
|
{
|
|
MLX5_ASSERT(rxq_obj);
|
|
MLX5_ASSERT(rxq_obj->wq);
|
|
MLX5_ASSERT(rxq_obj->ibv_cq);
|
|
claim_zero(mlx5_glue->destroy_wq(rxq_obj->wq));
|
|
claim_zero(mlx5_glue->destroy_cq(rxq_obj->ibv_cq));
|
|
if (rxq_obj->ibv_channel)
|
|
claim_zero(mlx5_glue->destroy_comp_channel
|
|
(rxq_obj->ibv_channel));
|
|
}
|
|
|
|
/**
|
|
* Get event for an Rx verbs queue object.
|
|
*
|
|
* @param rxq_obj
|
|
* Verbs Rx queue object.
|
|
*
|
|
* @return
|
|
* 0 on success, a negative errno value otherwise and rte_errno is set.
|
|
*/
|
|
static int
|
|
mlx5_rx_ibv_get_event(struct mlx5_rxq_obj *rxq_obj)
|
|
{
|
|
struct ibv_cq *ev_cq;
|
|
void *ev_ctx;
|
|
int ret = mlx5_glue->get_cq_event(rxq_obj->ibv_channel,
|
|
&ev_cq, &ev_ctx);
|
|
|
|
if (ret < 0 || ev_cq != rxq_obj->ibv_cq)
|
|
goto exit;
|
|
mlx5_glue->ack_cq_events(rxq_obj->ibv_cq, 1);
|
|
return 0;
|
|
exit:
|
|
if (ret < 0)
|
|
rte_errno = errno;
|
|
else
|
|
rte_errno = EINVAL;
|
|
return -rte_errno;
|
|
}
|
|
|
|
struct mlx5_obj_ops ibv_obj_ops = {
|
|
.rxq_obj_modify_vlan_strip = mlx5_rxq_obj_modify_wq_vlan_strip,
|
|
.rxq_obj_new = mlx5_rxq_ibv_obj_new,
|
|
.rxq_event_get = mlx5_rx_ibv_get_event,
|
|
.rxq_obj_release = mlx5_rxq_ibv_obj_release,
|
|
};
|