680d5280c2
Since flow rule validation and creation have been refactored into a common two-pass function, having separate callback functions to validate and convert individual items seems redundant. The purpose of these item validation functions is to reject partial masks as those are not supported by hardware, before handing over the item to a separate function that performs basic sanity checks. The current approach and related code have the following issues: - Lack of flow handle context in validation code requires kludges such as the special treatment reserved to spec-less Ethernet pattern items. - Lack of useful error reporting; users need as much help as possible to understand what they did wrong, particularly when they hit hardware limitations that aren't mentioned by the flow API. Preventing them from going berserk after getting a generic "item not supported" message for no apparent reason is mandatory. - Generic checks should be performed by the caller, not by item-specific validation functions. - Mask checks either missing or too lax in some cases (Ethernet, VLAN). This commit addresses all the above by combining validation and conversion callbacks as "merge" callbacks that take an additional error context parameter. Also: - Support for source MAC address matching is removed as it has no effect. - Providing an empty mask no longer bypasses the Ethernet specification check that causes a rule to become promiscuous-like. - VLAN VIDs must be matched exactly, as matching all VLAN traffic while excluding non-VLAN traffic is not supported. Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
84 lines
3.2 KiB
C
84 lines
3.2 KiB
C
/*-
|
|
* BSD LICENSE
|
|
*
|
|
* Copyright 2017 6WIND S.A.
|
|
* Copyright 2017 Mellanox
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* * Neither the name of 6WIND S.A. nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef RTE_PMD_MLX4_FLOW_H_
|
|
#define RTE_PMD_MLX4_FLOW_H_
|
|
|
|
#include <stdint.h>
|
|
#include <sys/queue.h>
|
|
|
|
/* Verbs headers do not support -pedantic. */
|
|
#ifdef PEDANTIC
|
|
#pragma GCC diagnostic ignored "-Wpedantic"
|
|
#endif
|
|
#include <infiniband/verbs.h>
|
|
#ifdef PEDANTIC
|
|
#pragma GCC diagnostic error "-Wpedantic"
|
|
#endif
|
|
|
|
#include <rte_eth_ctrl.h>
|
|
#include <rte_ethdev.h>
|
|
#include <rte_flow.h>
|
|
#include <rte_flow_driver.h>
|
|
#include <rte_byteorder.h>
|
|
|
|
/** Last and lowest priority level for a flow rule. */
|
|
#define MLX4_FLOW_PRIORITY_LAST UINT32_C(0xfff)
|
|
|
|
/** Meta pattern item used to distinguish internal rules. */
|
|
#define MLX4_FLOW_ITEM_TYPE_INTERNAL ((enum rte_flow_item_type)-1)
|
|
|
|
/** PMD-specific (mlx4) definition of a flow rule handle. */
|
|
struct rte_flow {
|
|
LIST_ENTRY(rte_flow) next; /**< Pointer to the next flow structure. */
|
|
struct ibv_flow *ibv_flow; /**< Verbs flow. */
|
|
struct ibv_flow_attr *ibv_attr; /**< Pointer to Verbs attributes. */
|
|
uint32_t ibv_attr_size; /**< Size of Verbs attributes. */
|
|
uint32_t internal:1; /**< Internal flow rule outside isolated mode. */
|
|
uint32_t promisc:1; /**< This rule matches everything. */
|
|
uint32_t drop:1; /**< This rule drops packets. */
|
|
uint32_t queue:1; /**< Target is a receive queue. */
|
|
uint16_t queue_id; /**< Target queue. */
|
|
};
|
|
|
|
/* mlx4_flow.c */
|
|
|
|
int mlx4_flow_sync(struct priv *priv, struct rte_flow_error *error);
|
|
void mlx4_flow_clean(struct priv *priv);
|
|
int mlx4_filter_ctrl(struct rte_eth_dev *dev,
|
|
enum rte_filter_type filter_type,
|
|
enum rte_filter_op filter_op,
|
|
void *arg);
|
|
|
|
#endif /* RTE_PMD_MLX4_FLOW_H_ */
|