272f94e58b
In some environments, the check of local symbols catch-all
was failing. Note: this script is called during the build.
The reason is that grep returns an error if nothing is found.
The option -e of the shell script makes this error fatal.
It is not always fatal because the grep is in a command substitution.
Fixes: b403498e14 ("build: hide local symbols in shared libraries")
Reported-by: Usama Arif <usama.arif@bytedance.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
64 lines
1.4 KiB
Bash
Executable File
64 lines
1.4 KiB
Bash
Executable File
#! /bin/sh -e
|
|
# SPDX-License-Identifier: BSD-3-Clause
|
|
# Copyright 2018 Mellanox Technologies, Ltd
|
|
|
|
cd $(dirname $0)/..
|
|
|
|
# speed up by ignoring Unicode details
|
|
export LC_ALL=C
|
|
|
|
if [ $# = 0 ] ; then
|
|
set -- $(find lib drivers -name '*.map')
|
|
fi
|
|
|
|
ret=0
|
|
|
|
find_orphan_symbols ()
|
|
{
|
|
for map in $@ ; do
|
|
for sym in $(sed -rn 's,^([^}]*_.*);.*$,\1,p' $map) ; do
|
|
if echo $sym | grep -q '^per_lcore_' ; then
|
|
symsrc=${sym#per_lcore_}
|
|
elif echo $sym | grep -q '^__rte_.*_trace_' ; then
|
|
symsrc=${sym#__}
|
|
else
|
|
symsrc=$sym
|
|
fi
|
|
if [ -z "$(grep -rlw $symsrc $(dirname $map) | grep -v $map)" ] ; then
|
|
echo "$map: $sym"
|
|
fi
|
|
done
|
|
done
|
|
}
|
|
|
|
orphan_symbols=$(find_orphan_symbols $@)
|
|
if [ -n "$orphan_symbols" ] ; then
|
|
echo "Found only in symbol map file:"
|
|
echo "$orphan_symbols" | sed 's,^,\t,'
|
|
ret=1
|
|
fi
|
|
|
|
find_duplicate_symbols ()
|
|
{
|
|
for map in $@ ; do
|
|
buildtools/map-list-symbol.sh $map | \
|
|
sort | uniq -c | grep -v " 1 $map" || true
|
|
done
|
|
}
|
|
|
|
duplicate_symbols=$(find_duplicate_symbols $@)
|
|
if [ -n "$duplicate_symbols" ] ; then
|
|
echo "Found duplicates in symbol map file:"
|
|
echo "$duplicate_symbols"
|
|
ret=1
|
|
fi
|
|
|
|
local_miss_maps=$(grep -L 'local: \*;' $@ || true)
|
|
if [ -n "$local_miss_maps" ] ; then
|
|
echo "Found maps without local catch-all:"
|
|
echo "$local_miss_maps"
|
|
ret=1
|
|
fi
|
|
|
|
exit $ret
|