1f16fa99aa
The issue is that a file descriptor at 0 is a valid one. Currently the file not found, the return value will be set to 0. As a result, it is impossible to distinguish between a correct descriptor and a failed return value. Fix it to return -ENOENT instead of 0. Fixes:b758423bc4("vfio: fix race condition with sysfs") Fixes:ff0b67d1c8("vfio: DMA mapping") Cc: stable@dpdk.org Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
124 lines
2.5 KiB
C
124 lines
2.5 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause
|
|
* Copyright(c) 2010-2018 Intel Corporation
|
|
*/
|
|
|
|
#include <unistd.h>
|
|
#include <string.h>
|
|
|
|
#include <rte_compat.h>
|
|
#include <rte_errno.h>
|
|
#include <rte_log.h>
|
|
#include <rte_vfio.h>
|
|
#include <rte_eal.h>
|
|
|
|
#include "eal_vfio.h"
|
|
|
|
/**
|
|
* @file
|
|
* VFIO socket for communication between primary and secondary processes.
|
|
*
|
|
* This file is only compiled if CONFIG_RTE_EAL_VFIO is set to "y".
|
|
*/
|
|
|
|
#ifdef VFIO_PRESENT
|
|
|
|
static int
|
|
vfio_mp_primary(const struct rte_mp_msg *msg, const void *peer)
|
|
{
|
|
int fd = -1;
|
|
int ret;
|
|
struct rte_mp_msg reply;
|
|
struct vfio_mp_param *r = (struct vfio_mp_param *)reply.param;
|
|
const struct vfio_mp_param *m =
|
|
(const struct vfio_mp_param *)msg->param;
|
|
|
|
if (msg->len_param != sizeof(*m)) {
|
|
RTE_LOG(ERR, EAL, "vfio received invalid message!\n");
|
|
return -1;
|
|
}
|
|
|
|
memset(&reply, 0, sizeof(reply));
|
|
|
|
switch (m->req) {
|
|
case SOCKET_REQ_GROUP:
|
|
r->req = SOCKET_REQ_GROUP;
|
|
r->group_num = m->group_num;
|
|
fd = rte_vfio_get_group_fd(m->group_num);
|
|
if (fd < 0 && fd != -ENOENT)
|
|
r->result = SOCKET_ERR;
|
|
else if (fd == -ENOENT)
|
|
/* if VFIO group exists but isn't bound to VFIO driver */
|
|
r->result = SOCKET_NO_FD;
|
|
else {
|
|
/* if group exists and is bound to VFIO driver */
|
|
r->result = SOCKET_OK;
|
|
reply.num_fds = 1;
|
|
reply.fds[0] = fd;
|
|
}
|
|
break;
|
|
case SOCKET_REQ_CONTAINER:
|
|
r->req = SOCKET_REQ_CONTAINER;
|
|
fd = rte_vfio_get_container_fd();
|
|
if (fd < 0)
|
|
r->result = SOCKET_ERR;
|
|
else {
|
|
r->result = SOCKET_OK;
|
|
reply.num_fds = 1;
|
|
reply.fds[0] = fd;
|
|
}
|
|
break;
|
|
case SOCKET_REQ_DEFAULT_CONTAINER:
|
|
r->req = SOCKET_REQ_DEFAULT_CONTAINER;
|
|
fd = vfio_get_default_container_fd();
|
|
if (fd < 0)
|
|
r->result = SOCKET_ERR;
|
|
else {
|
|
r->result = SOCKET_OK;
|
|
reply.num_fds = 1;
|
|
reply.fds[0] = fd;
|
|
}
|
|
break;
|
|
case SOCKET_REQ_IOMMU_TYPE:
|
|
{
|
|
int iommu_type_id;
|
|
|
|
r->req = SOCKET_REQ_IOMMU_TYPE;
|
|
|
|
iommu_type_id = vfio_get_iommu_type();
|
|
|
|
if (iommu_type_id < 0)
|
|
r->result = SOCKET_ERR;
|
|
else {
|
|
r->iommu_type_id = iommu_type_id;
|
|
r->result = SOCKET_OK;
|
|
}
|
|
break;
|
|
}
|
|
default:
|
|
RTE_LOG(ERR, EAL, "vfio received invalid message!\n");
|
|
return -1;
|
|
}
|
|
|
|
strcpy(reply.name, EAL_VFIO_MP);
|
|
reply.len_param = sizeof(*r);
|
|
|
|
ret = rte_mp_reply(&reply, peer);
|
|
if (m->req == SOCKET_REQ_CONTAINER && fd >= 0)
|
|
close(fd);
|
|
return ret;
|
|
}
|
|
|
|
int
|
|
vfio_mp_sync_setup(void)
|
|
{
|
|
if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
|
|
int ret = rte_mp_action_register(EAL_VFIO_MP, vfio_mp_primary);
|
|
if (ret && rte_errno != ENOTSUP)
|
|
return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
#endif
|