numam-dpdk/lib/librte_mempool
Adrien Mazarguil 0d440d081c lib: fix missing includes in exported headers
Many exported headers rely on definitions found in rte_config.h without
including it, as shown by the following command:

 grep -L '^#include <rte_config.h>' -- \
  $(grep -Rl \
    $(sed -n '/^#define \([^ ]\+\).*$/{s//\1/;H;};${x;s/\n//;s/\n/\\|/g;p;}' \
      build/include/rte_config.h) \
    -- build/include/)

We cannot assume external applications will include rte_config.h on their
own, neither directly nor through a -include parameter like DPDK does
internally.

This not only causes obvious compilation failures that can be reproduced
with check-includes.sh such as:

 [...]/rte_memory.h:88:43: error: ‘RTE_CACHE_LINE_SIZE’ was not declared in
     this scope
  #define __rte_cache_aligned __rte_aligned(RTE_CACHE_LINE_SIZE)
                                            ^

It also results in less visible issues, for instance rte_hash_crc.h relying
on RTE_ARCH_X86_64's presence to provide dedicated inline functions.

This patch partially reverts the commit below and adds missing include
lines to the remaining files.

Fixes: f1a7a5c5f4 ("remove include of generated config header")
Cc: stable@dpdk.org

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
2018-01-17 00:31:05 +01:00
..
Makefile lib: use SPDX tag for Intel copyright files 2018-01-04 22:41:39 +01:00
rte_mempool_ops.c mempool: rename addresses from physical to IOVA 2017-11-06 22:25:55 +01:00
rte_mempool_version.map mempool: rename populate functions to IOVA 2017-11-06 22:26:34 +01:00
rte_mempool.c mempool: fix first memory area notification 2018-01-12 18:30:20 +01:00
rte_mempool.h lib: fix missing includes in exported headers 2018-01-17 00:31:05 +01:00