51fcb6a1fe
struct cmdline exposes platform-specific members it contains, most notably struct termios that is only available on Unix. While ABI considerations prevent from hinding the definition on already supported platforms, struct cmdline is considered logically opaque from now on. Add a deprecation notice targeted at 20.11. * Remove tests checking struct cmdline content as meaningless. * Fix missing cmdline_free() in unit test. * Add cmdline_get_rdline() to access history buffer indirectly. The new function is currently used only in tests. Suggested-by: Olivier Matz <olivier.matz@6wind.com> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> Acked-by: Ray Kinsella <mdr@ashroe.eu> Acked-by: Olivier Matz <olivier.matz@6wind.com>
229 lines
4.9 KiB
C
229 lines
4.9 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause
|
|
* Copyright(c) 2010-2014 Intel Corporation
|
|
*/
|
|
|
|
#include <string.h>
|
|
#include <stdio.h>
|
|
#include <stdint.h>
|
|
#include <stdarg.h>
|
|
#include <stdlib.h>
|
|
#include <errno.h>
|
|
#include <termios.h>
|
|
#include <ctype.h>
|
|
#include <sys/queue.h>
|
|
|
|
#include <rte_common.h>
|
|
|
|
#include <cmdline_vt100.h>
|
|
#include <cmdline_rdline.h>
|
|
#include <cmdline_parse.h>
|
|
#include <cmdline_socket.h>
|
|
#include <cmdline.h>
|
|
|
|
#include "test_cmdline.h"
|
|
|
|
/****************************************************************/
|
|
/* static functions required for some tests */
|
|
static void
|
|
valid_buffer(__rte_unused struct rdline *rdl,
|
|
__rte_unused const char *buf,
|
|
__rte_unused unsigned int size)
|
|
{
|
|
}
|
|
|
|
static int
|
|
complete_buffer(__rte_unused struct rdline *rdl,
|
|
__rte_unused const char *buf,
|
|
__rte_unused char *dstbuf,
|
|
__rte_unused unsigned int dstsize,
|
|
__rte_unused int *state)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
/****************************************************************/
|
|
|
|
static int
|
|
test_cmdline_parse_fns(void)
|
|
{
|
|
struct cmdline *cl;
|
|
cmdline_parse_ctx_t ctx;
|
|
int i = 0;
|
|
char dst[CMDLINE_TEST_BUFSIZE];
|
|
|
|
cl = cmdline_new(&ctx, "prompt", -1, -1);
|
|
if (cl == NULL) {
|
|
printf("Error: cannot create cmdline to test parse fns!\n");
|
|
return -1;
|
|
}
|
|
|
|
if (cmdline_parse(NULL, "buffer") >= 0)
|
|
goto error;
|
|
if (cmdline_parse(cl, NULL) >= 0)
|
|
goto error;
|
|
|
|
if (cmdline_complete(NULL, "buffer", &i, dst, sizeof(dst)) >= 0)
|
|
goto error;
|
|
if (cmdline_complete(cl, NULL, &i, dst, sizeof(dst)) >= 0)
|
|
goto error;
|
|
if (cmdline_complete(cl, "buffer", NULL, dst, sizeof(dst)) >= 0)
|
|
goto error;
|
|
if (cmdline_complete(cl, "buffer", &i, NULL, sizeof(dst)) >= 0)
|
|
goto error;
|
|
|
|
return 0;
|
|
|
|
error:
|
|
printf("Error: function accepted null parameter!\n");
|
|
return -1;
|
|
}
|
|
|
|
static int
|
|
test_cmdline_rdline_fns(void)
|
|
{
|
|
struct rdline rdl;
|
|
rdline_write_char_t *wc = &cmdline_write_char;
|
|
rdline_validate_t *v = &valid_buffer;
|
|
rdline_complete_t *c = &complete_buffer;
|
|
|
|
if (rdline_init(NULL, wc, v, c) >= 0)
|
|
goto error;
|
|
if (rdline_init(&rdl, NULL, v, c) >= 0)
|
|
goto error;
|
|
if (rdline_init(&rdl, wc, NULL, c) >= 0)
|
|
goto error;
|
|
if (rdline_init(&rdl, wc, v, NULL) >= 0)
|
|
goto error;
|
|
if (rdline_char_in(NULL, 0) >= 0)
|
|
goto error;
|
|
if (rdline_get_buffer(NULL) != NULL)
|
|
goto error;
|
|
if (rdline_add_history(NULL, "history") >= 0)
|
|
goto error;
|
|
if (rdline_add_history(&rdl, NULL) >= 0)
|
|
goto error;
|
|
if (rdline_get_history_item(NULL, 0) != NULL)
|
|
goto error;
|
|
|
|
/* void functions */
|
|
rdline_newline(NULL, "prompt");
|
|
rdline_newline(&rdl, NULL);
|
|
rdline_stop(NULL);
|
|
rdline_quit(NULL);
|
|
rdline_restart(NULL);
|
|
rdline_redisplay(NULL);
|
|
rdline_reset(NULL);
|
|
rdline_clear_history(NULL);
|
|
|
|
return 0;
|
|
|
|
error:
|
|
printf("Error: function accepted null parameter!\n");
|
|
return -1;
|
|
}
|
|
|
|
static int
|
|
test_cmdline_vt100_fns(void)
|
|
{
|
|
if (vt100_parser(NULL, 0) >= 0) {
|
|
printf("Error: function accepted null parameter!\n");
|
|
return -1;
|
|
}
|
|
|
|
/* void functions */
|
|
vt100_init(NULL);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
test_cmdline_socket_fns(void)
|
|
{
|
|
cmdline_parse_ctx_t ctx;
|
|
|
|
if (cmdline_stdin_new(NULL, "prompt") != NULL)
|
|
goto error;
|
|
if (cmdline_stdin_new(&ctx, NULL) != NULL)
|
|
goto error;
|
|
if (cmdline_file_new(NULL, "prompt", "/dev/null") != NULL)
|
|
goto error;
|
|
if (cmdline_file_new(&ctx, NULL, "/dev/null") != NULL)
|
|
goto error;
|
|
if (cmdline_file_new(&ctx, "prompt", NULL) != NULL)
|
|
goto error;
|
|
if (cmdline_file_new(&ctx, "prompt", "-/invalid/~/path") != NULL) {
|
|
printf("Error: succeeded in opening invalid file for reading!");
|
|
return -1;
|
|
}
|
|
if (cmdline_file_new(&ctx, "prompt", "/dev/null") == NULL) {
|
|
printf("Error: failed to open /dev/null for reading!");
|
|
return -1;
|
|
}
|
|
|
|
/* void functions */
|
|
cmdline_stdin_exit(NULL);
|
|
|
|
return 0;
|
|
error:
|
|
printf("Error: function accepted null parameter!\n");
|
|
return -1;
|
|
}
|
|
|
|
static int
|
|
test_cmdline_fns(void)
|
|
{
|
|
cmdline_parse_ctx_t ctx;
|
|
struct cmdline *cl;
|
|
|
|
memset(&ctx, 0, sizeof(ctx));
|
|
cl = cmdline_new(&ctx, "test", -1, -1);
|
|
if (cl == NULL)
|
|
goto error;
|
|
|
|
if (cmdline_new(NULL, "prompt", 0, 0) != NULL)
|
|
goto error;
|
|
if (cmdline_new(&ctx, NULL, 0, 0) != NULL)
|
|
goto error;
|
|
if (cmdline_in(NULL, "buffer", CMDLINE_TEST_BUFSIZE) >= 0)
|
|
goto error;
|
|
if (cmdline_in(cl, NULL, CMDLINE_TEST_BUFSIZE) >= 0)
|
|
goto error;
|
|
if (cmdline_write_char(NULL, 0) >= 0)
|
|
goto error;
|
|
|
|
/* void functions */
|
|
cmdline_set_prompt(NULL, "prompt");
|
|
cmdline_free(NULL);
|
|
cmdline_printf(NULL, "format");
|
|
cmdline_interact(NULL);
|
|
cmdline_quit(NULL);
|
|
|
|
return 0;
|
|
|
|
error:
|
|
printf("Error: function accepted null parameter!\n");
|
|
if (cl != NULL)
|
|
cmdline_free(cl);
|
|
return -1;
|
|
}
|
|
|
|
/* test library functions. the point of these tests is not so much to test
|
|
* functions' behaviour as it is to make sure there are no segfaults if
|
|
* they are called with invalid parameters.
|
|
*/
|
|
int
|
|
test_cmdline_lib(void)
|
|
{
|
|
if (test_cmdline_parse_fns() < 0)
|
|
return -1;
|
|
if (test_cmdline_rdline_fns() < 0)
|
|
return -1;
|
|
if (test_cmdline_vt100_fns() < 0)
|
|
return -1;
|
|
if (test_cmdline_socket_fns() < 0)
|
|
return -1;
|
|
if (test_cmdline_fns() < 0)
|
|
return -1;
|
|
return 0;
|
|
}
|