d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
bb53d84843
numam-dpdk/drivers/net/mlx5/mlx5_socket.c
Ophir Munk 09e0fd260e net/mlx5: fix secondary process resource leakage 
When running testpmd with an mlx5 device and then executing at testpmd
prompt in a raw: "port start all" followed by "port stop all"
a new file named /var/tmp/net_mlx5_<socket num> is created as a result
of creating a new unix domain socket (used for communication between
the primary and secondary processes).
When the new unix socket file is created the old unix socket file should
have been removed. This commit fixes it by closing the old unix socket
just before creating the new one in function mlx5_socket_init()

Fixes: f8b9a3bad4 ("net/mlx5: install a socket to exchange a file descriptor")
Cc: stable@dpdk.org

Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
2018-08-02 13:15:27 +02:00

309 lines
7.3 KiB
C
Raw Blame History

/* SPDX-License-Identifier: BSD-3-Clause
* Copyright 2016 6WIND S.A.
* Copyright 2016 Mellanox Technologies, Ltd
*/
#define _GNU_SOURCE
#include <sys/types.h>
#include <sys/socket.h>
#include <sys/un.h>
#include <fcntl.h>
#include <stdio.h>
#include <unistd.h>
#include <sys/stat.h>
#include "mlx5.h"
#include "mlx5_utils.h"
/**
* Initialise the socket to communicate with the secondary process
*
* @param[in] dev
* Pointer to Ethernet device.
*
* @return
* 0 on success, a negative errno value otherwise and rte_errno is set.
*/
int
mlx5_socket_init(struct rte_eth_dev *dev)
{
struct priv *priv = dev->data->dev_private;
struct sockaddr_un sun = {
.sun_family = AF_UNIX,
};
int ret;
int flags;
/*
* Close the last socket that was used to communicate
* with the secondary process
*/
if (priv->primary_socket)
mlx5_socket_uninit(dev);
/*
* Initialise the socket to communicate with the secondary
* process.
*/
ret = socket(AF_UNIX, SOCK_STREAM, 0);
if (ret < 0) {
rte_errno = errno;
DRV_LOG(WARNING, "port %u secondary process not supported: %s",
dev->data->port_id, strerror(errno));
goto error;
}
priv->primary_socket = ret;
flags = fcntl(priv->primary_socket, F_GETFL, 0);
if (flags == -1) {
rte_errno = errno;
goto error;
}
ret = fcntl(priv->primary_socket, F_SETFL, flags | O_NONBLOCK);
if (ret < 0) {
rte_errno = errno;
goto error;
}
snprintf(sun.sun_path, sizeof(sun.sun_path), "/var/tmp/%s_%d",
MLX5_DRIVER_NAME, priv->primary_socket);
remove(sun.sun_path);
ret = bind(priv->primary_socket, (const struct sockaddr *)&sun,
sizeof(sun));
if (ret < 0) {
rte_errno = errno;
DRV_LOG(WARNING,
"port %u cannot bind socket, secondary process not"
" supported: %s",
dev->data->port_id, strerror(errno));
goto close;
}
ret = listen(priv->primary_socket, 0);
if (ret < 0) {
rte_errno = errno;
DRV_LOG(WARNING, "port %u secondary process not supported: %s",
dev->data->port_id, strerror(errno));
goto close;
}
return 0;
close:
remove(sun.sun_path);
error:
claim_zero(close(priv->primary_socket));
priv->primary_socket = 0;
return -rte_errno;
}
/**
* Un-Initialise the socket to communicate with the secondary process
*
* @param[in] dev
*/
void
mlx5_socket_uninit(struct rte_eth_dev *dev)
{
struct priv *priv = dev->data->dev_private;
MKSTR(path, "/var/tmp/%s_%d", MLX5_DRIVER_NAME, priv->primary_socket);
claim_zero(close(priv->primary_socket));
priv->primary_socket = 0;
claim_zero(remove(path));
}
/**
* Handle socket interrupts.
*
* @param dev
* Pointer to Ethernet device.
*/
void
mlx5_socket_handle(struct rte_eth_dev *dev)
{
struct priv *priv = dev->data->dev_private;
int conn_sock;
int ret = 0;
struct cmsghdr *cmsg = NULL;
struct ucred *cred = NULL;
char buf[CMSG_SPACE(sizeof(struct ucred))] = { 0 };
char vbuf[1024] = { 0 };
struct iovec io = {
.iov_base = vbuf,
.iov_len = sizeof(*vbuf),
};
struct msghdr msg = {
.msg_iov = &io,
.msg_iovlen = 1,
.msg_control = buf,
.msg_controllen = sizeof(buf),
};
int *fd;
/* Accept the connection from the client. */
conn_sock = accept(priv->primary_socket, NULL, NULL);
if (conn_sock < 0) {
DRV_LOG(WARNING, "port %u connection failed: %s",
dev->data->port_id, strerror(errno));
return;
}
ret = setsockopt(conn_sock, SOL_SOCKET, SO_PASSCRED, &(int){1},
sizeof(int));
if (ret < 0) {
ret = errno;
DRV_LOG(WARNING, "port %u cannot change socket options: %s",
dev->data->port_id, strerror(rte_errno));
goto error;
}
ret = recvmsg(conn_sock, &msg, MSG_WAITALL);
if (ret < 0) {
ret = errno;
DRV_LOG(WARNING, "port %u received an empty message: %s",
dev->data->port_id, strerror(rte_errno));
goto error;
}
/* Expect to receive credentials only. */
cmsg = CMSG_FIRSTHDR(&msg);
if (cmsg == NULL) {
DRV_LOG(WARNING, "port %u no message", dev->data->port_id);
goto error;
}
if ((cmsg->cmsg_type == SCM_CREDENTIALS) &&
(cmsg->cmsg_len >= sizeof(*cred))) {
cred = (struct ucred *)CMSG_DATA(cmsg);
assert(cred != NULL);
}
cmsg = CMSG_NXTHDR(&msg, cmsg);
if (cmsg != NULL) {
DRV_LOG(WARNING, "port %u message wrongly formatted",
dev->data->port_id);
goto error;
}
/* Make sure all the ancillary data was received and valid. */
if ((cred == NULL) || (cred->uid != getuid()) ||
(cred->gid != getgid())) {
DRV_LOG(WARNING, "port %u wrong credentials",
dev->data->port_id);
goto error;
}
/* Set-up the ancillary data. */
cmsg = CMSG_FIRSTHDR(&msg);
assert(cmsg != NULL);
cmsg->cmsg_level = SOL_SOCKET;
cmsg->cmsg_type = SCM_RIGHTS;
cmsg->cmsg_len = CMSG_LEN(sizeof(priv->ctx->cmd_fd));
fd = (int *)CMSG_DATA(cmsg);
*fd = priv->ctx->cmd_fd;
ret = sendmsg(conn_sock, &msg, 0);
if (ret < 0)
DRV_LOG(WARNING, "port %u cannot send response",
dev->data->port_id);
error:
close(conn_sock);
}
/**
* Connect to the primary process.
*
* @param[in] dev
* Pointer to Ethernet structure.
*
* @return
* fd on success, negative errno value otherwise and rte_errno is set.
*/
int
mlx5_socket_connect(struct rte_eth_dev *dev)
{
struct priv *priv = dev->data->dev_private;
struct sockaddr_un sun = {
.sun_family = AF_UNIX,
};
int socket_fd = -1;
int *fd = NULL;
int ret;
struct ucred *cred;
char buf[CMSG_SPACE(sizeof(*cred))] = { 0 };
char vbuf[1024] = { 0 };
struct iovec io = {
.iov_base = vbuf,
.iov_len = sizeof(*vbuf),
};
struct msghdr msg = {
.msg_control = buf,
.msg_controllen = sizeof(buf),
.msg_iov = &io,
.msg_iovlen = 1,
};
struct cmsghdr *cmsg;
ret = socket(AF_UNIX, SOCK_STREAM, 0);
if (ret < 0) {
rte_errno = errno;
DRV_LOG(WARNING, "port %u cannot connect to primary",
dev->data->port_id);
goto error;
}
socket_fd = ret;
snprintf(sun.sun_path, sizeof(sun.sun_path), "/var/tmp/%s_%d",
MLX5_DRIVER_NAME, priv->primary_socket);
ret = connect(socket_fd, (const struct sockaddr *)&sun, sizeof(sun));
if (ret < 0) {
rte_errno = errno;
DRV_LOG(WARNING, "port %u cannot connect to primary",
dev->data->port_id);
goto error;
}
cmsg = CMSG_FIRSTHDR(&msg);
if (cmsg == NULL) {
rte_errno = EINVAL;
DRV_LOG(DEBUG, "port %u cannot get first message",
dev->data->port_id);
goto error;
}
cmsg->cmsg_level = SOL_SOCKET;
cmsg->cmsg_type = SCM_CREDENTIALS;
cmsg->cmsg_len = CMSG_LEN(sizeof(*cred));
cred = (struct ucred *)CMSG_DATA(cmsg);
if (cred == NULL) {
rte_errno = EINVAL;
DRV_LOG(DEBUG, "port %u no credentials received",
dev->data->port_id);
goto error;
}
cred->pid = getpid();
cred->uid = getuid();
cred->gid = getgid();
ret = sendmsg(socket_fd, &msg, MSG_DONTWAIT);
if (ret < 0) {
rte_errno = errno;
DRV_LOG(WARNING,
"port %u cannot send credentials to primary: %s",
dev->data->port_id, strerror(errno));
goto error;
}
ret = recvmsg(socket_fd, &msg, MSG_WAITALL);
if (ret <= 0) {
rte_errno = errno;
DRV_LOG(WARNING, "port %u no message from primary: %s",
dev->data->port_id, strerror(errno));
goto error;
}
cmsg = CMSG_FIRSTHDR(&msg);
if (cmsg == NULL) {
rte_errno = EINVAL;
DRV_LOG(WARNING, "port %u no file descriptor received",
dev->data->port_id);
goto error;
}
fd = (int *)CMSG_DATA(cmsg);
if (*fd < 0) {
DRV_LOG(WARNING, "port %u no file descriptor received: %s",
dev->data->port_id, strerror(errno));
rte_errno = *fd;
goto error;
}
ret = *fd;
close(socket_fd);
return ret;
error:
if (socket_fd != -1)
close(socket_fd);
return -rte_errno;
}
Reference in New Issue View Git Blame Copy Permalink