a6e7cd81fa
When setting the CONFIG_RTE_BUILD_SHARED_LIB to y, and build the mlx5 pmd, there is a building error. To fix it, add RTE_IBVERBS_LINK_DLOPEN to include relative codes. mlx5_common.o: In function `mlx5_glue_init': drivers/common/mlx5/mlx5_common.c:324: undefined reference to `dlclose' Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library") Cc: stable@dpdk.org Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com> Tested-by: Ali Alnubani <alialnu@mellanox.com> Acked-by: Matan Azrad <matan@mellanox.com>
335 lines
8.2 KiB
C
335 lines
8.2 KiB
C
/* SPDX-License-Identifier: BSD-3-Clause
|
|
* Copyright 2019 Mellanox Technologies, Ltd
|
|
*/
|
|
|
|
#include <unistd.h>
|
|
#include <string.h>
|
|
#include <stdio.h>
|
|
#ifdef RTE_IBVERBS_LINK_DLOPEN
|
|
#include <dlfcn.h>
|
|
#endif
|
|
|
|
#include <rte_errno.h>
|
|
|
|
#include "mlx5_common.h"
|
|
#include "mlx5_common_utils.h"
|
|
#include "mlx5_glue.h"
|
|
|
|
|
|
int mlx5_common_logtype;
|
|
|
|
|
|
/**
|
|
* Get PCI information by sysfs device path.
|
|
*
|
|
* @param dev_path
|
|
* Pointer to device sysfs folder name.
|
|
* @param[out] pci_addr
|
|
* PCI bus address output buffer.
|
|
*
|
|
* @return
|
|
* 0 on success, a negative errno value otherwise and rte_errno is set.
|
|
*/
|
|
int
|
|
mlx5_dev_to_pci_addr(const char *dev_path,
|
|
struct rte_pci_addr *pci_addr)
|
|
{
|
|
FILE *file;
|
|
char line[32];
|
|
MKSTR(path, "%s/device/uevent", dev_path);
|
|
|
|
file = fopen(path, "rb");
|
|
if (file == NULL) {
|
|
rte_errno = errno;
|
|
return -rte_errno;
|
|
}
|
|
while (fgets(line, sizeof(line), file) == line) {
|
|
size_t len = strlen(line);
|
|
int ret;
|
|
|
|
/* Truncate long lines. */
|
|
if (len == (sizeof(line) - 1))
|
|
while (line[(len - 1)] != '\n') {
|
|
ret = fgetc(file);
|
|
if (ret == EOF)
|
|
break;
|
|
line[(len - 1)] = ret;
|
|
}
|
|
/* Extract information. */
|
|
if (sscanf(line,
|
|
"PCI_SLOT_NAME="
|
|
"%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 "\n",
|
|
&pci_addr->domain,
|
|
&pci_addr->bus,
|
|
&pci_addr->devid,
|
|
&pci_addr->function) == 4) {
|
|
ret = 0;
|
|
break;
|
|
}
|
|
}
|
|
fclose(file);
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
mlx5_class_check_handler(__rte_unused const char *key, const char *value,
|
|
void *opaque)
|
|
{
|
|
enum mlx5_class *ret = opaque;
|
|
|
|
if (strcmp(value, "vdpa") == 0) {
|
|
*ret = MLX5_CLASS_VDPA;
|
|
} else if (strcmp(value, "net") == 0) {
|
|
*ret = MLX5_CLASS_NET;
|
|
} else {
|
|
DRV_LOG(ERR, "Invalid mlx5 class %s. Maybe typo in device"
|
|
" class argument setting?", value);
|
|
*ret = MLX5_CLASS_INVALID;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
enum mlx5_class
|
|
mlx5_class_get(struct rte_devargs *devargs)
|
|
{
|
|
struct rte_kvargs *kvlist;
|
|
const char *key = MLX5_CLASS_ARG_NAME;
|
|
enum mlx5_class ret = MLX5_CLASS_NET;
|
|
|
|
if (devargs == NULL)
|
|
return ret;
|
|
kvlist = rte_kvargs_parse(devargs->args, NULL);
|
|
if (kvlist == NULL)
|
|
return ret;
|
|
if (rte_kvargs_count(kvlist, key))
|
|
rte_kvargs_process(kvlist, key, mlx5_class_check_handler, &ret);
|
|
rte_kvargs_free(kvlist);
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* Extract port name, as a number, from sysfs or netlink information.
|
|
*
|
|
* @param[in] port_name_in
|
|
* String representing the port name.
|
|
* @param[out] port_info_out
|
|
* Port information, including port name as a number and port name
|
|
* type if recognized
|
|
*
|
|
* @return
|
|
* port_name field set according to recognized name format.
|
|
*/
|
|
void
|
|
mlx5_translate_port_name(const char *port_name_in,
|
|
struct mlx5_switch_info *port_info_out)
|
|
{
|
|
char pf_c1, pf_c2, vf_c1, vf_c2;
|
|
char *end;
|
|
int sc_items;
|
|
|
|
/*
|
|
* Check for port-name as a string of the form pf0vf0
|
|
* (support kernel ver >= 5.0 or OFED ver >= 4.6).
|
|
*/
|
|
sc_items = sscanf(port_name_in, "%c%c%d%c%c%d",
|
|
&pf_c1, &pf_c2, &port_info_out->pf_num,
|
|
&vf_c1, &vf_c2, &port_info_out->port_name);
|
|
if (sc_items == 6 &&
|
|
pf_c1 == 'p' && pf_c2 == 'f' &&
|
|
vf_c1 == 'v' && vf_c2 == 'f') {
|
|
port_info_out->name_type = MLX5_PHYS_PORT_NAME_TYPE_PFVF;
|
|
return;
|
|
}
|
|
/*
|
|
* Check for port-name as a string of the form p0
|
|
* (support kernel ver >= 5.0, or OFED ver >= 4.6).
|
|
*/
|
|
sc_items = sscanf(port_name_in, "%c%d",
|
|
&pf_c1, &port_info_out->port_name);
|
|
if (sc_items == 2 && pf_c1 == 'p') {
|
|
port_info_out->name_type = MLX5_PHYS_PORT_NAME_TYPE_UPLINK;
|
|
return;
|
|
}
|
|
/* Check for port-name as a number (support kernel ver < 5.0 */
|
|
errno = 0;
|
|
port_info_out->port_name = strtol(port_name_in, &end, 0);
|
|
if (!errno &&
|
|
(size_t)(end - port_name_in) == strlen(port_name_in)) {
|
|
port_info_out->name_type = MLX5_PHYS_PORT_NAME_TYPE_LEGACY;
|
|
return;
|
|
}
|
|
port_info_out->name_type = MLX5_PHYS_PORT_NAME_TYPE_UNKNOWN;
|
|
return;
|
|
}
|
|
|
|
#ifdef RTE_IBVERBS_LINK_DLOPEN
|
|
|
|
/**
|
|
* Suffix RTE_EAL_PMD_PATH with "-glue".
|
|
*
|
|
* This function performs a sanity check on RTE_EAL_PMD_PATH before
|
|
* suffixing its last component.
|
|
*
|
|
* @param buf[out]
|
|
* Output buffer, should be large enough otherwise NULL is returned.
|
|
* @param size
|
|
* Size of @p out.
|
|
*
|
|
* @return
|
|
* Pointer to @p buf or @p NULL in case suffix cannot be appended.
|
|
*/
|
|
static char *
|
|
mlx5_glue_path(char *buf, size_t size)
|
|
{
|
|
static const char *const bad[] = { "/", ".", "..", NULL };
|
|
const char *path = RTE_EAL_PMD_PATH;
|
|
size_t len = strlen(path);
|
|
size_t off;
|
|
int i;
|
|
|
|
while (len && path[len - 1] == '/')
|
|
--len;
|
|
for (off = len; off && path[off - 1] != '/'; --off)
|
|
;
|
|
for (i = 0; bad[i]; ++i)
|
|
if (!strncmp(path + off, bad[i], (int)(len - off)))
|
|
goto error;
|
|
i = snprintf(buf, size, "%.*s-glue", (int)len, path);
|
|
if (i == -1 || (size_t)i >= size)
|
|
goto error;
|
|
return buf;
|
|
error:
|
|
RTE_LOG(ERR, PMD, "unable to append \"-glue\" to last component of"
|
|
" RTE_EAL_PMD_PATH (\"" RTE_EAL_PMD_PATH "\"), please"
|
|
" re-configure DPDK");
|
|
return NULL;
|
|
}
|
|
#endif
|
|
|
|
/**
|
|
* Initialization routine for run-time dependency on rdma-core.
|
|
*/
|
|
RTE_INIT_PRIO(mlx5_glue_init, CLASS)
|
|
{
|
|
/* Initialize common log type. */
|
|
mlx5_common_logtype = rte_log_register("pmd.common.mlx5");
|
|
if (mlx5_common_logtype >= 0)
|
|
rte_log_set_level(mlx5_common_logtype, RTE_LOG_NOTICE);
|
|
/*
|
|
* RDMAV_HUGEPAGES_SAFE tells ibv_fork_init() we intend to use
|
|
* huge pages. Calling ibv_fork_init() during init allows
|
|
* applications to use fork() safely for purposes other than
|
|
* using this PMD, which is not supported in forked processes.
|
|
*/
|
|
setenv("RDMAV_HUGEPAGES_SAFE", "1", 1);
|
|
/* Match the size of Rx completion entry to the size of a cacheline. */
|
|
if (RTE_CACHE_LINE_SIZE == 128)
|
|
setenv("MLX5_CQE_SIZE", "128", 0);
|
|
/*
|
|
* MLX5_DEVICE_FATAL_CLEANUP tells ibv_destroy functions to
|
|
* cleanup all the Verbs resources even when the device was removed.
|
|
*/
|
|
setenv("MLX5_DEVICE_FATAL_CLEANUP", "1", 1);
|
|
/* The glue initialization was done earlier by mlx5 common library. */
|
|
#ifdef RTE_IBVERBS_LINK_DLOPEN
|
|
char glue_path[sizeof(RTE_EAL_PMD_PATH) - 1 + sizeof("-glue")];
|
|
void *handle = NULL;
|
|
|
|
const char *path[] = {
|
|
/*
|
|
* A basic security check is necessary before trusting
|
|
* MLX5_GLUE_PATH, which may override RTE_EAL_PMD_PATH.
|
|
*/
|
|
(geteuid() == getuid() && getegid() == getgid() ?
|
|
getenv("MLX5_GLUE_PATH") : NULL),
|
|
/*
|
|
* When RTE_EAL_PMD_PATH is set, use its glue-suffixed
|
|
* variant, otherwise let dlopen() look up libraries on its
|
|
* own.
|
|
*/
|
|
(*RTE_EAL_PMD_PATH ?
|
|
mlx5_glue_path(glue_path, sizeof(glue_path)) : ""),
|
|
};
|
|
unsigned int i = 0;
|
|
void **sym;
|
|
const char *dlmsg;
|
|
|
|
while (!handle && i != RTE_DIM(path)) {
|
|
const char *end;
|
|
size_t len;
|
|
int ret;
|
|
|
|
if (!path[i]) {
|
|
++i;
|
|
continue;
|
|
}
|
|
end = strpbrk(path[i], ":;");
|
|
if (!end)
|
|
end = path[i] + strlen(path[i]);
|
|
len = end - path[i];
|
|
ret = 0;
|
|
do {
|
|
char name[ret + 1];
|
|
|
|
ret = snprintf(name, sizeof(name), "%.*s%s" MLX5_GLUE,
|
|
(int)len, path[i],
|
|
(!len || *(end - 1) == '/') ? "" : "/");
|
|
if (ret == -1)
|
|
break;
|
|
if (sizeof(name) != (size_t)ret + 1)
|
|
continue;
|
|
DRV_LOG(DEBUG, "Looking for rdma-core glue as "
|
|
"\"%s\"", name);
|
|
handle = dlopen(name, RTLD_LAZY);
|
|
break;
|
|
} while (1);
|
|
path[i] = end + 1;
|
|
if (!*end)
|
|
++i;
|
|
}
|
|
if (!handle) {
|
|
rte_errno = EINVAL;
|
|
dlmsg = dlerror();
|
|
if (dlmsg)
|
|
DRV_LOG(WARNING, "Cannot load glue library: %s", dlmsg);
|
|
goto glue_error;
|
|
}
|
|
sym = dlsym(handle, "mlx5_glue");
|
|
if (!sym || !*sym) {
|
|
rte_errno = EINVAL;
|
|
dlmsg = dlerror();
|
|
if (dlmsg)
|
|
DRV_LOG(ERR, "Cannot resolve glue symbol: %s", dlmsg);
|
|
goto glue_error;
|
|
}
|
|
mlx5_glue = *sym;
|
|
#endif /* RTE_IBVERBS_LINK_DLOPEN */
|
|
#ifdef RTE_LIBRTE_MLX5_DEBUG
|
|
/* Glue structure must not contain any NULL pointers. */
|
|
{
|
|
unsigned int i;
|
|
|
|
for (i = 0; i != sizeof(*mlx5_glue) / sizeof(void *); ++i)
|
|
MLX5_ASSERT(((const void *const *)mlx5_glue)[i]);
|
|
}
|
|
#endif
|
|
if (strcmp(mlx5_glue->version, MLX5_GLUE_VERSION)) {
|
|
rte_errno = EINVAL;
|
|
DRV_LOG(ERR, "rdma-core glue \"%s\" mismatch: \"%s\" is "
|
|
"required", mlx5_glue->version, MLX5_GLUE_VERSION);
|
|
goto glue_error;
|
|
}
|
|
mlx5_glue->fork_init();
|
|
return;
|
|
glue_error:
|
|
#ifdef RTE_IBVERBS_LINK_DLOPEN
|
|
if (handle)
|
|
dlclose(handle);
|
|
#endif
|
|
DRV_LOG(WARNING, "Cannot initialize MLX5 common due to missing"
|
|
" run-time dependency on rdma-core libraries (libibverbs,"
|
|
" libmlx5)");
|
|
mlx5_glue = NULL;
|
|
return;
|
|
}
|