e40303eb0f
Any DPDK public header file which includes stdbool.h may conflict with
local definition of bool, if any, which further results in compilation
error. To avoid, used standard stdbool.h instead of defining bool
internally.
I observed this issue during a development where I included rte_uuid.h
into rte_ethdev.h. As rte_ethdev.h is included to PMD driver, it started
throwing error as given below:
CC ionic_rxtx.o
In file included from .../dpdk/build/include/rte_uuid.h:17:0,
from .../dpdk/build/include/rte_ethdev.h:161,
from .../dpdk/build/include/rte_ethdev_driver.h:18,
from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34:
.../dpdk/drivers/net/ionic/ionic_osdep.h:48:17:
error: two or more data types in declaration specifiers
typedef uint8_t bool;
^
In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0,
from .../dpdk/drivers/net/ionic/ionic.h:13,
from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8,
from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45:
.../dpdk/drivers/net/ionic/ionic_osdep.h:48:1:
warning: useless type name in empty declaration
typedef uint8_t bool;
^~~~~~~
cc1: warning: unrecognized command line option
‘-Wno-address-of-packed-member’
.../dpdk/mk/internal/rte.compile-pre.mk:114:
recipe for target 'ionic_rxtx.o' failed
Fixes: 5ef518098e
("net/ionic: register and initialize adapter")
Cc: stable@dpdk.org
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
Acked-by: Alfredo Cardigliano <cardigliano@ntop.org>
444 lines
11 KiB
C
444 lines
11 KiB
C
/* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0)
|
|
* Copyright(c) 2018-2019 Pensando Systems, Inc. All rights reserved.
|
|
*/
|
|
|
|
#include <stdbool.h>
|
|
|
|
#include <rte_memzone.h>
|
|
|
|
#include "ionic.h"
|
|
#include "ionic_ethdev.h"
|
|
#include "ionic_lif.h"
|
|
|
|
static const char *
|
|
ionic_error_to_str(enum ionic_status_code code)
|
|
{
|
|
switch (code) {
|
|
case IONIC_RC_SUCCESS:
|
|
return "IONIC_RC_SUCCESS";
|
|
case IONIC_RC_EVERSION:
|
|
return "IONIC_RC_EVERSION";
|
|
case IONIC_RC_EOPCODE:
|
|
return "IONIC_RC_EOPCODE";
|
|
case IONIC_RC_EIO:
|
|
return "IONIC_RC_EIO";
|
|
case IONIC_RC_EPERM:
|
|
return "IONIC_RC_EPERM";
|
|
case IONIC_RC_EQID:
|
|
return "IONIC_RC_EQID";
|
|
case IONIC_RC_EQTYPE:
|
|
return "IONIC_RC_EQTYPE";
|
|
case IONIC_RC_ENOENT:
|
|
return "IONIC_RC_ENOENT";
|
|
case IONIC_RC_EINTR:
|
|
return "IONIC_RC_EINTR";
|
|
case IONIC_RC_EAGAIN:
|
|
return "IONIC_RC_EAGAIN";
|
|
case IONIC_RC_ENOMEM:
|
|
return "IONIC_RC_ENOMEM";
|
|
case IONIC_RC_EFAULT:
|
|
return "IONIC_RC_EFAULT";
|
|
case IONIC_RC_EBUSY:
|
|
return "IONIC_RC_EBUSY";
|
|
case IONIC_RC_EEXIST:
|
|
return "IONIC_RC_EEXIST";
|
|
case IONIC_RC_EINVAL:
|
|
return "IONIC_RC_EINVAL";
|
|
case IONIC_RC_ENOSPC:
|
|
return "IONIC_RC_ENOSPC";
|
|
case IONIC_RC_ERANGE:
|
|
return "IONIC_RC_ERANGE";
|
|
case IONIC_RC_BAD_ADDR:
|
|
return "IONIC_RC_BAD_ADDR";
|
|
case IONIC_RC_DEV_CMD:
|
|
return "IONIC_RC_DEV_CMD";
|
|
case IONIC_RC_ERROR:
|
|
return "IONIC_RC_ERROR";
|
|
case IONIC_RC_ERDMA:
|
|
return "IONIC_RC_ERDMA";
|
|
default:
|
|
return "IONIC_RC_UNKNOWN";
|
|
}
|
|
}
|
|
|
|
static const char *
|
|
ionic_opcode_to_str(enum ionic_cmd_opcode opcode)
|
|
{
|
|
switch (opcode) {
|
|
case IONIC_CMD_NOP:
|
|
return "IONIC_CMD_NOP";
|
|
case IONIC_CMD_INIT:
|
|
return "IONIC_CMD_INIT";
|
|
case IONIC_CMD_RESET:
|
|
return "IONIC_CMD_RESET";
|
|
case IONIC_CMD_IDENTIFY:
|
|
return "IONIC_CMD_IDENTIFY";
|
|
case IONIC_CMD_GETATTR:
|
|
return "IONIC_CMD_GETATTR";
|
|
case IONIC_CMD_SETATTR:
|
|
return "IONIC_CMD_SETATTR";
|
|
case IONIC_CMD_PORT_IDENTIFY:
|
|
return "IONIC_CMD_PORT_IDENTIFY";
|
|
case IONIC_CMD_PORT_INIT:
|
|
return "IONIC_CMD_PORT_INIT";
|
|
case IONIC_CMD_PORT_RESET:
|
|
return "IONIC_CMD_PORT_RESET";
|
|
case IONIC_CMD_PORT_GETATTR:
|
|
return "IONIC_CMD_PORT_GETATTR";
|
|
case IONIC_CMD_PORT_SETATTR:
|
|
return "IONIC_CMD_PORT_SETATTR";
|
|
case IONIC_CMD_LIF_INIT:
|
|
return "IONIC_CMD_LIF_INIT";
|
|
case IONIC_CMD_LIF_RESET:
|
|
return "IONIC_CMD_LIF_RESET";
|
|
case IONIC_CMD_LIF_IDENTIFY:
|
|
return "IONIC_CMD_LIF_IDENTIFY";
|
|
case IONIC_CMD_LIF_SETATTR:
|
|
return "IONIC_CMD_LIF_SETATTR";
|
|
case IONIC_CMD_LIF_GETATTR:
|
|
return "IONIC_CMD_LIF_GETATTR";
|
|
case IONIC_CMD_RX_MODE_SET:
|
|
return "IONIC_CMD_RX_MODE_SET";
|
|
case IONIC_CMD_RX_FILTER_ADD:
|
|
return "IONIC_CMD_RX_FILTER_ADD";
|
|
case IONIC_CMD_RX_FILTER_DEL:
|
|
return "IONIC_CMD_RX_FILTER_DEL";
|
|
case IONIC_CMD_Q_INIT:
|
|
return "IONIC_CMD_Q_INIT";
|
|
case IONIC_CMD_Q_CONTROL:
|
|
return "IONIC_CMD_Q_CONTROL";
|
|
case IONIC_CMD_RDMA_RESET_LIF:
|
|
return "IONIC_CMD_RDMA_RESET_LIF";
|
|
case IONIC_CMD_RDMA_CREATE_EQ:
|
|
return "IONIC_CMD_RDMA_CREATE_EQ";
|
|
case IONIC_CMD_RDMA_CREATE_CQ:
|
|
return "IONIC_CMD_RDMA_CREATE_CQ";
|
|
case IONIC_CMD_RDMA_CREATE_ADMINQ:
|
|
return "IONIC_CMD_RDMA_CREATE_ADMINQ";
|
|
default:
|
|
return "DEVCMD_UNKNOWN";
|
|
}
|
|
}
|
|
|
|
int
|
|
ionic_adminq_check_err(struct ionic_admin_ctx *ctx, bool timeout)
|
|
{
|
|
const char *name;
|
|
const char *status;
|
|
|
|
if (ctx->comp.comp.status || timeout) {
|
|
name = ionic_opcode_to_str(ctx->cmd.cmd.opcode);
|
|
status = ionic_error_to_str(ctx->comp.comp.status);
|
|
IONIC_PRINT(ERR, "%s (%d) failed: %s (%d)",
|
|
name,
|
|
ctx->cmd.cmd.opcode,
|
|
timeout ? "TIMEOUT" : status,
|
|
timeout ? -1 : ctx->comp.comp.status);
|
|
return -EIO;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
ionic_wait_ctx_for_completion(struct ionic_lif *lif, struct ionic_qcq *qcq,
|
|
struct ionic_admin_ctx *ctx, unsigned long max_wait)
|
|
{
|
|
unsigned long step_msec = 1;
|
|
unsigned int max_wait_msec = max_wait * 1000;
|
|
unsigned long elapsed_msec = 0;
|
|
int budget = 8;
|
|
|
|
while (ctx->pending_work && elapsed_msec < max_wait_msec) {
|
|
/*
|
|
* Locking here as adminq is served inline (this could be called
|
|
* from multiple places)
|
|
*/
|
|
rte_spinlock_lock(&lif->adminq_service_lock);
|
|
|
|
ionic_qcq_service(qcq, budget, ionic_adminq_service, NULL);
|
|
|
|
rte_spinlock_unlock(&lif->adminq_service_lock);
|
|
|
|
msec_delay(step_msec);
|
|
elapsed_msec += step_msec;
|
|
}
|
|
|
|
return (!ctx->pending_work);
|
|
}
|
|
|
|
int
|
|
ionic_adminq_post_wait(struct ionic_lif *lif, struct ionic_admin_ctx *ctx)
|
|
{
|
|
struct ionic_qcq *qcq = lif->adminqcq;
|
|
bool done;
|
|
int err;
|
|
|
|
IONIC_PRINT(DEBUG, "Sending %s to the admin queue",
|
|
ionic_opcode_to_str(ctx->cmd.cmd.opcode));
|
|
|
|
err = ionic_adminq_post(lif, ctx);
|
|
if (err) {
|
|
IONIC_PRINT(ERR, "Failure posting to the admin queue %d (%d)",
|
|
ctx->cmd.cmd.opcode, err);
|
|
|
|
return err;
|
|
}
|
|
|
|
done = ionic_wait_ctx_for_completion(lif, qcq, ctx,
|
|
IONIC_DEVCMD_TIMEOUT);
|
|
|
|
err = ionic_adminq_check_err(ctx, !done /* timed out */);
|
|
return err;
|
|
}
|
|
|
|
static int
|
|
ionic_dev_cmd_wait(struct ionic_dev *idev, unsigned long max_wait)
|
|
{
|
|
unsigned long step_msec = 100;
|
|
unsigned int max_wait_msec = max_wait * 1000;
|
|
unsigned long elapsed_msec = 0;
|
|
int done;
|
|
|
|
/* Wait for dev cmd to complete.. but no more than max_wait sec */
|
|
|
|
do {
|
|
done = ionic_dev_cmd_done(idev);
|
|
if (done) {
|
|
IONIC_PRINT(DEBUG, "DEVCMD %d done took %ld msecs",
|
|
idev->dev_cmd->cmd.cmd.opcode,
|
|
elapsed_msec);
|
|
return 0;
|
|
}
|
|
|
|
msec_delay(step_msec);
|
|
|
|
elapsed_msec += step_msec;
|
|
} while (elapsed_msec < max_wait_msec);
|
|
|
|
IONIC_PRINT(DEBUG, "DEVCMD %d timeout after %ld msecs",
|
|
idev->dev_cmd->cmd.cmd.opcode,
|
|
elapsed_msec);
|
|
|
|
return -ETIMEDOUT;
|
|
}
|
|
|
|
static int
|
|
ionic_dev_cmd_check_error(struct ionic_dev *idev)
|
|
{
|
|
uint8_t status;
|
|
|
|
status = ionic_dev_cmd_status(idev);
|
|
if (status == 0)
|
|
return 0;
|
|
|
|
return -EIO;
|
|
}
|
|
|
|
int
|
|
ionic_dev_cmd_wait_check(struct ionic_dev *idev, unsigned long max_wait)
|
|
{
|
|
int err;
|
|
|
|
err = ionic_dev_cmd_wait(idev, max_wait);
|
|
if (err)
|
|
return err;
|
|
|
|
return ionic_dev_cmd_check_error(idev);
|
|
}
|
|
|
|
int
|
|
ionic_setup(struct ionic_adapter *adapter)
|
|
{
|
|
return ionic_dev_setup(adapter);
|
|
}
|
|
|
|
int
|
|
ionic_identify(struct ionic_adapter *adapter)
|
|
{
|
|
struct ionic_dev *idev = &adapter->idev;
|
|
struct ionic_identity *ident = &adapter->ident;
|
|
int err = 0;
|
|
uint32_t i;
|
|
unsigned int nwords;
|
|
uint32_t drv_size = sizeof(ident->drv.words) /
|
|
sizeof(ident->drv.words[0]);
|
|
uint32_t cmd_size = sizeof(idev->dev_cmd->data) /
|
|
sizeof(idev->dev_cmd->data[0]);
|
|
uint32_t dev_size = sizeof(ident->dev.words) /
|
|
sizeof(ident->dev.words[0]);
|
|
|
|
memset(ident, 0, sizeof(*ident));
|
|
|
|
ident->drv.os_type = IONIC_OS_TYPE_LINUX;
|
|
ident->drv.os_dist = 0;
|
|
snprintf(ident->drv.os_dist_str,
|
|
sizeof(ident->drv.os_dist_str), "Unknown");
|
|
ident->drv.kernel_ver = 0;
|
|
snprintf(ident->drv.kernel_ver_str,
|
|
sizeof(ident->drv.kernel_ver_str), "DPDK");
|
|
strncpy(ident->drv.driver_ver_str, IONIC_DRV_VERSION,
|
|
sizeof(ident->drv.driver_ver_str) - 1);
|
|
|
|
nwords = RTE_MIN(drv_size, cmd_size);
|
|
for (i = 0; i < nwords; i++)
|
|
iowrite32(ident->drv.words[i], &idev->dev_cmd->data[i]);
|
|
|
|
ionic_dev_cmd_identify(idev, IONIC_IDENTITY_VERSION_1);
|
|
err = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);
|
|
if (!err) {
|
|
nwords = RTE_MIN(dev_size, cmd_size);
|
|
for (i = 0; i < nwords; i++)
|
|
ident->dev.words[i] = ioread32(&idev->dev_cmd->data[i]);
|
|
}
|
|
|
|
return err;
|
|
}
|
|
|
|
int
|
|
ionic_init(struct ionic_adapter *adapter)
|
|
{
|
|
struct ionic_dev *idev = &adapter->idev;
|
|
int err;
|
|
|
|
ionic_dev_cmd_init(idev);
|
|
err = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);
|
|
return err;
|
|
}
|
|
|
|
int
|
|
ionic_reset(struct ionic_adapter *adapter)
|
|
{
|
|
struct ionic_dev *idev = &adapter->idev;
|
|
int err;
|
|
|
|
ionic_dev_cmd_reset(idev);
|
|
err = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);
|
|
return err;
|
|
}
|
|
|
|
int
|
|
ionic_port_identify(struct ionic_adapter *adapter)
|
|
{
|
|
struct ionic_dev *idev = &adapter->idev;
|
|
struct ionic_identity *ident = &adapter->ident;
|
|
unsigned int port_words = sizeof(ident->port.words) /
|
|
sizeof(ident->port.words[0]);
|
|
unsigned int cmd_words = sizeof(idev->dev_cmd->data) /
|
|
sizeof(idev->dev_cmd->data[0]);
|
|
unsigned int i;
|
|
unsigned int nwords;
|
|
int err;
|
|
|
|
ionic_dev_cmd_port_identify(idev);
|
|
err = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);
|
|
if (!err) {
|
|
nwords = RTE_MIN(port_words, cmd_words);
|
|
for (i = 0; i < nwords; i++)
|
|
ident->port.words[i] =
|
|
ioread32(&idev->dev_cmd->data[i]);
|
|
}
|
|
|
|
IONIC_PRINT(INFO, "speed %d ", ident->port.config.speed);
|
|
IONIC_PRINT(INFO, "mtu %d ", ident->port.config.mtu);
|
|
IONIC_PRINT(INFO, "state %d ", ident->port.config.state);
|
|
IONIC_PRINT(INFO, "an_enable %d ", ident->port.config.an_enable);
|
|
IONIC_PRINT(INFO, "fec_type %d ", ident->port.config.fec_type);
|
|
IONIC_PRINT(INFO, "pause_type %d ", ident->port.config.pause_type);
|
|
IONIC_PRINT(INFO, "loopback_mode %d",
|
|
ident->port.config.loopback_mode);
|
|
|
|
return err;
|
|
}
|
|
|
|
static const struct rte_memzone *
|
|
ionic_memzone_reserve(const char *name, uint32_t len, int socket_id)
|
|
{
|
|
const struct rte_memzone *mz;
|
|
|
|
mz = rte_memzone_lookup(name);
|
|
if (mz)
|
|
return mz;
|
|
|
|
mz = rte_memzone_reserve_aligned(name, len, socket_id,
|
|
RTE_MEMZONE_IOVA_CONTIG, IONIC_ALIGN);
|
|
return mz;
|
|
}
|
|
|
|
int
|
|
ionic_port_init(struct ionic_adapter *adapter)
|
|
{
|
|
struct ionic_dev *idev = &adapter->idev;
|
|
struct ionic_identity *ident = &adapter->ident;
|
|
char z_name[RTE_MEMZONE_NAMESIZE];
|
|
unsigned int config_words = sizeof(ident->port.config.words) /
|
|
sizeof(ident->port.config.words[0]);
|
|
unsigned int cmd_words = sizeof(idev->dev_cmd->data) /
|
|
sizeof(idev->dev_cmd->data[0]);
|
|
unsigned int nwords;
|
|
unsigned int i;
|
|
int err;
|
|
|
|
if (idev->port_info)
|
|
return 0;
|
|
|
|
idev->port_info_sz = RTE_ALIGN(sizeof(*idev->port_info), PAGE_SIZE);
|
|
|
|
snprintf(z_name, sizeof(z_name), "%s_port_%s_info",
|
|
IONIC_DRV_NAME,
|
|
adapter->pci_dev->device.name);
|
|
|
|
idev->port_info_z = ionic_memzone_reserve(z_name, idev->port_info_sz,
|
|
SOCKET_ID_ANY);
|
|
if (!idev->port_info_z) {
|
|
IONIC_PRINT(ERR, "Cannot reserve port info DMA memory");
|
|
return -ENOMEM;
|
|
}
|
|
|
|
idev->port_info = idev->port_info_z->addr;
|
|
idev->port_info_pa = idev->port_info_z->iova;
|
|
|
|
nwords = RTE_MIN(config_words, cmd_words);
|
|
|
|
for (i = 0; i < nwords; i++)
|
|
iowrite32(ident->port.config.words[i], &idev->dev_cmd->data[i]);
|
|
|
|
ionic_dev_cmd_port_init(idev);
|
|
err = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);
|
|
if (err) {
|
|
IONIC_PRINT(ERR, "Failed to init port");
|
|
return err;
|
|
}
|
|
|
|
ionic_dev_cmd_port_state(idev, IONIC_PORT_ADMIN_STATE_UP);
|
|
err = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);
|
|
if (err) {
|
|
IONIC_PRINT(WARNING, "Failed to bring port UP");
|
|
return err;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
ionic_port_reset(struct ionic_adapter *adapter)
|
|
{
|
|
struct ionic_dev *idev = &adapter->idev;
|
|
int err;
|
|
|
|
if (!idev->port_info)
|
|
return 0;
|
|
|
|
ionic_dev_cmd_port_reset(idev);
|
|
err = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);
|
|
if (err) {
|
|
IONIC_PRINT(ERR, "Failed to reset port");
|
|
return err;
|
|
}
|
|
|
|
idev->port_info = NULL;
|
|
idev->port_info_pa = 0;
|
|
|
|
return 0;
|
|
}
|