27e71c7fdc
in 18.08 new cache-aligned structure rte_crypto_asym_op was introduced.
As it also was included into rte_crypto_op, it caused implicit change
in rte_crypto_op layout and alignment: now rte_crypto_op is cache-line
aligned has a hole of 40/104 bytes between phys_addr and sym/asym op.
It looks like unintended ABI breakage, plus such change can cause
negative performance effects:
- now status and sym[0].m_src lies on different cache-lines, so
post-process code would need extra cache-line read.
- new alignment causes grow of the space requirements and cache-line
reads/updates for structures that contain rte_crypto_op inside.
As there seems no actual need to have rte_crypto_asym_op cache-line
aligned, and rte_crypto_asym_op is not intended to be used on it's own -
the simplest fix is just to remove cache-line alignment for it.
As the immediate positive effect: on IA ipsec-secgw performance increased
by 5-10% (depending on the crypto-dev and algo used).
My guess that on machines with 128B cache-line and lookaside-protocol
capable crypto devices the impact will be even more noticeable.
Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions")
Cc: stable@dpdk.org
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Acked-by: Shally Verma <shallyv@marvell.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
33 lines
744 B
Makefile
33 lines
744 B
Makefile
# SPDX-License-Identifier: BSD-3-Clause
|
|
# Copyright(c) 2015-2019 Intel Corporation
|
|
|
|
include $(RTE_SDK)/mk/rte.vars.mk
|
|
|
|
# library name
|
|
LIB = librte_cryptodev.a
|
|
|
|
# library version
|
|
LIBABIVER := 7
|
|
|
|
# build flags
|
|
CFLAGS += -O3
|
|
CFLAGS += $(WERROR_FLAGS)
|
|
CFLAGS += -DALLOW_EXPERIMENTAL_API
|
|
LDLIBS += -lrte_eal -lrte_mempool -lrte_ring -lrte_mbuf
|
|
LDLIBS += -lrte_kvargs
|
|
|
|
# library source files
|
|
SRCS-y += rte_cryptodev.c rte_cryptodev_pmd.c
|
|
|
|
# export include files
|
|
SYMLINK-y-include += rte_crypto.h
|
|
SYMLINK-y-include += rte_crypto_sym.h
|
|
SYMLINK-y-include += rte_cryptodev.h
|
|
SYMLINK-y-include += rte_cryptodev_pmd.h
|
|
SYMLINK-y-include += rte_crypto_asym.h
|
|
|
|
# versioning export map
|
|
EXPORT_MAP := rte_cryptodev_version.map
|
|
|
|
include $(RTE_SDK)/mk/rte.lib.mk
|