4226aa9cac
This patch fixes a compilation issue met with GCC 12 on
LoongArch64:
In function ‘mbuf_to_desc’,
inlined from ‘vhost_enqueue_async_packed’
inlined from ‘virtio_dev_rx_async_packed’
inlined from ‘virtio_dev_rx_async_submit_packed’
lib/vhost/virtio_net.c:1159:18: error:
‘buf_vec[0].buf_addr’ may be used uninitialized
1159 | buf_addr = buf_vec[vec_idx].buf_addr;
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
lib/vhost/virtio_net.c: In function ‘virtio_dev_rx_async_submit_packed’:
lib/vhost/virtio_net.c:1834:27: note: ‘buf_vec’ declared here
1834 | struct buf_vector buf_vec[BUF_VECTOR_MAX];
| ^~~~~~~
It happens because the compiler assumes that 'size'
variable in vhost_enqueue_async_packed could wrap to 0 since
'size' is uint32_t and pkt->pkt_len too.
In practice, it would never happen since 'pkt->pkt_len' is
unlikely to be close to UINT32_MAX, but let's just change
'size' to uint64_t to make the compiler happy without
having to add runtime checks.
This patch also fixes similar patterns in three other
places, including one that also produces similar build
issue on ARM64 in vhost_enqueue_single_packed().
Fixes:
|
||
---|---|---|
.. | ||
fd_man.c | ||
fd_man.h | ||
iotlb.c | ||
iotlb.h | ||
meson.build | ||
rte_vdpa.h | ||
rte_vhost_async.h | ||
rte_vhost_crypto.h | ||
rte_vhost.h | ||
socket.c | ||
vdpa_driver.h | ||
vdpa.c | ||
version.map | ||
vhost_crypto.c | ||
vhost_user.c | ||
vhost_user.h | ||
vhost.c | ||
vhost.h | ||
virtio_crypto.h | ||
virtio_net.c |