numam-dpdk/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c
Shreyansh Jain 88d0e47880 raw/skeleton: fix memory leak on test failure
In skeleton_rawdev unit tests, a malloc'd memory was leaking in case
the next sequential test fails. This fix moves the free of the
malloc'd memory above the failing test.

Coverity issue: 260402
Fixes: 55ca1b0f21 ("raw/skeleton: add test cases")

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
2018-10-25 00:59:28 +02:00

464 lines
12 KiB
C

/* SPDX-License-Identifier: BSD-3-Clause
* Copyright 2017 NXP
*/
#include <rte_common.h>
#include <rte_mbuf.h>
#include <rte_malloc.h>
#include <rte_memcpy.h>
#include <rte_dev.h>
#include <rte_rawdev.h>
#include <rte_bus_vdev.h>
#include <rte_test.h>
/* Using relative path as skeleton_rawdev is not part of exported headers */
#include "skeleton_rawdev.h"
#define TEST_DEV_ID 0
#define TEST_DEV_NAME "rawdev_skeleton"
#define SKELDEV_LOGS(level, fmt, args...) \
rte_log(RTE_LOG_ ## level, skeleton_pmd_logtype, fmt "\n", \
##args)
#define SKELDEV_TEST_INFO(fmt, args...) \
SKELDEV_LOGS(INFO, fmt, ## args)
#define SKELDEV_TEST_DEBUG(fmt, args...) \
SKELDEV_LOGS(DEBUG, fmt, ## args)
#define SKELDEV_TEST_RUN(setup, teardown, test) \
skeldev_test_run(setup, teardown, test, #test)
#define TEST_SUCCESS 0
#define TEST_FAILED -1
static int total;
static int passed;
static int failed;
static int unsupported;
static int
testsuite_setup(void)
{
uint8_t count;
count = rte_rawdev_count();
if (!count) {
SKELDEV_TEST_INFO("\tNo existing rawdev; "
"Creating 'skeldev_rawdev'");
return rte_vdev_init(TEST_DEV_NAME, NULL);
}
return TEST_SUCCESS;
}
static void local_teardown(void);
static void
testsuite_teardown(void)
{
local_teardown();
}
static void
local_teardown(void)
{
rte_vdev_uninit(TEST_DEV_NAME);
}
static int
test_rawdev_count(void)
{
uint8_t count;
count = rte_rawdev_count();
RTE_TEST_ASSERT(count > 0, "Invalid rawdev count %" PRIu8, count);
return TEST_SUCCESS;
}
static int
test_rawdev_get_dev_id(void)
{
int ret;
ret = rte_rawdev_get_dev_id("invalid_rawdev_device");
RTE_TEST_ASSERT_FAIL(ret, "Expected <0 for invalid dev name ret=%d",
ret);
return TEST_SUCCESS;
}
static int
test_rawdev_socket_id(void)
{
int socket_id;
socket_id = rte_rawdev_socket_id(TEST_DEV_ID);
RTE_TEST_ASSERT(socket_id != -EINVAL,
"Failed to get socket_id %d", socket_id);
socket_id = rte_rawdev_socket_id(RTE_RAWDEV_MAX_DEVS);
RTE_TEST_ASSERT(socket_id == -EINVAL,
"Expected -EINVAL %d", socket_id);
return TEST_SUCCESS;
}
static int
test_rawdev_info_get(void)
{
int ret;
struct rte_rawdev_info rdev_info = {0};
struct skeleton_rawdev_conf skel_conf = {0};
ret = rte_rawdev_info_get(TEST_DEV_ID, NULL);
RTE_TEST_ASSERT(ret == -EINVAL, "Expected -EINVAL, %d", ret);
rdev_info.dev_private = &skel_conf;
ret = rte_rawdev_info_get(TEST_DEV_ID, &rdev_info);
RTE_TEST_ASSERT_SUCCESS(ret, "Failed to get raw dev info");
return TEST_SUCCESS;
}
static int
test_rawdev_configure(void)
{
int ret;
struct rte_rawdev_info rdev_info = {0};
struct skeleton_rawdev_conf rdev_conf_set = {0};
struct skeleton_rawdev_conf rdev_conf_get = {0};
/* Check invalid configuration */
ret = rte_rawdev_configure(TEST_DEV_ID, NULL);
RTE_TEST_ASSERT(ret == -EINVAL,
"Null configure; Expected -EINVAL, got %d", ret);
/* Valid configuration test */
rdev_conf_set.num_queues = 1;
rdev_conf_set.capabilities = SKELETON_CAPA_FW_LOAD |
SKELETON_CAPA_FW_RESET;
rdev_info.dev_private = &rdev_conf_set;
ret = rte_rawdev_configure(TEST_DEV_ID,
(rte_rawdev_obj_t)&rdev_info);
RTE_TEST_ASSERT_SUCCESS(ret, "Failed to configure rawdev (%d)", ret);
rdev_info.dev_private = &rdev_conf_get;
ret = rte_rawdev_info_get(TEST_DEV_ID,
(rte_rawdev_obj_t)&rdev_info);
RTE_TEST_ASSERT_SUCCESS(ret,
"Failed to obtain rawdev configuration (%d)",
ret);
RTE_TEST_ASSERT_EQUAL(rdev_conf_set.num_queues,
rdev_conf_get.num_queues,
"Configuration test failed; num_queues (%d)(%d)",
rdev_conf_set.num_queues,
rdev_conf_get.num_queues);
RTE_TEST_ASSERT_EQUAL(rdev_conf_set.capabilities,
rdev_conf_get.capabilities,
"Configuration test failed; capabilities");
return TEST_SUCCESS;
}
static int
test_rawdev_queue_default_conf_get(void)
{
int ret, i;
struct rte_rawdev_info rdev_info = {0};
struct skeleton_rawdev_conf rdev_conf_get = {0};
struct skeleton_rawdev_queue q = {0};
/* Get the current configuration */
rdev_info.dev_private = &rdev_conf_get;
ret = rte_rawdev_info_get(TEST_DEV_ID,
(rte_rawdev_obj_t)&rdev_info);
RTE_TEST_ASSERT_SUCCESS(ret, "Failed to obtain rawdev configuration (%d)",
ret);
/* call to test_rawdev_configure would have set the num_queues = 1 */
RTE_TEST_ASSERT_SUCCESS(!(rdev_conf_get.num_queues > 0),
"Invalid number of queues (%d). Expected 1",
rdev_conf_get.num_queues);
/* All queues by default should have state = DETACH and
* depth = DEF_DEPTH
*/
for (i = 0; i < rdev_conf_get.num_queues; i++) {
rte_rawdev_queue_conf_get(TEST_DEV_ID, i, &q);
RTE_TEST_ASSERT_EQUAL(q.depth, SKELETON_QUEUE_DEF_DEPTH,
"Invalid default depth of queue (%d)",
q.depth);
RTE_TEST_ASSERT_EQUAL(q.state, SKELETON_QUEUE_DETACH,
"Invalid default state of queue (%d)",
q.state);
}
return TEST_SUCCESS;
}
static int
test_rawdev_queue_count(void)
{
unsigned int q_count;
/* Get the current configuration */
q_count = rte_rawdev_queue_count(TEST_DEV_ID);
RTE_TEST_ASSERT_EQUAL(q_count, 1, "Invalid queue count (%d)", q_count);
return TEST_SUCCESS;
}
static int
test_rawdev_queue_setup(void)
{
int ret;
struct rte_rawdev_info rdev_info = {0};
struct skeleton_rawdev_conf rdev_conf_get = {0};
struct skeleton_rawdev_queue qset = {0};
struct skeleton_rawdev_queue qget = {0};
/* Get the current configuration */
rdev_info.dev_private = &rdev_conf_get;
ret = rte_rawdev_info_get(TEST_DEV_ID,
(rte_rawdev_obj_t)&rdev_info);
RTE_TEST_ASSERT_SUCCESS(ret,
"Failed to obtain rawdev configuration (%d)",
ret);
/* call to test_rawdev_configure would have set the num_queues = 1 */
RTE_TEST_ASSERT_SUCCESS(!(rdev_conf_get.num_queues > 0),
"Invalid number of queues (%d). Expected 1",
rdev_conf_get.num_queues);
/* Modify the queue depth for Queue 0 and attach it */
qset.depth = 15;
qset.state = SKELETON_QUEUE_ATTACH;
ret = rte_rawdev_queue_setup(TEST_DEV_ID, 0, &qset);
RTE_TEST_ASSERT_SUCCESS(ret, "Failed to setup queue (%d)", ret);
/* Now, fetching the queue 0 should show depth as 15 */
ret = rte_rawdev_queue_conf_get(TEST_DEV_ID, 0, &qget);
RTE_TEST_ASSERT_SUCCESS(ret, "Failed to get queue config (%d)", ret);
RTE_TEST_ASSERT_EQUAL(qset.depth, qget.depth,
"Failed to set queue depth: Need(%d), has(%d)",
qset.depth, qget.depth);
return TEST_SUCCESS;
}
/* After executing test_rawdev_queue_setup, queue_id=0 would have depth as 15.
* Releasing should set it back to default. state would set to DETACH
*/
static int
test_rawdev_queue_release(void)
{
int ret;
struct skeleton_rawdev_queue qget = {0};
/* Now, fetching the queue 0 should show depth as 100 */
ret = rte_rawdev_queue_release(TEST_DEV_ID, 0);
RTE_TEST_ASSERT_SUCCESS(ret, "Failed to release queue 0; (%d)", ret);
/* Now, fetching the queue 0 should show depth as default */
ret = rte_rawdev_queue_conf_get(TEST_DEV_ID, 0, &qget);
RTE_TEST_ASSERT_SUCCESS(ret, "Failed to get queue config (%d)", ret);
RTE_TEST_ASSERT_EQUAL(qget.depth, SKELETON_QUEUE_DEF_DEPTH,
"Release of Queue 0 failed; (depth)");
RTE_TEST_ASSERT_EQUAL(qget.state, SKELETON_QUEUE_DETACH,
"Release of Queue 0 failed; (state)");
return TEST_SUCCESS;
}
static int
test_rawdev_attr_set_get(void)
{
int ret;
int *dummy_value;
uint64_t ret_value;
/* Set an attribute and fetch it */
ret = rte_rawdev_set_attr(TEST_DEV_ID, "Test1", 100);
RTE_TEST_ASSERT(!ret, "Unable to set an attribute (Test1)");
dummy_value = malloc(sizeof(int));
if (!dummy_value)
RTE_TEST_ASSERT(1, "Unable to allocate memory (dummy_value)");
*dummy_value = 200;
ret = rte_rawdev_set_attr(TEST_DEV_ID, "Test2", (uintptr_t)dummy_value);
/* Check if attributes have been set */
ret = rte_rawdev_get_attr(TEST_DEV_ID, "Test1", &ret_value);
RTE_TEST_ASSERT_EQUAL(ret_value, 100,
"Attribute (Test1) not set correctly (%" PRIu64 ")",
ret_value);
free(dummy_value);
ret_value = 0;
ret = rte_rawdev_get_attr(TEST_DEV_ID, "Test2", &ret_value);
RTE_TEST_ASSERT_EQUAL(*((int *)(uintptr_t)ret_value), 200,
"Attribute (Test2) not set correctly (%" PRIu64 ")",
ret_value);
return TEST_SUCCESS;
}
static int
test_rawdev_start_stop(void)
{
int ret;
struct rte_rawdev_info rdev_info = {0};
struct skeleton_rawdev_conf rdev_conf_get = {0};
char *dummy_firmware = NULL;
/* Get the current configuration */
rdev_info.dev_private = &rdev_conf_get;
/* Load a firmware using a dummy address area */
dummy_firmware = rte_zmalloc("RAWDEV SKELETON", sizeof(int) * 10, 0);
RTE_TEST_ASSERT(dummy_firmware != NULL,
"Failed to create firmware memory backing");
ret = rte_rawdev_firmware_load(TEST_DEV_ID, dummy_firmware);
RTE_TEST_ASSERT_SUCCESS(ret, "Firmware loading failed (%d)", ret);
/* Skeleton doesn't do anything with the firmware area - that is dummy
* and can be removed.
*/
rte_free(dummy_firmware);
dummy_firmware = NULL;
rte_rawdev_start(TEST_DEV_ID);
ret = rte_rawdev_info_get(TEST_DEV_ID, (rte_rawdev_obj_t)&rdev_info);
RTE_TEST_ASSERT_SUCCESS(ret,
"Failed to obtain rawdev configuration (%d)",
ret);
RTE_TEST_ASSERT_EQUAL(rdev_conf_get.device_state, SKELETON_DEV_RUNNING,
"Device start failed. State is (%d)",
rdev_conf_get.device_state);
rte_rawdev_stop(TEST_DEV_ID);
ret = rte_rawdev_info_get(TEST_DEV_ID, (rte_rawdev_obj_t)&rdev_info);
RTE_TEST_ASSERT_SUCCESS(ret,
"Failed to obtain rawdev configuration (%d)",
ret);
RTE_TEST_ASSERT_EQUAL(rdev_conf_get.device_state, SKELETON_DEV_STOPPED,
"Device stop failed. State is (%d)",
rdev_conf_get.device_state);
/* Unloading the firmware once device is stopped */
ret = rte_rawdev_firmware_unload(TEST_DEV_ID);
RTE_TEST_ASSERT_SUCCESS(ret, "Failed to unload firmware (%d)", ret);
return TEST_SUCCESS;
}
static int
test_rawdev_enqdeq(void)
{
int ret;
unsigned int count = 1;
uint16_t queue_id = 0;
struct rte_rawdev_buf buffers[1];
struct rte_rawdev_buf *deq_buffers = NULL;
buffers[0].buf_addr = malloc(strlen(TEST_DEV_NAME) + 3);
if (!buffers[0].buf_addr)
goto cleanup;
snprintf(buffers[0].buf_addr, strlen(TEST_DEV_NAME) + 2, "%s%d",
TEST_DEV_NAME, 0);
ret = rte_rawdev_enqueue_buffers(TEST_DEV_ID,
(struct rte_rawdev_buf **)&buffers,
count, &queue_id);
RTE_TEST_ASSERT_EQUAL((unsigned int)ret, count,
"Unable to enqueue buffers");
deq_buffers = malloc(sizeof(struct rte_rawdev_buf) * count);
if (!deq_buffers)
goto cleanup;
ret = rte_rawdev_dequeue_buffers(TEST_DEV_ID,
(struct rte_rawdev_buf **)&deq_buffers,
count, &queue_id);
RTE_TEST_ASSERT_EQUAL((unsigned int)ret, count,
"Unable to dequeue buffers");
if (deq_buffers)
free(deq_buffers);
return TEST_SUCCESS;
cleanup:
if (buffers[0].buf_addr)
free(buffers[0].buf_addr);
return TEST_FAILED;
}
static void skeldev_test_run(int (*setup)(void),
void (*teardown)(void),
int (*test)(void),
const char *name)
{
int ret = 0;
if (setup) {
ret = setup();
if (ret < 0) {
SKELDEV_TEST_INFO("Error setting up test %s", name);
unsupported++;
}
}
if (test) {
ret = test();
if (ret < 0) {
failed++;
SKELDEV_TEST_INFO("%s Failed", name);
} else {
passed++;
SKELDEV_TEST_DEBUG("%s Passed", name);
}
}
if (teardown)
teardown();
total++;
}
int
test_rawdev_skeldev(void)
{
testsuite_setup();
SKELDEV_TEST_RUN(NULL, NULL, test_rawdev_count);
SKELDEV_TEST_RUN(NULL, NULL, test_rawdev_get_dev_id);
SKELDEV_TEST_RUN(NULL, NULL, test_rawdev_socket_id);
SKELDEV_TEST_RUN(NULL, NULL, test_rawdev_info_get);
SKELDEV_TEST_RUN(NULL, NULL, test_rawdev_configure);
SKELDEV_TEST_RUN(test_rawdev_configure, NULL,
test_rawdev_queue_default_conf_get);
SKELDEV_TEST_RUN(test_rawdev_configure, NULL, test_rawdev_queue_setup);
SKELDEV_TEST_RUN(NULL, NULL, test_rawdev_queue_count);
SKELDEV_TEST_RUN(test_rawdev_queue_setup, NULL,
test_rawdev_queue_release);
SKELDEV_TEST_RUN(NULL, NULL, test_rawdev_attr_set_get);
SKELDEV_TEST_RUN(NULL, NULL, test_rawdev_start_stop);
SKELDEV_TEST_RUN(test_rawdev_queue_setup, NULL, test_rawdev_enqdeq);
testsuite_teardown();
SKELDEV_TEST_INFO("Total tests : %d", total);
SKELDEV_TEST_INFO("Passed : %d", passed);
SKELDEV_TEST_INFO("Failed : %d", failed);
SKELDEV_TEST_INFO("Not supported : %d", unsupported);
if (failed)
return -1;
return 0;
};