ebaa070de8
The "-Wimplicit-fallthrough=2" option was introduced into gcc 7.0, it was
enabled when the cross compiler gcc is greater than 7.0, but for the host
side buildtools/pmdinfogen, if the native gcc is older than 7.0, or the
host cc compiler is clang, it should not be enabled.
The fix is to differentiate the host gcc Werror options from the cross gcc.
gcc -Wp,-MD,./.pmdinfogen.o.d.tmp -W -Wall -Wstrict-prototypes
-Wmissing-prototypes -Wmissing-declarations -Wold-style-definition
-Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual
-Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings -Wdeprecated
-Werror -Wimplicit-fallthrough=2 -Dbbb -Wno-format-truncation -g
-I/dpdk/build/include -o pmdinfogen.o -c
~/dpdk/buildtools/pmdinfogen/pmdinfogen.c gcc: error:
unrecognized command line option ‘-Wimplicit-fallthrough=2’
Fixes: ced3e6f8 ("mk: adjust gcc flags for new gcc 7 warnings")
Cc: stable@dpdk.org
Signed-off-by: Gavin Hu <gavin.hu@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Steve Capper <steve.capper@arm.com>
Tested-by: Ali Alnubani <alialnu@mellanox.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
92 lines
2.7 KiB
Makefile
92 lines
2.7 KiB
Makefile
# SPDX-License-Identifier: BSD-3-Clause
|
|
# Copyright(c) 2010-2014 Intel Corporation
|
|
|
|
#
|
|
# toolchain:
|
|
#
|
|
# - define CC, LD, AR, AS, ... (overridden by cmdline value)
|
|
# - define TOOLCHAIN_CFLAGS variable (overridden by cmdline value)
|
|
# - define TOOLCHAIN_LDFLAGS variable (overridden by cmdline value)
|
|
# - define TOOLCHAIN_ASFLAGS variable (overridden by cmdline value)
|
|
#
|
|
|
|
CC = $(CROSS)gcc
|
|
KERNELCC = $(CROSS)gcc
|
|
CPP = $(CROSS)cpp
|
|
# for now, we don't use as but nasm.
|
|
# AS = $(CROSS)as
|
|
AS = nasm
|
|
AR = $(CROSS)ar
|
|
LD = $(CROSS)ld
|
|
OBJCOPY = $(CROSS)objcopy
|
|
OBJDUMP = $(CROSS)objdump
|
|
STRIP = $(CROSS)strip
|
|
READELF = $(CROSS)readelf
|
|
GCOV = $(CROSS)gcov
|
|
|
|
ifeq ("$(origin CC)", "command line")
|
|
HOSTCC = $(CC)
|
|
else
|
|
HOSTCC = gcc
|
|
endif
|
|
HOSTAS = as
|
|
|
|
TOOLCHAIN_ASFLAGS =
|
|
TOOLCHAIN_CFLAGS =
|
|
TOOLCHAIN_LDFLAGS =
|
|
|
|
ifeq ($(CONFIG_RTE_LIBRTE_GCOV),y)
|
|
TOOLCHAIN_CFLAGS += --coverage
|
|
TOOLCHAIN_LDFLAGS += --coverage
|
|
ifeq (,$(findstring -O0,$(EXTRA_CFLAGS)))
|
|
$(warning "EXTRA_CFLAGS doesn't contains -O0, coverage will be inaccurate with optimizations enabled")
|
|
endif
|
|
endif
|
|
|
|
WERROR_FLAGS := -W -Wall -Wstrict-prototypes -Wmissing-prototypes
|
|
WERROR_FLAGS += -Wmissing-declarations -Wold-style-definition -Wpointer-arith
|
|
WERROR_FLAGS += -Wcast-align -Wnested-externs -Wcast-qual
|
|
WERROR_FLAGS += -Wformat-nonliteral -Wformat-security
|
|
WERROR_FLAGS += -Wundef -Wwrite-strings -Wdeprecated
|
|
|
|
ifeq ($(RTE_DEVEL_BUILD),y)
|
|
WERROR_FLAGS += -Werror
|
|
endif
|
|
|
|
# There are many issues reported for strict alignment architectures
|
|
# which are not necessarily fatal. Report as warnings.
|
|
ifeq ($(CONFIG_RTE_ARCH_STRICT_ALIGN),y)
|
|
WERROR_FLAGS += -Wno-error=cast-align
|
|
endif
|
|
|
|
# process cpu flags
|
|
include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk
|
|
|
|
# workaround GCC bug with warning "missing initializer" for "= {0}"
|
|
ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1)
|
|
WERROR_FLAGS += -Wno-missing-field-initializers
|
|
endif
|
|
# workaround GCC bug with warning "may be used uninitialized"
|
|
ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1)
|
|
WERROR_FLAGS += -Wno-uninitialized
|
|
endif
|
|
|
|
HOST_WERROR_FLAGS := $(WERROR_FLAGS)
|
|
|
|
ifeq ($(shell test $(HOST_GCC_VERSION) -gt 70 && echo 1), 1)
|
|
# Tell GCC only to error for switch fallthroughs without a suitable comment
|
|
HOST_WERROR_FLAGS += -Wimplicit-fallthrough=2
|
|
# Ignore errors for snprintf truncation
|
|
HOST_WERROR_FLAGS += -Wno-format-truncation
|
|
endif
|
|
|
|
ifeq ($(shell test $(GCC_VERSION) -gt 70 && echo 1), 1)
|
|
# Tell GCC only to error for switch fallthroughs without a suitable comment
|
|
WERROR_FLAGS += -Wimplicit-fallthrough=2
|
|
# Ignore errors for snprintf truncation
|
|
WERROR_FLAGS += -Wno-format-truncation
|
|
endif
|
|
|
|
export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF
|
|
export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS
|