numam-dpdk/drivers/net/mlx5/mlx5_testpmd.c
Spike Du 0f3ba0d4a8 net/mlx5: fix testpmd quit with available desc threshold
When testpmd quit with mlx5 avail_thresh enabled, a rte timer handler
delays to reconfigure rx queue to re-arm this event. However at the same
time, testpmd is destroying rx queues.
It's never a valid use case for mlx5 avail_thresh. Before testpmd quit,
user should disable avail_thresh configuration to not handle the events.
This is documented in mlx5 driver guide.

To avoid the crash in such use case, check port status, if it is not
RTE_PORT_STARTED, don't process the avail_thresh event.

Fixes: f41a5092e6 ("app/testpmd: add host shaper command")
Cc: stable@dpdk.org

Signed-off-by: Spike Du <spiked@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
2022-11-10 18:15:49 +01:00

597 lines
18 KiB
C

/* SPDX-License-Identifier: BSD-3-Clause
* Copyright 2021 6WIND S.A.
* Copyright 2021 Mellanox Technologies, Ltd
*/
#include <stdint.h>
#include <string.h>
#include <stdlib.h>
#include <unistd.h>
#ifndef RTE_EXEC_ENV_WINDOWS
#include <sys/socket.h>
#include <sys/un.h>
#endif
#include <rte_prefetch.h>
#include <rte_common.h>
#include <rte_branch_prediction.h>
#include <rte_ether.h>
#include <rte_alarm.h>
#include <rte_pmd_mlx5.h>
#include <rte_ethdev.h>
#include "mlx5_testpmd.h"
#include "testpmd.h"
static uint8_t host_shaper_avail_thresh_triggered[RTE_MAX_ETHPORTS];
#define SHAPER_DISABLE_DELAY_US 100000 /* 100ms */
/**
* Disable the host shaper and re-arm available descriptor threshold event.
*
* @param[in] args
* uint32_t integer combining port_id and rxq_id.
*/
static void
mlx5_test_host_shaper_disable(void *args)
{
uint32_t port_rxq_id = (uint32_t)(uintptr_t)args;
uint16_t port_id = port_rxq_id & 0xffff;
uint16_t qid = (port_rxq_id >> 16) & 0xffff;
struct rte_eth_rxq_info qinfo;
struct rte_port *port;
port = &ports[port_id];
if (port->port_status != RTE_PORT_STARTED) {
printf("%s port_status(%d) is incorrect, stop avail_thresh "
"event processing.\n",
__func__, port->port_status);
return;
}
printf("%s disable shaper\n", __func__);
if (rte_eth_rx_queue_info_get(port_id, qid, &qinfo)) {
printf("rx_queue_info_get returns error\n");
return;
}
/* Rearm the available descriptor threshold event. */
if (rte_eth_rx_avail_thresh_set(port_id, qid, qinfo.avail_thresh)) {
printf("config avail_thresh returns error\n");
return;
}
/* Only disable the shaper when avail_thresh_triggered is set. */
if (host_shaper_avail_thresh_triggered[port_id] &&
rte_pmd_mlx5_host_shaper_config(port_id, 0, 0))
printf("%s disable shaper returns error\n", __func__);
}
void
mlx5_test_avail_thresh_event_handler(uint16_t port_id, uint16_t rxq_id)
{
struct rte_eth_dev_info dev_info;
uint32_t port_rxq_id = port_id | (rxq_id << 16);
/* Ensure it's MLX5 port. */
if (rte_eth_dev_info_get(port_id, &dev_info) != 0 ||
(strncmp(dev_info.driver_name, "mlx5", 4) != 0))
return;
rte_eal_alarm_set(SHAPER_DISABLE_DELAY_US,
mlx5_test_host_shaper_disable,
(void *)(uintptr_t)port_rxq_id);
printf("%s port_id:%u rxq_id:%u\n", __func__, port_id, rxq_id);
}
/**
* Configure host shaper's avail_thresh_triggered and current rate.
*
* @param[in] avail_thresh_triggered
* Disable/enable avail_thresh_triggered.
* @param[in] rate
* Configure current host shaper rate.
* @return
* On success, returns 0.
* On failure, returns < 0.
*/
static int
mlx5_test_set_port_host_shaper(uint16_t port_id, uint16_t avail_thresh_triggered, uint8_t rate)
{
struct rte_eth_link link;
bool port_id_valid = false;
uint16_t pid;
int ret;
RTE_ETH_FOREACH_DEV(pid)
if (port_id == pid) {
port_id_valid = true;
break;
}
if (!port_id_valid)
return -EINVAL;
ret = rte_eth_link_get_nowait(port_id, &link);
if (ret < 0)
return ret;
host_shaper_avail_thresh_triggered[port_id] = avail_thresh_triggered ? 1 : 0;
if (!avail_thresh_triggered) {
ret = rte_pmd_mlx5_host_shaper_config(port_id, 0,
RTE_BIT32(MLX5_HOST_SHAPER_FLAG_AVAIL_THRESH_TRIGGERED));
} else {
ret = rte_pmd_mlx5_host_shaper_config(port_id, 1,
RTE_BIT32(MLX5_HOST_SHAPER_FLAG_AVAIL_THRESH_TRIGGERED));
}
if (ret)
return ret;
ret = rte_pmd_mlx5_host_shaper_config(port_id, rate, 0);
if (ret)
return ret;
return 0;
}
#ifndef RTE_EXEC_ENV_WINDOWS
static const char*
mlx5_test_get_socket_path(char *extend)
{
if (strstr(extend, "socket=") == extend) {
const char *socket_path = strchr(extend, '=') + 1;
TESTPMD_LOG(DEBUG, "MLX5 socket path is %s\n", socket_path);
return socket_path;
}
TESTPMD_LOG(ERR, "Failed to extract a valid socket path from %s\n",
extend);
return NULL;
}
static int
mlx5_test_extend_devargs(char *identifier, char *extend)
{
struct sockaddr_un un = {
.sun_family = AF_UNIX,
};
int cmd_fd;
int pd_handle;
struct iovec iov = {
.iov_base = &pd_handle,
.iov_len = sizeof(int),
};
union {
char buf[CMSG_SPACE(sizeof(int))];
struct cmsghdr align;
} control;
struct msghdr msgh = {
.msg_iov = NULL,
.msg_iovlen = 0,
};
struct cmsghdr *cmsg;
const char *path = mlx5_test_get_socket_path(extend + 1);
size_t len = 1;
int socket_fd;
int ret;
if (path == NULL) {
TESTPMD_LOG(ERR, "Invalid devargs extension is specified\n");
return -1;
}
/* Initialize IPC channel. */
socket_fd = socket(AF_UNIX, SOCK_SEQPACKET, 0);
if (socket_fd < 0) {
TESTPMD_LOG(ERR, "Failed to create unix socket: %s\n",
strerror(errno));
return -1;
}
rte_strlcpy(un.sun_path, path, sizeof(un.sun_path));
if (connect(socket_fd, (struct sockaddr *)&un, sizeof(un)) < 0) {
TESTPMD_LOG(ERR, "Failed to connect %s: %s\n", un.sun_path,
strerror(errno));
close(socket_fd);
return -1;
}
/* Send the request message. */
do {
ret = sendmsg(socket_fd, &msgh, 0);
} while (ret < 0 && errno == EINTR);
if (ret < 0) {
TESTPMD_LOG(ERR, "Failed to send request to (%s): %s\n", path,
strerror(errno));
close(socket_fd);
return -1;
}
msgh.msg_iov = &iov;
msgh.msg_iovlen = 1;
msgh.msg_control = control.buf;
msgh.msg_controllen = sizeof(control.buf);
do {
ret = recvmsg(socket_fd, &msgh, 0);
} while (ret < 0);
if (ret != sizeof(int) || (msgh.msg_flags & (MSG_TRUNC | MSG_CTRUNC))) {
TESTPMD_LOG(ERR, "truncated msg");
close(socket_fd);
return -1;
}
/* Translate the FD. */
cmsg = CMSG_FIRSTHDR(&msgh);
if (cmsg == NULL || cmsg->cmsg_len != CMSG_LEN(sizeof(int)) ||
cmsg->cmsg_level != SOL_SOCKET || cmsg->cmsg_type != SCM_RIGHTS) {
TESTPMD_LOG(ERR, "Fail to get FD using SCM_RIGHTS mechanism\n");
close(socket_fd);
unlink(un.sun_path);
return -1;
}
memcpy(&cmd_fd, CMSG_DATA(cmsg), sizeof(int));
TESTPMD_LOG(DEBUG, "Command FD (%d) and PD handle (%d) "
"are successfully imported from remote process\n",
cmd_fd, pd_handle);
/* Cleanup IPC channel. */
close(socket_fd);
/* Calculate the new length of devargs string. */
len += snprintf(NULL, 0, ",cmd_fd=%d,pd_handle=%d", cmd_fd, pd_handle);
/* Extend the devargs string. */
snprintf(extend, len, ",cmd_fd=%d,pd_handle=%d", cmd_fd, pd_handle);
TESTPMD_LOG(DEBUG, "Attach port with extra devargs %s\n", identifier);
return 0;
}
static bool
is_delimiter_path_spaces(char *extend)
{
while (*extend != '\0') {
if (*extend != ' ')
return true;
extend++;
}
return false;
}
/*
* Extend devargs list with "cmd_fd" and "pd_handle" coming from external
* process. It happens only in this format:
* testpmd> mlx5 port attach (identifier) socket=<socket path>
* all "(identifier) socket=<socket path>" is in the same string pointed
* by the input parameter 'identifier'.
*
* @param identifier
* Identifier of port attach command line.
*/
static void
mlx5_test_attach_port_extend_devargs(char *identifier)
{
char *extend;
if (identifier == NULL) {
fprintf(stderr, "Invalid parameters are specified\n");
return;
}
extend = strchr(identifier, ' ');
if (extend != NULL && is_delimiter_path_spaces(extend) &&
mlx5_test_extend_devargs(identifier, extend) < 0) {
TESTPMD_LOG(ERR, "Failed to extend devargs for port %s\n",
identifier);
return;
}
attach_port(identifier);
}
#endif
/* *** SET HOST_SHAPER FOR A PORT *** */
struct cmd_port_host_shaper_result {
cmdline_fixed_string_t mlx5;
cmdline_fixed_string_t set;
cmdline_fixed_string_t port;
uint16_t port_num;
cmdline_fixed_string_t host_shaper;
cmdline_fixed_string_t avail_thresh_triggered;
uint16_t fr;
cmdline_fixed_string_t rate;
uint8_t rate_num;
};
static void cmd_port_host_shaper_parsed(void *parsed_result,
__rte_unused struct cmdline *cl,
__rte_unused void *data)
{
struct cmd_port_host_shaper_result *res = parsed_result;
int ret = 0;
if ((strcmp(res->mlx5, "mlx5") == 0) &&
(strcmp(res->set, "set") == 0) &&
(strcmp(res->port, "port") == 0) &&
(strcmp(res->host_shaper, "host_shaper") == 0) &&
(strcmp(res->avail_thresh_triggered, "avail_thresh_triggered") == 0) &&
(strcmp(res->rate, "rate") == 0))
ret = mlx5_test_set_port_host_shaper(res->port_num, res->fr,
res->rate_num);
if (ret < 0)
printf("cmd_port_host_shaper error: (%s)\n", strerror(-ret));
}
static cmdline_parse_token_string_t cmd_port_host_shaper_mlx5 =
TOKEN_STRING_INITIALIZER(struct cmd_port_host_shaper_result,
mlx5, "mlx5");
static cmdline_parse_token_string_t cmd_port_host_shaper_set =
TOKEN_STRING_INITIALIZER(struct cmd_port_host_shaper_result,
set, "set");
static cmdline_parse_token_string_t cmd_port_host_shaper_port =
TOKEN_STRING_INITIALIZER(struct cmd_port_host_shaper_result,
port, "port");
static cmdline_parse_token_num_t cmd_port_host_shaper_portnum =
TOKEN_NUM_INITIALIZER(struct cmd_port_host_shaper_result,
port_num, RTE_UINT16);
static cmdline_parse_token_string_t cmd_port_host_shaper_host_shaper =
TOKEN_STRING_INITIALIZER(struct cmd_port_host_shaper_result,
host_shaper, "host_shaper");
static cmdline_parse_token_string_t cmd_port_host_shaper_avail_thresh_triggered =
TOKEN_STRING_INITIALIZER(struct cmd_port_host_shaper_result,
avail_thresh_triggered, "avail_thresh_triggered");
static cmdline_parse_token_num_t cmd_port_host_shaper_fr =
TOKEN_NUM_INITIALIZER(struct cmd_port_host_shaper_result,
fr, RTE_UINT16);
static cmdline_parse_token_string_t cmd_port_host_shaper_rate =
TOKEN_STRING_INITIALIZER(struct cmd_port_host_shaper_result,
rate, "rate");
static cmdline_parse_token_num_t cmd_port_host_shaper_rate_num =
TOKEN_NUM_INITIALIZER(struct cmd_port_host_shaper_result,
rate_num, RTE_UINT8);
static cmdline_parse_inst_t mlx5_test_cmd_port_host_shaper = {
.f = cmd_port_host_shaper_parsed,
.data = (void *)0,
.help_str = "mlx5 set port <port_id> host_shaper avail_thresh_triggered <0|1> "
"rate <rate_num>: Set HOST_SHAPER avail_thresh_triggered and rate with port_id",
.tokens = {
(void *)&cmd_port_host_shaper_mlx5,
(void *)&cmd_port_host_shaper_set,
(void *)&cmd_port_host_shaper_port,
(void *)&cmd_port_host_shaper_portnum,
(void *)&cmd_port_host_shaper_host_shaper,
(void *)&cmd_port_host_shaper_avail_thresh_triggered,
(void *)&cmd_port_host_shaper_fr,
(void *)&cmd_port_host_shaper_rate,
(void *)&cmd_port_host_shaper_rate_num,
NULL,
}
};
#ifndef RTE_EXEC_ENV_WINDOWS
/* *** attach a specified port *** */
struct mlx5_cmd_operate_attach_port_result {
cmdline_fixed_string_t mlx5;
cmdline_fixed_string_t port;
cmdline_fixed_string_t keyword;
cmdline_multi_string_t identifier;
};
static void mlx5_cmd_operate_attach_port_parsed(void *parsed_result,
__rte_unused struct cmdline *cl,
__rte_unused void *data)
{
struct mlx5_cmd_operate_attach_port_result *res = parsed_result;
if (!strcmp(res->keyword, "attach"))
mlx5_test_attach_port_extend_devargs(res->identifier);
else
fprintf(stderr, "Unknown parameter\n");
}
static cmdline_parse_token_string_t mlx5_cmd_operate_attach_port_mlx5 =
TOKEN_STRING_INITIALIZER(struct mlx5_cmd_operate_attach_port_result,
mlx5, "mlx5");
static cmdline_parse_token_string_t mlx5_cmd_operate_attach_port_port =
TOKEN_STRING_INITIALIZER(struct mlx5_cmd_operate_attach_port_result,
port, "port");
static cmdline_parse_token_string_t mlx5_cmd_operate_attach_port_keyword =
TOKEN_STRING_INITIALIZER(struct mlx5_cmd_operate_attach_port_result,
keyword, "attach");
static cmdline_parse_token_string_t mlx5_cmd_operate_attach_port_identifier =
TOKEN_STRING_INITIALIZER(struct mlx5_cmd_operate_attach_port_result,
identifier, TOKEN_STRING_MULTI);
static cmdline_parse_inst_t mlx5_cmd_operate_attach_port = {
.f = mlx5_cmd_operate_attach_port_parsed,
.data = NULL,
.help_str = "mlx5 port attach <identifier> socket=<path>: "
"(identifier: pci address or virtual dev name"
", path (optional): socket path to get cmd FD and PD handle)",
.tokens = {
(void *)&mlx5_cmd_operate_attach_port_mlx5,
(void *)&mlx5_cmd_operate_attach_port_port,
(void *)&mlx5_cmd_operate_attach_port_keyword,
(void *)&mlx5_cmd_operate_attach_port_identifier,
NULL,
},
};
#endif
/* Map HW queue index to rte queue index. */
struct mlx5_cmd_map_ext_rxq {
cmdline_fixed_string_t mlx5;
cmdline_fixed_string_t port;
portid_t port_id;
cmdline_fixed_string_t ext_rxq;
cmdline_fixed_string_t map;
uint16_t sw_queue_id;
uint32_t hw_queue_id;
};
cmdline_parse_token_string_t mlx5_cmd_map_ext_rxq_mlx5 =
TOKEN_STRING_INITIALIZER(struct mlx5_cmd_map_ext_rxq, mlx5, "mlx5");
cmdline_parse_token_string_t mlx5_cmd_map_ext_rxq_port =
TOKEN_STRING_INITIALIZER(struct mlx5_cmd_map_ext_rxq, port, "port");
cmdline_parse_token_num_t mlx5_cmd_map_ext_rxq_port_id =
TOKEN_NUM_INITIALIZER(struct mlx5_cmd_map_ext_rxq, port_id, RTE_UINT16);
cmdline_parse_token_string_t mlx5_cmd_map_ext_rxq_ext_rxq =
TOKEN_STRING_INITIALIZER(struct mlx5_cmd_map_ext_rxq, ext_rxq,
"ext_rxq");
cmdline_parse_token_string_t mlx5_cmd_map_ext_rxq_map =
TOKEN_STRING_INITIALIZER(struct mlx5_cmd_map_ext_rxq, map, "map");
cmdline_parse_token_num_t mlx5_cmd_map_ext_rxq_sw_queue_id =
TOKEN_NUM_INITIALIZER(struct mlx5_cmd_map_ext_rxq, sw_queue_id,
RTE_UINT16);
cmdline_parse_token_num_t mlx5_cmd_map_ext_rxq_hw_queue_id =
TOKEN_NUM_INITIALIZER(struct mlx5_cmd_map_ext_rxq, hw_queue_id,
RTE_UINT32);
static void
mlx5_cmd_map_ext_rxq_parsed(void *parsed_result,
__rte_unused struct cmdline *cl,
__rte_unused void *data)
{
struct mlx5_cmd_map_ext_rxq *res = parsed_result;
int ret;
if (port_id_is_invalid(res->port_id, ENABLED_WARN))
return;
ret = rte_pmd_mlx5_external_rx_queue_id_map(res->port_id,
res->sw_queue_id,
res->hw_queue_id);
switch (ret) {
case 0:
break;
case -EINVAL:
fprintf(stderr, "invalid ethdev index (%u), out of range\n",
res->sw_queue_id);
break;
case -ENODEV:
fprintf(stderr, "invalid port_id %u\n", res->port_id);
break;
case -ENOTSUP:
fprintf(stderr, "function not implemented or supported\n");
break;
case -EEXIST:
fprintf(stderr, "mapping with index %u already exists\n",
res->sw_queue_id);
break;
default:
fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
}
}
cmdline_parse_inst_t mlx5_cmd_map_ext_rxq = {
.f = mlx5_cmd_map_ext_rxq_parsed,
.data = NULL,
.help_str = "mlx5 port <port_id> ext_rxq map <sw_queue_id> <hw_queue_id>",
.tokens = {
(void *)&mlx5_cmd_map_ext_rxq_mlx5,
(void *)&mlx5_cmd_map_ext_rxq_port,
(void *)&mlx5_cmd_map_ext_rxq_port_id,
(void *)&mlx5_cmd_map_ext_rxq_ext_rxq,
(void *)&mlx5_cmd_map_ext_rxq_map,
(void *)&mlx5_cmd_map_ext_rxq_sw_queue_id,
(void *)&mlx5_cmd_map_ext_rxq_hw_queue_id,
NULL,
}
};
/* Unmap HW queue index to rte queue index. */
struct mlx5_cmd_unmap_ext_rxq {
cmdline_fixed_string_t mlx5;
cmdline_fixed_string_t port;
portid_t port_id;
cmdline_fixed_string_t ext_rxq;
cmdline_fixed_string_t unmap;
uint16_t queue_id;
};
cmdline_parse_token_string_t mlx5_cmd_unmap_ext_rxq_mlx5 =
TOKEN_STRING_INITIALIZER(struct mlx5_cmd_unmap_ext_rxq, mlx5, "mlx5");
cmdline_parse_token_string_t mlx5_cmd_unmap_ext_rxq_port =
TOKEN_STRING_INITIALIZER(struct mlx5_cmd_unmap_ext_rxq, port, "port");
cmdline_parse_token_num_t mlx5_cmd_unmap_ext_rxq_port_id =
TOKEN_NUM_INITIALIZER(struct mlx5_cmd_unmap_ext_rxq, port_id,
RTE_UINT16);
cmdline_parse_token_string_t mlx5_cmd_unmap_ext_rxq_ext_rxq =
TOKEN_STRING_INITIALIZER(struct mlx5_cmd_unmap_ext_rxq, ext_rxq,
"ext_rxq");
cmdline_parse_token_string_t mlx5_cmd_unmap_ext_rxq_unmap =
TOKEN_STRING_INITIALIZER(struct mlx5_cmd_unmap_ext_rxq, unmap, "unmap");
cmdline_parse_token_num_t mlx5_cmd_unmap_ext_rxq_queue_id =
TOKEN_NUM_INITIALIZER(struct mlx5_cmd_unmap_ext_rxq, queue_id,
RTE_UINT16);
static void
mlx5_cmd_unmap_ext_rxq_parsed(void *parsed_result,
__rte_unused struct cmdline *cl,
__rte_unused void *data)
{
struct mlx5_cmd_unmap_ext_rxq *res = parsed_result;
int ret;
if (port_id_is_invalid(res->port_id, ENABLED_WARN))
return;
ret = rte_pmd_mlx5_external_rx_queue_id_unmap(res->port_id,
res->queue_id);
switch (ret) {
case 0:
break;
case -EINVAL:
fprintf(stderr, "invalid rte_flow index (%u), "
"out of range, doesn't exist or still referenced\n",
res->queue_id);
break;
case -ENODEV:
fprintf(stderr, "invalid port_id %u\n", res->port_id);
break;
case -ENOTSUP:
fprintf(stderr, "function not implemented or supported\n");
break;
default:
fprintf(stderr, "programming error: (%s)\n", strerror(-ret));
}
}
cmdline_parse_inst_t mlx5_cmd_unmap_ext_rxq = {
.f = mlx5_cmd_unmap_ext_rxq_parsed,
.data = NULL,
.help_str = "mlx5 port <port_id> ext_rxq unmap <queue_id>",
.tokens = {
(void *)&mlx5_cmd_unmap_ext_rxq_mlx5,
(void *)&mlx5_cmd_unmap_ext_rxq_port,
(void *)&mlx5_cmd_unmap_ext_rxq_port_id,
(void *)&mlx5_cmd_unmap_ext_rxq_ext_rxq,
(void *)&mlx5_cmd_unmap_ext_rxq_unmap,
(void *)&mlx5_cmd_unmap_ext_rxq_queue_id,
NULL,
}
};
static struct testpmd_driver_commands mlx5_driver_cmds = {
.commands = {
{
.ctx = &mlx5_test_cmd_port_host_shaper,
.help = "mlx5 set port (port_id) host_shaper avail_thresh_triggered (on|off)"
"rate (rate_num):\n"
" Set HOST_SHAPER avail_thresh_triggered and rate with port_id\n\n",
},
#ifndef RTE_EXEC_ENV_WINDOWS
{
.ctx = &mlx5_cmd_operate_attach_port,
.help = "mlx5 port attach (ident) socket=(path)\n"
" Attach physical or virtual dev by pci address or virtual device name "
"and add \"cmd_fd\" and \"pd_handle\" devargs before attaching\n\n",
},
#endif
{
.ctx = &mlx5_cmd_map_ext_rxq,
.help = "mlx5 port (port_id) ext_rxq map (sw_queue_id) (hw_queue_id)\n"
" Map HW queue index (32-bit) to ethdev"
" queue index (16-bit) for external RxQ\n\n",
},
{
.ctx = &mlx5_cmd_unmap_ext_rxq,
.help = "mlx5 port (port_id) ext_rxq unmap (sw_queue_id)\n"
" Unmap external Rx queue ethdev index mapping\n\n",
},
{
.ctx = NULL,
},
}
};
TESTPMD_ADD_DRIVER_COMMANDS(mlx5_driver_cmds);