d/numam-spdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
aa1d039836
numam-spdk/mk/spdk.common.mk

491 lines
14 KiB
Makefile
Raw Normal View History

SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
#
# BSD LICENSE
#
Remove year from copyright headers. Also add a space between Copyright and (c). The copyright year can be determined using git metadata. Also remove the duplicated "All rights reserved." - every instance of this line already has a corresponding "All rights reserved" immediately below it, except for examples/ioat/kperf/kmod/dma_perf.c, where I have added it manually. Performed using this command: git ls-files | xargs sed -i -e 's/Copyright(c) \(.*\) Intel Corporation. All rights reserved./Copyright (c) Intel Corporation./' Change-Id: I3779f404966800709024eb1eb66a50068af2716c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-01-26 17:47:22 +00:00
# Copyright (c) Intel Corporation.
build: fix compiler options for ppc64le ppc64le does not support compiler option march=native but instead uses mcpu Change-Id: I2dd14b1acf003e8229e9c9392c4c0606e2c15af8 Signed-off-by: Jonas Pfefferle <jpf@zurich.ibm.com> Reviewed-on: https://review.gerrithub.io/383725 Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-10-10 12:02:46 +00:00
# Copyright (c) 2017, IBM Corporation.
make: Correct ppc detection gcc -dumpmachine may provide the following output: ppc64le-redhat-linux To detect PowerPC system we should check for both "powerpc%" and "ppc%" strings Signed-off-by: Alexey Marchuk <alexeymar@mellanox.com> Change-Id: Ifb5afe743797177afa4f1b541a0c8ccaf4befbda Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6378 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Community-CI: Mellanox Build Bot
2021-02-10 16:54:24 +00:00
# Copyright (c) 2019, 2021 Mellanox Corporation.
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
# All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
#
# * Redistributions of source code must retain the above copyright
# notice, this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in
# the documentation and/or other materials provided with the
# distribution.
# * Neither the name of Intel Corporation nor the names of its
# contributors may be used to endorse or promote products derived
# from this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#
configure: use mk/config.mk instead of CONFIG.local We have hairy configuration method. First configure script uses CONFIG, environment and arguments to produce CONFIG.local and config.h then makefile uses CONFIG, environment and CONFIG.local to produce config.h again. First time config.h can't be generated reliably as config.h target in Makefile is passing MAKEFLAGS and they are unknown at configuration phase. Lets remove this mess by producing final mk/config.mk file and get rid of CONFIG.local. This will also generate full build configuration in one file instead scattering them in CONFIG and CONFIG.local. In next patch scripts/genconfig.py can be removed. Change-Id: I5696813312edff7e493207f7aa8569234a365ec0 Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-on: https://review.gerrithub.io/426364 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2018-09-21 14:32:36 +00:00
ifeq ($(wildcard $(SPDK_ROOT_DIR)/mk/config.mk),)
make: always fail if mk/config.mk doesn't exist. We previously were failing for all make targets except for clean if the mk/config.mk file didn't exist, but we should also be failing to perform make clean if we don't have this file. It turns out you end up erroring out in the next line anyways. Also, if you make that include optional, make still fails because we don't have any kind of environment specified and spdk.common.mk depends on that variable being defined. There may be some benefit to being able to run make clean if we don't have a valid configuration file, but right now, there are a lot of things that depend on the configuration file, such as which environment file to make or clean and which directories need cleaned. Change-Id: I2a9c1e982c01ba76b67b153ee7336402300b76b0 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/466346 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Paul Luse <paul.e.luse@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-08-26 22:28:24 +00:00
$(error mk/config.mk: file not found. Please run configure before make)
configure: use mk/config.mk instead of CONFIG.local We have hairy configuration method. First configure script uses CONFIG, environment and arguments to produce CONFIG.local and config.h then makefile uses CONFIG, environment and CONFIG.local to produce config.h again. First time config.h can't be generated reliably as config.h target in Makefile is passing MAKEFLAGS and they are unknown at configuration phase. Lets remove this mess by producing final mk/config.mk file and get rid of CONFIG.local. This will also generate full build configuration in one file instead scattering them in CONFIG and CONFIG.local. In next patch scripts/genconfig.py can be removed. Change-Id: I5696813312edff7e493207f7aa8569234a365ec0 Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-on: https://review.gerrithub.io/426364 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2018-09-21 14:32:36 +00:00
endif
include $(SPDK_ROOT_DIR)/mk/config.mk
configure: save used environment variables in separate file currently they are saved in mk/config.mk but this break config.h Change-Id: Iecb037f1aea91469f4093724cdf100dc122d21a5 Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-on: https://review.gerrithub.io/427222 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-09-27 19:40:04 +00:00
-include $(SPDK_ROOT_DIR)/mk/cc.flags.mk
build: add CONFIG_LTO to enable link-time optimization Change-Id: I9546d715b8d2ca3ebf46183bdbaa58e8aa921d95 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-03-24 20:27:53 +00:00
-include $(SPDK_ROOT_DIR)/mk/cc.mk
build: let 'make V=1' be equivalent to 'make Q=' The V= syntax is more familiar from other build systems, so allow both. Change-Id: I024cf4a338c2fe10bef482311a1703bf5fb2a38e Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-19 17:48:24 +00:00
ifneq ($(V),1)
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
Q ?= @
build: let 'make V=1' be equivalent to 'make Q=' The V= syntax is more familiar from other build systems, so allow both. Change-Id: I024cf4a338c2fe10bef482311a1703bf5fb2a38e Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-19 17:48:24 +00:00
endif
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
S ?= $(notdir $(CURDIR))
build: add 'make install' rule For now, this only installs libraries and headers; we will need to consider which binaries should be installed and what they should be named before we add them to the install rule. Change-Id: I78dc8631f793d0df88cd884b0ac66406df9e4427 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/387637 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-11-15 17:36:36 +00:00
DESTDIR?=
mk: support file extension for executables Some platforms require that a specific file extension is used for executables. Append $(EXEEXT) to $(APP) definitions to accommodate this. The name EXEEXT has been chosen for consistency with automake which uses the same variable for the same purpose. Add extensions for generated files used by Windows to the 'clean' target (.obj, .lib, .pdb) and add output files to .gitignore. Tested using a cross compiler that forces a .exe suffix and verifying that all LINK messages include the correct suffix and that a second call to make does nothing (showing that the targets match the generated executables). Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: Ief012f6294d2f94b23c8b4f9747e21a0dfb91e96 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6494 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2021-02-23 08:58:06 +00:00
EXEEXT?=
build: add 'make install' rule For now, this only installs libraries and headers; we will need to consider which binaries should be installed and what they should be named before we add them to the install rule. Change-Id: I78dc8631f793d0df88cd884b0ac66406df9e4427 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/387637 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-11-15 17:36:36 +00:00
ifneq ($(prefix),)
CONFIG_PREFIX=$(prefix)
endif
app/spdk_tgt: add 'make install' rule Change-Id: Ib76031972824231ed824e53a327c7d648842ad6a Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/403224 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-03-08 22:29:44 +00:00
bindir?=$(CONFIG_PREFIX)/bin
build: add 'make install' rule For now, this only installs libraries and headers; we will need to consider which binaries should be installed and what they should be named before we add them to the install rule. Change-Id: I78dc8631f793d0df88cd884b0ac66406df9e4427 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/387637 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-11-15 17:36:36 +00:00
libdir?=$(CONFIG_PREFIX)/lib
includedir?=$(CONFIG_PREFIX)/include
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
ifeq ($(MAKECMDGOALS),)
MAKECMDGOALS=$(.DEFAULT_GOAL)
endif
build: detect OS via cc -dumpmachine Rather than running 'uname', which returns information about the build system, use the C compiler's -dumpmachine option, which outputs the target triplet, which looks something like "x86_64-unknown-linux-gnu". This enables us to detect the correct target OS when the configured $(CC) is a cross compiler. Change-Id: I5659dd5b091094cc8e408a6c6f4e7f64a65e9070 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/385166 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-10-31 22:48:32 +00:00
TARGET_TRIPLET := $(shell $(CC) -dumpmachine)
TARGET_TRIPLET_WORDS := $(subst -, ,$(TARGET_TRIPLET))
ifneq ($(filter linux%,$(TARGET_TRIPLET_WORDS)),)
OS = Linux
endif
ifneq ($(filter freebsd%,$(TARGET_TRIPLET_WORDS)),)
OS = FreeBSD
endif
mk: adjust options for mingw cross compilation Check compiler target triplet for the strings 'windows' or 'mingw' and set OS to Windows. If found, adjust basic parameters: Set EXEEXT to indicate executables have .exe suffix. Exclude 'relro' and 'now' flags which are not recognised on Windows. Exclude 'noexecstack' flag which is not recognised on Windows. Exclude -pthread flag because Windows doesn't have POSIX threads. Include libssp.a to support stack-protector and _FORTIFY_SOURCE. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: I94a45d3123ebc81f5529006fa07b05da897e5866 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6574 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2021-02-25 18:31:54 +00:00
ifneq ($(filter mingw% windows%,$(TARGET_TRIPLET_WORDS)),)
OS = Windows
endif
build: add OS to spdk.common.mk This will add different flags, src files, etc. for FreeBSD. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I4f2d664cf42d01745318f241ce9558dccf148b7d
2015-09-25 16:12:35 +00:00
build: Allow the user to set target architecture in configure Change-Id: I7f2a1464c0c8872e5e7856a830aaf7ea8cdf4e81 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463013 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2019-07-23 17:52:47 +00:00
TARGET_ARCHITECTURE ?= $(CONFIG_ARCH)
build: detect architecture via cc -dumpmachine Similar to commit 98f84e6255 ("build: detect OS via cc -dumpmachine"), we can use the C compiler's -dumpmachine output to detect the target CPU architecture rather than relying on the build machine's uname output. This helps enable correct CPU detection when $(CC) is a cross compiler. Change-Id: I72c34294a1ff7dd9df3aa45dfc319e5b81d51f85 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/385709 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-11-03 22:55:55 +00:00
TARGET_MACHINE := $(firstword $(TARGET_TRIPLET_WORDS))
build: fix compiler options for ppc64le ppc64le does not support compiler option march=native but instead uses mcpu Change-Id: I2dd14b1acf003e8229e9c9392c4c0606e2c15af8 Signed-off-by: Jonas Pfefferle <jpf@zurich.ibm.com> Reviewed-on: https://review.gerrithub.io/383725 Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-10-10 12:02:46 +00:00
mk: adjust options for mingw cross compilation Check compiler target triplet for the strings 'windows' or 'mingw' and set OS to Windows. If found, adjust basic parameters: Set EXEEXT to indicate executables have .exe suffix. Exclude 'relro' and 'now' flags which are not recognised on Windows. Exclude 'noexecstack' flag which is not recognised on Windows. Exclude -pthread flag because Windows doesn't have POSIX threads. Include libssp.a to support stack-protector and _FORTIFY_SOURCE. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: I94a45d3123ebc81f5529006fa07b05da897e5866 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6574 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2021-02-25 18:31:54 +00:00
ifeq ($(OS),Windows)
EXEEXT = .exe
endif
build: fix compiler options for ppc64le ppc64le does not support compiler option march=native but instead uses mcpu Change-Id: I2dd14b1acf003e8229e9c9392c4c0606e2c15af8 Signed-off-by: Jonas Pfefferle <jpf@zurich.ibm.com> Reviewed-on: https://review.gerrithub.io/383725 Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-10-10 12:02:46 +00:00
COMMON_CFLAGS = -g $(C_OPT) -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wmissing-declarations -fno-strict-aliasing -I$(SPDK_ROOT_DIR)/include
make: Correct ppc detection gcc -dumpmachine may provide the following output: ppc64le-redhat-linux To detect PowerPC system we should check for both "powerpc%" and "ppc%" strings Signed-off-by: Alexey Marchuk <alexeymar@mellanox.com> Change-Id: Ifb5afe743797177afa4f1b541a0c8ccaf4befbda Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6378 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Community-CI: Mellanox Build Bot
2021-02-10 16:54:24 +00:00
ifneq ($(filter powerpc% ppc%,$(TARGET_MACHINE)),)
make: Allow users to specify the target build architecture make TARGET_ARCHICTECTURE=broadwell Change-Id: I868c2f5c203dfc1a4e6cf48c39b391e174d5d33b Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/461601 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-07-12 10:51:04 +00:00
COMMON_CFLAGS += -mcpu=$(TARGET_ARCHITECTURE)
else ifeq ($(TARGET_MACHINE),aarch64)
build: Allow TARGET_ARCHITECTURE to be specified on ARM Previously it always forced armv8-a+crc. Now it only does that if not otherwise specified. Change-Id: I7c1d73fca8e89779cc3e8780a38f52975488d97a Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/463012 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2019-07-23 17:13:19 +00:00
COMMON_CFLAGS += -march=$(TARGET_ARCHITECTURE)
lib/ftl: fix PAGE_SIZE for AArch64 Not only 4KB page size is supported on AArch64. The most common is 4KB and 64KB. 16KB is supported too. We can get it by "getconf PAGESIZE". Change-Id: I6f09741372d35e868228528d976fe3b5a65ff96c Signed-off-by: Richael Zhuang <richael.zhuang@arm.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/454447 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-05-14 10:26:55 +00:00
COMMON_CFLAGS += -DPAGE_SIZE=$(shell getconf PAGESIZE)
make: Allow users to specify the target build architecture make TARGET_ARCHICTECTURE=broadwell Change-Id: I868c2f5c203dfc1a4e6cf48c39b391e174d5d33b Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/461601 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2019-07-12 10:51:04 +00:00
else
COMMON_CFLAGS += -march=$(TARGET_ARCHITECTURE)
Update spdk crc32c.c with ARM CRC32 intrinsics Implement spdk_crc32c_update() with ARM CRC32 intrinsics. Change-Id: I1daf7f21012aab02290f88a65bbae619eedf5087 Signed-off-by: Richael Zhuang <richael.zhuang@arm.com> Reviewed-on: https://review.gerrithub.io/c/437218 Reviewed-by: Ziye Yang <optimistyzy@gmail.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2018-12-13 07:24:48 +00:00
endif
config: make -Werror optional and off by default Allow end users to build the code even if, for example, warnings are added with new compilers versions. -Werror is still enforced for automated builds. Change-Id: I567009d55cf5b941c452bd41d09f75d03b037209 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-03-18 17:40:34 +00:00
ifeq ($(CONFIG_WERROR), y)
COMMON_CFLAGS += -Werror
endif
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
build: add CONFIG_LTO to enable link-time optimization Change-Id: I9546d715b8d2ca3ebf46183bdbaa58e8aa921d95 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-03-24 20:27:53 +00:00
ifeq ($(CONFIG_LTO),y)
COMMON_CFLAGS += -flto
LDFLAGS += -flto
endif
build: Add support for profile guided optimization ./configure --enable-pgo-capture make <Run sample workload> ./configure --enable-pgo-use make Output has used the captured profile from the sample workload to improve performance. Change-Id: Ie5690b873b05d11b4ea6c7d44021e564d4e4d170 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/c/444110 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2019-02-11 18:19:32 +00:00
ifeq ($(CONFIG_PGO_CAPTURE),y)
COMMON_CFLAGS += -fprofile-generate=$(SPDK_ROOT_DIR)/build/pgo
LDFLAGS += -fprofile-generate=$(SPDK_ROOT_DIR)/build/pgo
endif
ifeq ($(CONFIG_PGO_USE),y)
COMMON_CFLAGS += -fprofile-use=$(SPDK_ROOT_DIR)/build/pgo
LDFLAGS += -fprofile-use=$(SPDK_ROOT_DIR)/build/pgo
endif
configure: add --enable-cet to build with CET support Intel Control-flow Enforcement Technology (CET) is a processor feature that blocks return/jump-oriented programming (ROP) attacks. It is currently only supported on Tiger Lake client processors, but will be available on other processors in the future. CET requires toolchain support. gcc8 does support it. For now, this will opt-in only at least until the technology is available on server processors. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I8c7f882eeeaed26484c31dc0d67d5cc42baeaa2d Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5921 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2021-01-14 11:06:33 +00:00
ifeq ($(CONFIG_CET),y)
COMMON_CFLAGS += -fcf-protection
LDFLAGS += -fcf-protection
endif
util: add vsprintf version of spdk_sprintf_alloc -Wformat-nonliteral needs to be disabled since clang triggers it on the call to vsnprintf() now that it is nested two calls deep. Change-Id: I228b9d099cfc2b65181941cbb4798b7f8eae3baa Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-11-18 17:48:24 +00:00
COMMON_CFLAGS += -Wformat -Wformat-security
build: enable printf format warnings Some of these are covered under -Wall, but add them all just to be clear. Change-Id: I63104be4bf58becd19a4c30a4d275d2c24c6761d Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-10-12 23:38:29 +00:00
nvme/perf: add Linux libaio benchmarking support This allows comparing the Linux kernel driver's performance to the SPDK user-mode NVMe driver. Change-Id: I71c70163a4133c2f237c8c57b3c698ec261455f5 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-10-19 22:57:04 +00:00
COMMON_CFLAGS += -D_GNU_SOURCE
build: always build with -fPIC This allows the same objects to be linked into static and shared libraries and allows the creation of position-independent executables with the static libraries. Change-Id: I119949c3644c02a83e414227615dcc2d8f896286 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-10-13 17:11:38 +00:00
# Always build PIC code so that objects can be used in shared libs and position-independent executables
COMMON_CFLAGS += -fPIC
build: enable -fstack-protector Change-Id: I2ba23c48ee8b9048022cff6cc861e990fd1ff570 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-10-13 17:04:04 +00:00
# Enable stack buffer overflow checking
COMMON_CFLAGS += -fstack-protector
mk: workaround for mingw stack-protector bug Add -mstack-protector-guard=global to work around GCC bug 86832, where -fstack-protector will attempt to use native TLS, but mingw only supports emulated TLS. This causes a segmentation violation at the start of any function protected by stack-protector. The issue exists in GCC versions prior to 8.3. Enable -mstack-protector-guard=global which uses a global variable for the guard value. This is the behaviour with the fix, so there is no downside to enabling it for all versions of GCC on Windows. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: I85bc831043585071b0d8b0a3dd637b8d9ff26dab Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6575 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2021-02-25 18:35:28 +00:00
ifeq ($(OS).$(CC_TYPE),Windows.gcc)
# Workaround for gcc bug 86832 - invalid TLS usage
COMMON_CFLAGS += -mstack-protector-guard=global
endif
build: enable -fno-common This flag prevents the compiler from merging multiple tenative global variable declarations (e.g. 'int i;' without an assignment) into a single copy later. In the default (-fcommon) mode, this allows multiple definitions of an uninitialized global variable to be linked into a single program without any warnings. Change-Id: I0339012a7164dccd311ab1f62d11111d24529fbd Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2017-01-19 17:21:20 +00:00
# Prevent accidental multiple definitions of global variables
COMMON_CFLAGS += -fno-common
build: enable full RELRO in LDFLAGS This forces the ELF loader to resolve all relocations immediately at load time rather than allowing lazy binding. Therefore the loader can make the GOT (global offset table) read-only once the relocations are complete during the loading process. Change-Id: I89a878d1060ce79d58c5be7700d8b122a33a8ceb Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-10-12 23:17:37 +00:00
# Enable full RELRO - no lazy relocation (resolve everything at load time).
# This allows the GOT to be made read-only early in the loading process.
mk: adjust options for mingw cross compilation Check compiler target triplet for the strings 'windows' or 'mingw' and set OS to Windows. If found, adjust basic parameters: Set EXEEXT to indicate executables have .exe suffix. Exclude 'relro' and 'now' flags which are not recognised on Windows. Exclude 'noexecstack' flag which is not recognised on Windows. Exclude -pthread flag because Windows doesn't have POSIX threads. Include libssp.a to support stack-protector and _FORTIFY_SOURCE. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: I94a45d3123ebc81f5529006fa07b05da897e5866 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6574 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2021-02-25 18:31:54 +00:00
ifneq ($(OS),Windows)
build: enable full RELRO in LDFLAGS This forces the ELF loader to resolve all relocations immediately at load time rather than allowing lazy binding. Therefore the loader can make the GOT (global offset table) read-only once the relocations are complete during the loading process. Change-Id: I89a878d1060ce79d58c5be7700d8b122a33a8ceb Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-10-12 23:17:37 +00:00
LDFLAGS += -Wl,-z,relro,-z,now
mk: adjust options for mingw cross compilation Check compiler target triplet for the strings 'windows' or 'mingw' and set OS to Windows. If found, adjust basic parameters: Set EXEEXT to indicate executables have .exe suffix. Exclude 'relro' and 'now' flags which are not recognised on Windows. Exclude 'noexecstack' flag which is not recognised on Windows. Exclude -pthread flag because Windows doesn't have POSIX threads. Include libssp.a to support stack-protector and _FORTIFY_SOURCE. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: I94a45d3123ebc81f5529006fa07b05da897e5866 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6574 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2021-02-25 18:31:54 +00:00
endif
build: enable full RELRO in LDFLAGS This forces the ELF loader to resolve all relocations immediately at load time rather than allowing lazy binding. Therefore the loader can make the GOT (global offset table) read-only once the relocations are complete during the loading process. Change-Id: I89a878d1060ce79d58c5be7700d8b122a33a8ceb Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-10-12 23:17:37 +00:00
build: enable noexecstack Modern toolchains already enable noexecstack by default, but set it explicitly just to be sure. Change-Id: I2866220db5a5ed0bb6e78a4e83763839ea3b93b0 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-10-12 23:35:31 +00:00
# Make the stack non-executable.
# This is the default in most environments, but it doesn't hurt to set it explicitly.
mk: adjust options for mingw cross compilation Check compiler target triplet for the strings 'windows' or 'mingw' and set OS to Windows. If found, adjust basic parameters: Set EXEEXT to indicate executables have .exe suffix. Exclude 'relro' and 'now' flags which are not recognised on Windows. Exclude 'noexecstack' flag which is not recognised on Windows. Exclude -pthread flag because Windows doesn't have POSIX threads. Include libssp.a to support stack-protector and _FORTIFY_SOURCE. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: I94a45d3123ebc81f5529006fa07b05da897e5866 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6574 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2021-02-25 18:31:54 +00:00
ifneq ($(OS),Windows)
build: enable noexecstack Modern toolchains already enable noexecstack by default, but set it explicitly just to be sure. Change-Id: I2866220db5a5ed0bb6e78a4e83763839ea3b93b0 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-10-12 23:35:31 +00:00
LDFLAGS += -Wl,-z,noexecstack
mk: adjust options for mingw cross compilation Check compiler target triplet for the strings 'windows' or 'mingw' and set OS to Windows. If found, adjust basic parameters: Set EXEEXT to indicate executables have .exe suffix. Exclude 'relro' and 'now' flags which are not recognised on Windows. Exclude 'noexecstack' flag which is not recognised on Windows. Exclude -pthread flag because Windows doesn't have POSIX threads. Include libssp.a to support stack-protector and _FORTIFY_SOURCE. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: I94a45d3123ebc81f5529006fa07b05da897e5866 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6574 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2021-02-25 18:31:54 +00:00
endif
build: enable noexecstack Modern toolchains already enable noexecstack by default, but set it explicitly just to be sure. Change-Id: I2866220db5a5ed0bb6e78a4e83763839ea3b93b0 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-10-12 23:35:31 +00:00
build: use linker specified by the LD env variable Modifed scripts/detect_cc.sh to take additional parameter specifing the linker to use. Default to LLD on FreeBSD systems. Change-Id: Idf97e9676a144028c0803d272ae6f0e903b0dd1f Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-on: https://review.gerrithub.io/c/438801 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-02 12:47:47 +00:00
# Specify the linker to use
build: Don't pass -fuse-ld to compiler if LD_TYPE not set Don't assume detection of LD by the detect_cc script suceeded. If it wasn't detected then LD_TYPE won't be set and the gcc command line option shouldn't be set either. Compilation will fail if -fuse-ld is specified with no value. Change-Id: If4a0ede8cdc5a71cf92de2beb0f24e4650f58f3a Signed-off-by: Jonathan Richardson <jonathan.richardson@broadcom.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/447376 Reviewed-by: Scott Branden <sbranden@gmail.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2019-02-21 01:12:43 +00:00
ifneq ($(LD_TYPE),)
build: use linker specified by the LD env variable Modifed scripts/detect_cc.sh to take additional parameter specifing the linker to use. Default to LLD on FreeBSD systems. Change-Id: Idf97e9676a144028c0803d272ae6f0e903b0dd1f Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-on: https://review.gerrithub.io/c/438801 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-02 12:47:47 +00:00
LDFLAGS += -fuse-ld=$(LD_TYPE)
build: Don't pass -fuse-ld to compiler if LD_TYPE not set Don't assume detection of LD by the detect_cc script suceeded. If it wasn't detected then LD_TYPE won't be set and the gcc command line option shouldn't be set either. Compilation will fail if -fuse-ld is specified with no value. Change-Id: If4a0ede8cdc5a71cf92de2beb0f24e4650f58f3a Signed-off-by: Jonathan Richardson <jonathan.richardson@broadcom.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/447376 Reviewed-by: Scott Branden <sbranden@gmail.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2019-02-21 01:12:43 +00:00
endif
build: use linker specified by the LD env variable Modifed scripts/detect_cc.sh to take additional parameter specifing the linker to use. Default to LLD on FreeBSD systems. Change-Id: Idf97e9676a144028c0803d272ae6f0e903b0dd1f Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com> Reviewed-on: https://review.gerrithub.io/c/438801 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-02 12:47:47 +00:00
build: initialize SYS_LIBS in spdk.common.mk There are cases where spdk.common.mk can get included more than once in a Makefile. So avoid duplication in SYS_LIBS by initializing it before appending text to it. The duplication was harmless but a bit annoying. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Idf081f973e15a9ab6ec9211b9a3cbf02c736c7a0 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5676 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2020-12-22 20:11:58 +00:00
SYS_LIBS =
build: add OS to spdk.common.mk This will add different flags, src files, etc. for FreeBSD. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I4f2d664cf42d01745318f241ce9558dccf148b7d
2015-09-25 16:12:35 +00:00
ifeq ($(OS),FreeBSD)
make: move FreeBSD linker change to SYS_LIBS This linker flag is really more important when dealing with external SO files such as libuuid. It shoudl follow those linked options around instead of all of our internal dependencies. This series is aimed at fixing github issue 434 Change-Id: Iee65470632b5ab0adeb361005edc894e05c43ea4 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/425441 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-12 21:37:52 +00:00
SYS_LIBS += -L/usr/local/lib
build: add OS to spdk.common.mk This will add different flags, src files, etc. for FreeBSD. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I4f2d664cf42d01745318f241ce9558dccf148b7d
2015-09-25 16:12:35 +00:00
COMMON_CFLAGS += -I/usr/local/include
endif
bdev/pmem: change all NVML strings to PMDK NVML (Non Volatile Memory Library) changed its name to PMDK (Persistent Memory Development Kit), so make the necessary changes to the SPDK repository. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Id07a87eafb4e9a3099603030c58c0e927bafa608 Reviewed-on: https://review.gerrithub.io/406256 Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2018-04-03 23:07:39 +00:00
# Attach only if PMDK lib specified with configure
ifneq ($(CONFIG_PMDK_DIR),)
LIBS += -L$(CONFIG_PMDK_DIR)/src/nondebug
COMMON_CFLAGS += -I$(CONFIG_PMDK_DIR)/src/include
bdev_pmem: initial implementation of persistent memory bdev Use SPDK bdev subsystem to allow basic IO to pmem pool using pmemblk_* calls. New pmem bdev can be constructed using RPC call construct_pmem_bdev PMEM_FILE Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Change-Id: If5ca94161fe53644b8fccd3b77de5479da1b2e55 Reviewed-on: https://review.gerrithub.io/376973 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-09-29 08:49:51 +00:00
endif
vpp: dynamic compilation with VPP Enable dynamic compilation of SPDK with VPP. Change-Id: I9f5f7223625cbebec0d6209b5a2ce6bdcc1a04bf Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com> Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-on: https://review.gerrithub.io/401825 Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-03-13 14:42:45 +00:00
make: simplify rdma dependency linking Instead of adding the linker flags just before application compilation on linux, move that linking to earlier in the process. This will also be useful for the shared library build. This series is aimed at fixing github issue 434 Change-Id: I84bcc6bd922ddb6e48adb2dfe0b154700773cf27 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/425435 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-12 19:43:47 +00:00
ifeq ($(CONFIG_RDMA),y)
SYS_LIBS += -libverbs -lrdmacm
endif
mk/spdk.common.mk: Add the uring library support if configured. Signed-off-by: Ziye Yang <ziye.yang@intel.com> Change-Id: Idb0e10743270867a451c7a34d0346bf22a7389be Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3231 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2020-07-07 14:03:40 +00:00
ifeq ($(CONFIG_URING),y)
SYS_LIBS += -luring
ifneq ($(strip $(CONFIG_URING_PATH)),)
CFLAGS += -I$(CONFIG_URING_PATH)
LDFLAGS += -L$(CONFIG_URING_PATH)
endif
endif
Commit updating intel-ipsec-mb submodule. Additionally: In release 1.0 intel-ipsec-mb module moved main header (intel-ipsec-mb.h) from main directory of the project to the /lib directory. This change aims to address that and allow for a successful build. Change-Id: Idd6ec90396166c94ca492ef1d2038331adbbc36c Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7976 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com>
2021-05-20 13:22:52 +00:00
IPSEC_MB_DIR=$(SPDK_ROOT_DIR)/intel-ipsec-mb/lib
ipsec_mb: use EXTRA_CFLAGS to point DPDK to intel-ipsec-mb submodule This allows us to remove the requirement to install intel-ipsec-mb to system directories. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I579655a98b515cf148b7cd17823a9bb541ea6ad7 Reviewed-on: https://review.gerrithub.io/c/440785 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2019-01-13 20:28:21 +00:00
spdk: Add ISA-L support with related crc32 function In SPDK, we will build isa-l with no shared option and then integrate it into SPDK. And we do not need to install isal in the system libaries. Note: ocf build in autobuild.sh now needs to build include/spdk/config.h before building the ocf library, to ensure that header is available in a clean build environment. Change-Id: I3f0ce6932b386de17a77cf5bfdfd738b22417e2d Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Signed-off-by: paul luse <paul.e.luse@intel.com> Signed-off-by: Jim Harris <james.r.harris@intel.com> Reviewed-on: https://review.gerrithub.io/c/441279 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Chunyang Hui <chunyang.hui@intel.com>
2019-01-21 09:05:59 +00:00
ISAL_DIR=$(SPDK_ROOT_DIR)/isa-l
ifeq ($(CONFIG_ISAL), y)
SYS_LIBS += -L$(ISAL_DIR)/.libs -lisal
COMMON_CFLAGS += -I$(ISAL_DIR)/..
endif
libvfio-user: include libvfio-user as a submodule with SPDK Also add a CONFIG_VFIO_USER config flag, it's enabled by default. Change-Id: I18b44c024a264516a60f743d5c366a4c7f7c6785 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5000 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2020-11-02 15:32:20 +00:00
ifeq ($(CONFIG_VFIO_USER), y)
mk/libvfio-user: support --with-vfio-user=/usr/path Users may not use SPDK libvfio-user submodule, so add a library path for this case, users can still just use '--with-vfio-user' without adding the path, for this case a submodule default path will be used. Change-Id: Ib0dd82ab6910056ff21b5b2d373c0d16916162c6 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6471 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Thanos Makatos <thanos.makatos@nutanix.com>
2021-02-19 09:31:12 +00:00
ifneq ($(CONFIG_VFIO_USER_DIR),)
VFIO_USER_DIR=$(CONFIG_VFIO_USER_DIR)
else
VFIO_USER_DIR=$(SPDK_ROOT_DIR)/libvfio-user
endif
libvfio-user: include libvfio-user as a submodule with SPDK Also add a CONFIG_VFIO_USER config flag, it's enabled by default. Change-Id: I18b44c024a264516a60f743d5c366a4c7f7c6785 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5000 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2020-11-02 15:32:20 +00:00
ifeq ($(CONFIG_DEBUG), y)
VFIO_USER_BUILD_TYPE=dbg
else
VFIO_USER_BUILD_TYPE=release
endif
VFIO_USER_INSTALL_DIR=$(VFIO_USER_DIR)/build
VFIO_USER_INCLUDE_DIR=$(VFIO_USER_INSTALL_DIR)/usr/local/include
mk/libvfio-user: use the install directory for the link path Previously the libvfio-user didn't install the static library to the install directory, with that fix in libvfio-user, we can use the install directory now. Change-Id: I3f232395a6dc3bf6d7d3937b245eb10c4b6a0e26 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6470 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2021-02-19 09:04:45 +00:00
VFIO_USER_LIBRARY_DIR=$(VFIO_USER_INSTALL_DIR)/usr/local/lib64
build: also look for vfio-user libraries in 'lib' At least on some Ubuntu distributions, default vfio-user install puts libs in usr/local/lib instead of usr/local/lib64. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ib312d8ca9b4ce9e858a9a9e76525fc8afd48ced5 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7825 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: <dongx.yi@intel.com>
2021-05-10 15:12:00 +00:00
ifeq (,$(wildcard $(VFIO_USER_LIBRARY_DIR)/.))
# Some Linux distros use lib instead of lib64
# for default installations
VFIO_USER_LIBRARY_DIR=$(VFIO_USER_INSTALL_DIR)/usr/local/lib
endif
libvfio-user: include libvfio-user as a submodule with SPDK Also add a CONFIG_VFIO_USER config flag, it's enabled by default. Change-Id: I18b44c024a264516a60f743d5c366a4c7f7c6785 Signed-off-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/5000 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2020-11-02 15:32:20 +00:00
CFLAGS += -I$(VFIO_USER_INCLUDE_DIR)
LDFLAGS += -L$(VFIO_USER_LIBRARY_DIR)
SYS_LIBS += -Wl,-Bstatic -lvfio-user -Wl,-Bdynamic -ljson-c
endif
nvmf:Add RNIC HBA userspace library for FreeBSD Change-Id: I7d929e7520007f29511299442f791038f7a4ce1d Signed-off-by: John Meneghini <johnm@netapp.com> Reviewed-on: https://review.gerrithub.io/409539 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-04-25 20:00:44 +00:00
#Attach only if FreeBSD and RDMA is specified with configure
ifeq ($(OS),FreeBSD)
ifeq ($(CONFIG_RDMA),y)
# Mellanox - MLX4 HBA Userspace Library
ifneq ("$(wildcard /usr/lib/libmlx4.*)","")
mk: Add all external libs to sys_libs This allows us to better distinguish between external and internal libs. This series is aimed at fixing github issue 434 Change-Id: I2ed141f909e7c4a800df02061007b0d23da25380 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/425434 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-12 19:39:09 +00:00
SYS_LIBS += -lmlx4
nvmf:Add RNIC HBA userspace library for FreeBSD Change-Id: I7d929e7520007f29511299442f791038f7a4ce1d Signed-off-by: John Meneghini <johnm@netapp.com> Reviewed-on: https://review.gerrithub.io/409539 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-04-25 20:00:44 +00:00
endif
# Mellanox - MLX5 HBA Userspace Library
ifneq ("$(wildcard /usr/lib/libmlx5.*)","")
mk: Add all external libs to sys_libs This allows us to better distinguish between external and internal libs. This series is aimed at fixing github issue 434 Change-Id: I2ed141f909e7c4a800df02061007b0d23da25380 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/425434 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-12 19:39:09 +00:00
SYS_LIBS += -lmlx5
nvmf:Add RNIC HBA userspace library for FreeBSD Change-Id: I7d929e7520007f29511299442f791038f7a4ce1d Signed-off-by: John Meneghini <johnm@netapp.com> Reviewed-on: https://review.gerrithub.io/409539 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-04-25 20:00:44 +00:00
endif
# Chelsio HBA Userspace Library
ifneq ("$(wildcard /usr/lib/libcxgb4.*)","")
mk: Add all external libs to sys_libs This allows us to better distinguish between external and internal libs. This series is aimed at fixing github issue 434 Change-Id: I2ed141f909e7c4a800df02061007b0d23da25380 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/425434 Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-12 19:39:09 +00:00
SYS_LIBS += -lcxgb4
nvmf:Add RNIC HBA userspace library for FreeBSD Change-Id: I7d929e7520007f29511299442f791038f7a4ce1d Signed-off-by: John Meneghini <johnm@netapp.com> Reviewed-on: https://review.gerrithub.io/409539 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-04-25 20:00:44 +00:00
endif
endif
endif
build: add ufc to SYS_LIBS in spdk.common.mk This avoids duplicating it in several different Makefiles. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I85f4886ec6744c23639d24867e2c68757dfeba32 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4484 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Anil Veerabhadrappa <anil.veerabhadrappa@broadcom.com> Reviewed-by: <dongx.yi@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Ziye Yang <ziye.yang@intel.com>
2020-09-30 15:31:38 +00:00
ifeq ($(CONFIG_FC),y)
ifneq ($(strip $(CONFIG_FC_PATH)),)
SYS_LIBS += -L$(CONFIG_FC_PATH)
endif
SYS_LIBS += -lufc
endif
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
ifeq ($(CONFIG_DEBUG), y)
mk: remove -fno-omit-frame-pointer for release builds This can make profiling more challenging, but should not affect debugging since we still have unwind tables. Keep the C_OPT in COMMON_CFLAGS to allow a way to still add compile flags, even though C_OPT is now not set by default. This results in a 11% performance improvement on a bdevperf microbenchmark using null bdevs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: If16fef6e94a73dfca6c10d3b7f158a12dfc70b53 Reviewed-on: https://review.gerrithub.io/393823 Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-01-05 18:26:19 +00:00
COMMON_CFLAGS += -DDEBUG -O0 -fno-omit-frame-pointer
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
else
build: disable assert() when building for release Set -DNDEBUG to make assert() a no-op. Since nvme_assert() is just an alias for assert(), this controls compilation of nvme_assert as well. Change-Id: Ie9d0c7fea007eff030179c1b54865adc3dcaf6b6 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-24 20:38:59 +00:00
COMMON_CFLAGS += -DNDEBUG -O2
build: enable _FORTIFY_SOURCE=2 for release builds Change-Id: I61a0700c2ee6e22cdde6e6cc8c491a1e52043136 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-10-12 23:31:01 +00:00
# Enable _FORTIFY_SOURCE checks - these only work when optimizations are enabled.
build: undefine _FORTIFY_SOURCE before setting it Some compilers automatically define _FORTIFY_SOURCE to a different value, so undefine it before setting it on the compiler command line. Change-Id: Id662953bd4466b99d0fe9bd5bb96f9fc335ff9a8 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-12-22 17:15:06 +00:00
COMMON_CFLAGS += -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
endif
build: add CONFIG_COVERAGE code coverage option Collect coverage information for use with gcov. Coverage is disabled on FreeBSD because the current version of clang provided by FreeBSD can't successfully link with -ftest-coverage enabled (the compiler-rt support libs are too old). Change-Id: Icc444936caa852bfb9a02b37223209319a27a770 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-10-22 18:26:21 +00:00
ifeq ($(CONFIG_COVERAGE), y)
COMMON_CFLAGS += -fprofile-arcs -ftest-coverage
LDFLAGS += -fprofile-arcs -ftest-coverage
ifeq ($(OS),FreeBSD)
LDFLAGS += --coverage
endif
endif
mk: add support for mingw builds MinGW builds require a thin layer above the standard libraries to provide POSIX functionality that is missing on Windows. Add support for building this. MinGW cross builds are experimental and work is ongoing to integrate them into the CI and test environment. Including the changes at this stage is being done to facilitate that process. The layer has been arranged in the same way as DPDK and is accessed as an external build using ./configure --with-wpdk=<dir>. Support has also been added for using a default ./wpdk in preparation for reaching the required level of stability. The help text for ./configure indicates that support for --with-wpdk is experimental. Further details and instructions can be found at https://wpdk.github.io. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: Iff0f705789f19fb193dcb3c9090c3e90613a8d9a Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6589 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2021-03-03 09:48:43 +00:00
ifeq ($(OS),Windows)
WPDK_DIR = $(abspath $(CONFIG_WPDK_DIR))
COMMON_CFLAGS += -I$(WPDK_DIR)/include/wpdk -I$(WPDK_DIR)/include
LDFLAGS += -L$(WPDK_DIR)/lib
ifeq ($(CONFIG_SHARED),y)
SYS_LIBS += -lwpdk
else
SYS_LIBS += $(WPDK_DIR)/lib/libwpdk.a
endif
SYS_LIBS += -ldbghelp -lkernel32 -lsetupapi -lws2_32 -lrpcrt4 -liphlpapi
endif
env: Make the environment library configurable. This allows users to swap out SPDK's third party libraries for an implementation based on their own framework. Change-Id: Ia0b7384ce5e31acba5ad0d7002dec9e95b759c52 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-10 17:28:20 +00:00
include $(CONFIG_ENV)/env.mk
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
config: rename CONFIG_ADDRESS_SANITIZER to CONFIG_ASAN This is shorter and matches the more commonly-used name. Change-Id: I6af862de90e5cf8a7c27161f1ee9bb5a1164bec6 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-11-30 18:17:15 +00:00
ifeq ($(CONFIG_ASAN),y)
build: add config option to use Address Sanitizer Change-Id: I98bf4ab1c58a90341c2a8529de4537fb0250f00d Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-04 19:46:09 +00:00
COMMON_CFLAGS += -fsanitize=address
LDFLAGS += -fsanitize=address
endif
config: add option to turn on UBSan Change-Id: Ifb6b86db530d78bffdc28112f5fe1bdfcba6249c Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-11-30 18:16:25 +00:00
ifeq ($(CONFIG_UBSAN),y)
COMMON_CFLAGS += -fsanitize=undefined
LDFLAGS += -fsanitize=undefined
endif
Add thread sanitizer to configure options Change-Id: Ibeab0bc70bb59da4ebb8bd175642f5f549f1d273 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.gerrithub.io/362425 Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2017-05-24 22:00:54 +00:00
ifeq ($(CONFIG_TSAN),y)
COMMON_CFLAGS += -fsanitize=thread
LDFLAGS += -fsanitize=thread
endif
test/nvmf: fuzz nvmf target using LLVM's libFuzzer LLVM provides libFuzzer which does coverage-guided fuzzing of a library or application under test. For SPDK, we can use this as a new and better way to generate random commands to the SPDK nvmf target. By default, libFuzzer provides the main() and your source file just provides the function called by LLVM for each iteration of random data. But this doesn't really work for SPDK since we need to start the app framework and the nvmf target. So we specify -fsanitizer=fuzzer-no-link, explicitly specify the location of the fuzzer_no_main library and then call LLVMFuzzerRunDriver to start the fuzzing process once we are ready. Since this is all coverage-guided, we invoke the fuzzer inside the nvmf target application. So this patch creates a new target application called 'llvm_nvme_fuzz'. One core is needed to run the nvmf target, then we spawn a pthread to run the fuzzer against it. Currently there are two fuzzers defined. Fuzzer 0 does random testing of admin commands. Fuzzer 1 is focused solely on GET_LOG_PAGE and fuzzes a smaller subset of the bytes in the spdk_nvme_cmd. Additional fuzzers can be added in the future for other commands, testing I/O queues, data payloads, etc. You do need to specify CC and CXX when running configure, as well as specify the location of the special clang_rt.fuzz_no_main library. The path of that library is dependent on your clang version and architecture. If using clang-12 on x86_64 platform, it will look like: CC=clang-12 CXX=clang++-12 ./configure --with-fuzzer= \ /usr/lib/llvm-12/lib/clang/12.0.0/lib/linux/libclang_rt.fuzzer_no_main-x86_64.a Then just do the following to demonstrate the fuzzer tool. make test/nvmf/target/llvm_nvme_fuzz.sh --time=60 --fuzzer=0 Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Iee0997501893ac284a3947a1db7a155c5ceb7849 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/10038 Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2021-10-15 21:54:52 +00:00
ifeq ($(CONFIG_FUZZER),y)
COMMON_CFLAGS += -fsanitize=fuzzer-no-link
LDFLAGS += -fsanitize=fuzzer-no-link
SYS_LIBS += $(CONFIG_FUZZER_LIB)
endif
build/rpc: Add git sha1 to SPDK version macro Retrieve git sha1 during SPKD build, add sha1 to SPDK_VERSION_STRING macro and to spdk_get_version RPC method This might be useful for issues reporting/investigation Change-Id: I2bfed752839036bf914b546066ed4d23ef4c99b8 Signed-off-by: Alexey Marchuk <alexeymar@mellanox.com> Signed-off-by: Sasha Kotchubievsky <sashakot@mellanox.com> Signed-off-by: Evgeniy Kochetov <evgeniik@mellanox.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/474004 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2019-11-12 14:00:53 +00:00
SPDK_GIT_COMMIT := $(shell git rev-parse --short HEAD 2>/dev/null)
ifneq (, $(SPDK_GIT_COMMIT))
COMMON_CFLAGS += -DSPDK_GIT_COMMIT=$(SPDK_GIT_COMMIT)
endif
mk: adjust options for mingw cross compilation Check compiler target triplet for the strings 'windows' or 'mingw' and set OS to Windows. If found, adjust basic parameters: Set EXEEXT to indicate executables have .exe suffix. Exclude 'relro' and 'now' flags which are not recognised on Windows. Exclude 'noexecstack' flag which is not recognised on Windows. Exclude -pthread flag because Windows doesn't have POSIX threads. Include libssp.a to support stack-protector and _FORTIFY_SOURCE. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: I94a45d3123ebc81f5529006fa07b05da897e5866 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6574 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2021-02-25 18:31:54 +00:00
ifneq ($(OS),Windows)
build: replace -lpthread with -pthread This is the standard way to add multithreading support and handles platform-specific requirements for pthread library name, #defines, etc. Also include -pthread in CFLAGS, since it affects preprocessor definitions. Change-Id: I94b436c7ef482ae3320b7937f4f64b51e5d57032 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-06-22 16:26:54 +00:00
COMMON_CFLAGS += -pthread
build: fix missing pthread dependency for syslibs pc SYS_LIBS var is used to generate Lib.private section of spdk_syslibs.pc lack of pthread can result in linking issue when spdk's *.pc are used please note that usage of -lpthread and -pthread is not consisent within system wide pc files Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com> Change-Id: I2dd327371d5621ea12f1e2f7abdfe6b7aa6602eb Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7253 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Maciej Szulik <maciej.szulik@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Community-CI: Mellanox Build Bot
2021-04-06 12:59:49 +00:00
SYS_LIBS += -pthread
mk: adjust options for mingw cross compilation Check compiler target triplet for the strings 'windows' or 'mingw' and set OS to Windows. If found, adjust basic parameters: Set EXEEXT to indicate executables have .exe suffix. Exclude 'relro' and 'now' flags which are not recognised on Windows. Exclude 'noexecstack' flag which is not recognised on Windows. Exclude -pthread flag because Windows doesn't have POSIX threads. Include libssp.a to support stack-protector and _FORTIFY_SOURCE. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: I94a45d3123ebc81f5529006fa07b05da897e5866 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6574 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2021-02-25 18:31:54 +00:00
endif
build: move -lrt to a new SYS_LIBS variable On some platforms, librt may be a static library, so linker command line order matters. Create a new Makefile variable, SYS_LIBS, which is added to the end of all link commands and move -lrt there. Change-Id: Ie28ebd91a255097bf33cbcf9f0f74f7177a0b142 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-06-23 16:29:22 +00:00
idxd: Add the kernel idxd support This patch is used to add the kernel idxd support. Without this patch, we can use userspace idxd driver under accel_engine library (module/accel/idxd/accel_engine). With this patch, we can also kernel idxd driver under the accel_engine library. Our approach is implementing a wrapper library to use IDXD device by leveraging the kernel DSA driver in SPDK idxd library (lib/idxd). Then users can leverage the RPC later to configure how to use the DSA device by user space driver or kernel driver. In this patch, our approach is to use the idxd-config library to export the WQs (Working Queues) exported by the kernel. Signed-off-by: Ziye Yang <ziye.yang@intel.com> Change-Id: I3a25a4fe0327bd626bf6883dfbe54437d3209e51 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7331 Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2021-03-31 10:09:42 +00:00
ifeq ($(CONFIG_IDXD_KERNEL),y)
SYS_LIBS += -laccel-config
endif
env: Make the environment library configurable. This allows users to swap out SPDK's third party libraries for an implementation based on their own framework. Change-Id: Ia0b7384ce5e31acba5ad0d7002dec9e95b759c52 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-10 17:28:20 +00:00
CFLAGS += $(COMMON_CFLAGS) -Wno-pointer-sign -Wstrict-prototypes -Wold-style-definition -std=gnu99
make: specify C++ standard version in CXXFLAGS The standard is now specified explicitly. The chosen standard, c++11, is the latest supported by gcc-4.8.5, which is the oldest compiler still in use on some systems (centos 7). Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com> Change-Id: I7ba84278b28e6d96f43b52014c358a74902188b9 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9597 Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2021-09-23 15:54:41 +00:00
CXXFLAGS += $(COMMON_CFLAGS) -std=c++11
env: Make the environment library configurable. This allows users to swap out SPDK's third party libraries for an implementation based on their own framework. Change-Id: Ia0b7384ce5e31acba5ad0d7002dec9e95b759c52 Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-08-10 17:28:20 +00:00
build: move -lrt to a new SYS_LIBS variable On some platforms, librt may be a static library, so linker command line order matters. Create a new Makefile variable, SYS_LIBS, which is added to the end of all link commands and move -lrt there. Change-Id: Ie28ebd91a255097bf33cbcf9f0f74f7177a0b142 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-06-23 16:29:22 +00:00
SYS_LIBS += -lrt
lvol: Logical volume implementation Change-Id: Ia96ae78ff9530d953181ac5f7255a38f3c8ec430 Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Signed-off-by: Maciej Szwed <maciej.szwed@intel.com> Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Reviewed-on: https://review.gerrithub.io/375392 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-09-14 14:53:36 +00:00
SYS_LIBS += -luuid
build: add -lcrypto (OpenSSL) to SYS_LIBS This is already required to build the shared library and iSCSI components; simplify these Makefiles by adding -lcrypto to the central SYS_LIBS in mk/spdk.common.mk. Change-Id: I8fdaffbccc1294e24e32559387b0ed99d1deb0ce Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/415351 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2018-06-14 21:50:29 +00:00
SYS_LIBS += -lcrypto
util: add zipf random number generator zipf is a power law probability distribution. When applied to performance testing of block devices, it will select blocks over the full range of LBAs, but will more frequently select lower-numbered LBAs. The theta parameter governs the distribution - higher values of theta will concentrate the distribution on a smaller number of LBAs. Note that fio supports zipf, so adding it to SPDK will enable our perf tools (bdevperf, nvme-perf) to provide similar functionality. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I7df129c9d61996a2070188c6cd9f1fde631ac208 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/7779 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2021-05-06 21:20:45 +00:00
SYS_LIBS += -lm
build: include -lrt and -lpthread in LDFLAGS Simplify the build rules so that common libraries are always linked. Also fix up a couple of -lpciaccess instances that should have been changed to $(PCIACCESS_LIB). Change-Id: I4c50fa3aa59cae013d3385e38fbb830794299f6e Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-06-22 16:23:27 +00:00
Makefile: add -lfuse3 when building with --with-fuse Building with --with-fuse failed: undefined reference to symbols starting with 'fuse_'. Signed-off-by: Richael Zhuang <richael.zhuang@arm.com> Change-Id: Iff4000c4cc609052271979cf8807aba7efd98469 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1424 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2020-03-24 01:58:42 +00:00
ifneq ($(CONFIG_NVME_CUSE)$(CONFIG_FUSE),nn)
lib/nvme: add NVMe character device NVMe character device implementation. This patch adds implementation of IO producer using CUSE library. It allows to create nvme device nodes in linux kernel for controller as well as for namespace and process ioctl requests as usual from linux environment. Both devices (controller and namespaces) are exposed as character devices. To compile NVMe CUSE module use "./configure --with-nvme-cuse". Names for created CUSE devices can be retrieved using spdk_nvme_cuse_get_ctrlr_name() and spdk_nvme_cuse_get_ns_name(). Signed-off-by: Jim Harris <james.r.harris@intel.com> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com> Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Signed-off-by: Maciej Szwed <maciej.szwed@intel.com> Change-Id: I0fc9a9a1ef3c9c2b3112d07c2b4b1f8d49665ee1 Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/466917 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2019-10-24 18:04:33 +00:00
SYS_LIBS += -lfuse3
endif
mk: adjust options for mingw cross compilation Check compiler target triplet for the strings 'windows' or 'mingw' and set OS to Windows. If found, adjust basic parameters: Set EXEEXT to indicate executables have .exe suffix. Exclude 'relro' and 'now' flags which are not recognised on Windows. Exclude 'noexecstack' flag which is not recognised on Windows. Exclude -pthread flag because Windows doesn't have POSIX threads. Include libssp.a to support stack-protector and _FORTIFY_SOURCE. Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: I94a45d3123ebc81f5529006fa07b05da897e5866 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6574 Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2021-02-25 18:31:54 +00:00
ifeq ($(OS).$(CC_TYPE),Windows.gcc)
# Include libssp.a for stack-protector and _FORTIFY_SOURCE
SYS_LIBS += -l:libssp.a
endif
SPDK: Initial check-in Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-09-21 15:52:41 +00:00
MAKEFLAGS += --no-print-directory
CONFIG: rename CONFIG_NVMF to CONFIG_RDMA The NVMf target is being refactored to split the RDMA transport-specific code into its own file. Once this is complete, we should be able to plug in other transports and build the NVMf target without any RDMA dependency if desired. To enable this, change the CONFIG option to RDMA; it still controls whether the whole NVMf target is built for now, but once the RDMA dependency is actually made optional, we will be able to build the generic NVMf target code without libibverbs installed. Change-Id: I8cd90a9aaa85dcefcc9b0f8f2e7b6af21958b2a8 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-07-13 22:34:28 +00:00
C_SRCS += $(C_SRCS-y)
CXX_SRCS += $(CXX_SRCS-y)
trace: add tracepoint library and app Change-Id: I472fb7e7a82e1337c6c06b1d3bb4e8a2a13d884a Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-05-10 23:17:51 +00:00
OBJS = $(C_SRCS:.c=.o) $(CXX_SRCS:.cpp=.o)
build: move $(OBJS) definition to spdk.common.mk Change-Id: I2dd592269ef644cfe73921151b9b174dc255323d Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-10 23:19:07 +00:00
build: simplify dependency generation Modern GCC and Clang versions can generate .d files without needing the complex sequence of sed scripts that we currently use. Also adjust the .o rule so the .d file is regenerated if it gets deleted. Also make the .o depend on all of the Makefile fragments in $(MAKEFILE_LIST) so that it is rebuilt if the Makefile is changed. Change-Id: I44e186c0f34dabfa0cf35db1ffa66b84d9dae87d Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-09 23:40:44 +00:00
DEPFLAGS = -MMD -MP -MF $*.d.tmp
build: factor out common compile and link commands Add common $(COMPILE_C), $(LINK_C), and $(LIB_C) variables that contain the commands to build a .o from a .c, an app from objects and libraries, and a library from objects, respectively. Change-Id: Ie2eaa13156b8bf3db7a4ffa66161382d829aef07 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-10 22:54:04 +00:00
# Compile first input $< (.c) into $@ (.o)
COMPILE_C=\
build: print path in CC, LINK, and LIB messages This makes it somewhat clearer what is happening during parallel builds (make -j). Change-Id: Ibbe8862da7600e784cba64cd333086f1473455ac Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-03-08 17:38:47 +00:00
$(Q)echo " CC $S/$@"; \
build: factor out common compile and link commands Add common $(COMPILE_C), $(LINK_C), and $(LIB_C) variables that contain the commands to build a .o from a .c, an app from objects and libraries, and a library from objects, respectively. Change-Id: Ie2eaa13156b8bf3db7a4ffa66161382d829aef07 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-10 22:54:04 +00:00
$(CC) -o $@ $(DEPFLAGS) $(CFLAGS) -c $< && \
build: only touch output if build is successful Running the 'touch' command unconditionally causes the compile step to return 0 even if the compilation failed. Instead, only run it if the compiler succeeded. Fixes: 4f1634435640 ("make: Update build artifact timestamps for clang support") Change-Id: I46907851fde8bb9e3f73549276e489b6c30ed1fd Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/388324 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: <ed.rodriguez@netapp.com>
2017-11-20 23:18:03 +00:00
mv -f $*.d.tmp $*.d && touch -c $@
build: factor out common compile and link commands Add common $(COMPILE_C), $(LINK_C), and $(LIB_C) variables that contain the commands to build a .o from a .c, an app from objects and libraries, and a library from objects, respectively. Change-Id: Ie2eaa13156b8bf3db7a4ffa66161382d829aef07 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-10 22:54:04 +00:00
trace: add tracepoint library and app Change-Id: I472fb7e7a82e1337c6c06b1d3bb4e8a2a13d884a Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-05-10 23:17:51 +00:00
COMPILE_CXX=\
$(Q)echo " CXX $S/$@"; \
$(CXX) -o $@ $(DEPFLAGS) $(CXXFLAGS) -c $< && \
build: only touch output if build is successful Running the 'touch' command unconditionally causes the compile step to return 0 even if the compilation failed. Instead, only run it if the compiler succeeded. Fixes: 4f1634435640 ("make: Update build artifact timestamps for clang support") Change-Id: I46907851fde8bb9e3f73549276e489b6c30ed1fd Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/388324 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: <ed.rodriguez@netapp.com>
2017-11-20 23:18:03 +00:00
mv -f $*.d.tmp $*.d && touch -c $@
trace: add tracepoint library and app Change-Id: I472fb7e7a82e1337c6c06b1d3bb4e8a2a13d884a Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-05-10 23:17:51 +00:00
mk: don't link env if not needed Some SPDK apps were linked with env even though they didn't use it. Top-level makefiles can now specify SPDK_NO_LINK_ENV=1. Change-Id: I057baa5b620f20d829185025dc2e8efdcfa03fac Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3417 Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Michael Haeuptle <michaelhaeuptle@gmail.com>
2020-07-16 08:37:42 +00:00
ENV_LDFLAGS = $(if $(SPDK_NO_LINK_ENV),,$(ENV_LINKER_ARGS))
build: factor out common compile and link commands Add common $(COMPILE_C), $(LINK_C), and $(LIB_C) variables that contain the commands to build a .o from a .c, an app from objects and libraries, and a library from objects, respectively. Change-Id: Ie2eaa13156b8bf3db7a4ffa66161382d829aef07 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-10 22:54:04 +00:00
# Link $(OBJS) and $(LIBS) into $@ (app)
LINK_C=\
build: Output executables from the app directory to build/bin Automatically place binaries produced from the app directory into build/bin. This matches with the output in build/lib that already exists. Change-Id: I13cd2da71d2f88592e22308fe8a907bf458458b5 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2379 Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2020-05-11 21:15:03 +00:00
$(Q)echo " LINK $(notdir $@)"; \
mk: don't link env if not needed Some SPDK apps were linked with env even though they didn't use it. Top-level makefiles can now specify SPDK_NO_LINK_ENV=1. Change-Id: I057baa5b620f20d829185025dc2e8efdcfa03fac Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3417 Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Michael Haeuptle <michaelhaeuptle@gmail.com>
2020-07-16 08:37:42 +00:00
$(CC) -o $@ $(CPPFLAGS) $(LDFLAGS) $(OBJS) $(LIBS) $(ENV_LDFLAGS) $(SYS_LIBS)
build: factor out common compile and link commands Add common $(COMPILE_C), $(LINK_C), and $(LIB_C) variables that contain the commands to build a .o from a .c, an app from objects and libraries, and a library from objects, respectively. Change-Id: Ie2eaa13156b8bf3db7a4ffa66161382d829aef07 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-10 22:54:04 +00:00
trace: add tracepoint library and app Change-Id: I472fb7e7a82e1337c6c06b1d3bb4e8a2a13d884a Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-05-10 23:17:51 +00:00
LINK_CXX=\
build: Output executables from the app directory to build/bin Automatically place binaries produced from the app directory into build/bin. This matches with the output in build/lib that already exists. Change-Id: I13cd2da71d2f88592e22308fe8a907bf458458b5 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2379 Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2020-05-11 21:15:03 +00:00
$(Q)echo " LINK $(notdir $@)"; \
mk: don't link env if not needed Some SPDK apps were linked with env even though they didn't use it. Top-level makefiles can now specify SPDK_NO_LINK_ENV=1. Change-Id: I057baa5b620f20d829185025dc2e8efdcfa03fac Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3417 Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Michael Haeuptle <michaelhaeuptle@gmail.com>
2020-07-16 08:37:42 +00:00
$(CXX) -o $@ $(CPPFLAGS) $(LDFLAGS) $(OBJS) $(LIBS) $(ENV_LDFLAGS) $(SYS_LIBS)
trace: add tracepoint library and app Change-Id: I472fb7e7a82e1337c6c06b1d3bb4e8a2a13d884a Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-05-10 23:17:51 +00:00
shared_lib: Update shared lib build and install Updates build and install of shared lib to conform with standard naming conventions for shared libraries, including the setting of the lib's soname. Change-Id: Ib46d298ab5f77fd8c32b7c04022b546446189428 Signed-off-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-on: https://review.gerrithub.io/421936 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-08-10 18:08:56 +00:00
# Provide function to ease build of a shared lib
define spdk_build_realname_shared_lib
make: use CXX to build libraries with C++ code If a library contains C++ code, use a C++ compiler when creating a shared object. This ensures that the standard C++ libraries are listed as dependencies. Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com> Change-Id: Icc5321a628682e6dbdab0c053784e0750ebd29c2 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9448 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2021-09-08 14:55:37 +00:00
$(1) -o $@ -shared $(CPPFLAGS) $(LDFLAGS) \
make: add rpath to the shared library build option. Signed-off-by: Seth Howell <seth.howell@intel.com> Change-Id: I9f39ef73dcd9eaed7e5ca9431ab33aa139d9d268 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/3361 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2020-07-15 23:58:48 +00:00
-Wl,-rpath=$(DESTDIR)/$(libdir) \
make: rev SO versions individually for libraries. This will allow us to keep track of compatibility issues on a per-library basis. Change-Id: Ib0c796adb1efe1570212a503ed660bef6f142b6e Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/1067 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2020-02-28 20:47:11 +00:00
-Wl,--soname,$(notdir $@) \
make: use CXX to build libraries with C++ code If a library contains C++ code, use a C++ compiler when creating a shared object. This ensures that the standard C++ libraries are listed as dependencies. Signed-off-by: Konrad Sztyber <konrad.sztyber@intel.com> Change-Id: Icc5321a628682e6dbdab0c053784e0750ebd29c2 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9448 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com>
2021-09-08 14:55:37 +00:00
-Wl,--whole-archive $(2) -Wl,--no-whole-archive \
-Wl,--version-script=$(3) \
$(4) -Wl,--no-as-needed $(5) -Wl,--as-needed
shared_lib: Update shared lib build and install Updates build and install of shared lib to conform with standard naming conventions for shared libraries, including the setting of the lib's soname. Change-Id: Ib46d298ab5f77fd8c32b7c04022b546446189428 Signed-off-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-on: https://review.gerrithub.io/421936 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-08-10 18:08:56 +00:00
endef
BUILD_LINKERNAME_LIB=\
ln -sf $(notdir $<) $@
build: factor out common compile and link commands Add common $(COMPILE_C), $(LINK_C), and $(LIB_C) variables that contain the commands to build a .o from a .c, an app from objects and libraries, and a library from objects, respectively. Change-Id: Ie2eaa13156b8bf3db7a4ffa66161382d829aef07 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-10 22:54:04 +00:00
# Archive $(OBJS) into $@ (.a)
LIB_C=\
build: consolidate library outputs in build/lib Make it easier to use SPDK libraries by putting them all in a single directory that can be added with -L rather than scattered around the source tree. Change-Id: I5c0f5dd6e7058b5f92fa9bc41548190ffc064761 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-11-15 00:45:04 +00:00
$(Q)echo " LIB $(notdir $@)"; \
build: remove static libraries before running ar If a library rule is being built, one of the files it contains was rebuilt, so we need to regenerate the whole library anyway. Remove the previous copy of the library to make sure nothing is left from the previous build. Change-Id: I835f721d5bf7cc908c343f47de78bd1f44be58b8 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-12-01 00:20:35 +00:00
rm -f $@; \
build: remove lib/.gitignore This isn't required - we already have the whole build/ directory in the top level .gitignore. When we remove build/lib/.gitignore, it means build/lib directory must be created somewhere before we try to place a library there. Top-level builds get this directory created automatically, but building directly from a sub-directory's Makefile means we need to explicitly create build/lib. So add a mkdir -p to the LIB_C macro to do exactly that to cover these cases. Also simplify 'make clean' at the top level Makefile. A lot of work went in there to work around this .gitignore file that's not needed now that we've fixed the underlying problem by getting rid of it. Suggested-by: John Levon <john.levon@nutanix.com> Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ibb92ff84d8c2a9bbe3e193c84f15ef3866f07b1f Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/9169 Reviewed-by: Nick Connolly <nick.connolly@mayadata.io> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Community-CI: Broadcom CI <spdk-ci.pdl@broadcom.com> Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2021-08-12 14:35:04 +00:00
mkdir -p $(dir $@); \
build: add CONFIG_LTO to enable link-time optimization Change-Id: I9546d715b8d2ca3ebf46183bdbaa58e8aa921d95 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Signed-off-by: Ben Walker <benjamin.walker@intel.com>
2016-03-24 20:27:53 +00:00
$(CCAR) crDs $@ $(OBJS)
build: factor out common compile and link commands Add common $(COMPILE_C), $(LINK_C), and $(LIB_C) variables that contain the commands to build a .o from a .c, an app from objects and libraries, and a library from objects, respectively. Change-Id: Ie2eaa13156b8bf3db7a4ffa66161382d829aef07 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-10 22:54:04 +00:00
build: define a common Makefile clean command Use $(CLEAN_C) throughout the Makefiles to clean up a consistent set of generated files. This also adds coverage files to the list of cleaned files. Change-Id: Iceb922935a45c9eecbf2f3443bd0ee4f5c966825 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-12-07 22:14:36 +00:00
# Clean up generated files listed as arguments plus a default list
CLEAN_C=\
mk: support file extension for executables Some platforms require that a specific file extension is used for executables. Append $(EXEEXT) to $(APP) definitions to accommodate this. The name EXEEXT has been chosen for consistency with automake which uses the same variable for the same purpose. Add extensions for generated files used by Windows to the 'clean' target (.obj, .lib, .pdb) and add output files to .gitignore. Tested using a cross compiler that forces a .exe suffix and verifying that all LINK messages include the correct suffix and that a second call to make does nothing (showing that the targets match the generated executables). Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> Change-Id: Ief012f6294d2f94b23c8b4f9747e21a0dfb91e96 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6494 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2021-02-23 08:58:06 +00:00
$(Q)rm -f *.a *.lib *.o *.obj *.d *.d.tmp *.pdb *.gcno *.gcda
build: define a common Makefile clean command Use $(CLEAN_C) throughout the Makefiles to clean up a consistent set of generated files. This also adds coverage files to the list of cleaned files. Change-Id: Iceb922935a45c9eecbf2f3443bd0ee4f5c966825 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-12-07 22:14:36 +00:00
build: add 'make install' rule For now, this only installs libraries and headers; we will need to consider which binaries should be installed and what they should be named before we add them to the install rule. Change-Id: I78dc8631f793d0df88cd884b0ac66406df9e4427 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/387637 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-11-15 17:36:36 +00:00
# Install a library
INSTALL_LIB=\
$(Q)echo " INSTALL $(DESTDIR)$(libdir)/$(notdir $(LIB))"; \
install -d -m 755 "$(DESTDIR)$(libdir)"; \
install -m 644 "$(LIB)" "$(DESTDIR)$(libdir)/"
Makefile: Add possibility to uninstall spdk. Add uninstall target to makefiles to be able to perform reverse of install target. Fixes #464 This patch adds 'uninstall' target to makefile. 'make uninstall' will remove spdk_tgt app, headers, libraries and shared libraries from system directories defined by $DESTDIR. Additionaly, if there will be any empty directories left after this operation, they will be removed as well. Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I7b07fb4b81081d3914ff09165991fbe3a26b9067 Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/431471 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-02 09:28:02 +00:00
# Uninstall a library
UNINSTALL_LIB=\
$(Q)echo " UNINSTALL $(DESTDIR)$(libdir)/$(notdir $(LIB))";\
rm -f "$(DESTDIR)$(libdir)/$(notdir $(LIB))"; \
if [ -d "$(DESTDIR)$(libdir)" ] && [ $$(ls -A "$(DESTDIR)$(libdir)" | wc -l) -eq 0 ]; then rm -rf "$(DESTDIR)$(libdir)"; fi
build: install generated pkg-config files Signed-off-by: Jacek Kalwas <jacek.kalwas@intel.com> Change-Id: I191ad5e3b153fb563256eba1aa695716f66db788 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6377 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
2021-02-10 15:28:48 +00:00
define pkgconfig_install
echo " INSTALL $(DESTDIR)$(libdir)/pkgconfig/$(notdir $(1))";
install -d -m 755 "$(DESTDIR)$(libdir)/pkgconfig";
install -m 644 "$(1)" "$(DESTDIR)$(libdir)/pkgconfig";
endef
define pkgconfig_uninstall
echo " UNINSTALL $(DESTDIR)$(libdir)/pkgconfig/$(notdir $(1))";
rm -f "$(DESTDIR)$(libdir)/pkgconfig/$(notdir $(1))";
if [ -d "$(DESTDIR)$(libdir)/pkgconfig" ] && [ $$(ls -A "$(DESTDIR)$(libdir)/pkgconfig" | wc -l) -eq 0 ]; then rm -rf "$(DESTDIR)$(libdir)/pkgconfig"; fi;
endef
shared_lib: Update shared lib build and install Updates build and install of shared lib to conform with standard naming conventions for shared libraries, including the setting of the lib's soname. Change-Id: Ib46d298ab5f77fd8c32b7c04022b546446189428 Signed-off-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-on: https://review.gerrithub.io/421936 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-08-10 18:08:56 +00:00
ifeq ($(OS),FreeBSD)
INSTALL_REL_SYMLINK := install -l rs
else
INSTALL_REL_SYMLINK := ln -sf -r
endif
define spdk_install_lib_symlink
Make: Build shared libs while building static libs This will allow us to specify more granular system dependencies for each .so file. Change-Id: I759876e09ffb36380a503962b4be8fc9d7c71b63 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/426129 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-19 17:11:18 +00:00
$(INSTALL_REL_SYMLINK) $(DESTDIR)$(libdir)/$(1) $(DESTDIR)$(libdir)/$(2)
shared_lib: Update shared lib build and install Updates build and install of shared lib to conform with standard naming conventions for shared libraries, including the setting of the lib's soname. Change-Id: Ib46d298ab5f77fd8c32b7c04022b546446189428 Signed-off-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-on: https://review.gerrithub.io/421936 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-08-10 18:08:56 +00:00
endef
Make: Build shared libs while building static libs This will allow us to specify more granular system dependencies for each .so file. Change-Id: I759876e09ffb36380a503962b4be8fc9d7c71b63 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/426129 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-19 17:11:18 +00:00
INSTALL_SHARED_LIB=\
$(Q)echo " INSTALL $(DESTDIR)$(libdir)/$(notdir $(SHARED_LINKED_LIB))"; \
install -d -m 755 "$(DESTDIR)$(libdir)"; \
mk: Don't use mime-type to determine type of the lib file Some versions of the file (e.g. 5.33) confuse the sharedlib files with pie-executable ones when they already have the executable bit set. Since this particular bit is already set on the .so.* when they are built, file may report the type as "application/x-pie-executable" instead. As a result, lib files won't have proper permissions set when installed. This is a bit problematic for building the RPMs since when find-provides kicks in to determine the dependencies, said files are not picked up at all - package ends up with empty "provides:" data breaking the dependency lookup during installation of other packages which may depend on the broken one. To mitigate, don't use mime-type, simply run file against the lib in default mode and look for "shared object" string - this should work for most of the file versions available on the supported distribution. Spotted on Fedora31. Signed-off-by: Michal Berger <michalx.berger@intel.com> Change-Id: If9974f5acbdad6eb1204b64f0ee1ac9b2e20f85b Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/6703 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Community-CI: Mellanox Build Bot Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Karol Latecki <karol.latecki@intel.com>
2021-03-04 22:20:32 +00:00
if file $(SHARED_REALNAME_LIB) | grep -q 'LSB shared object'; then \
mk: set executable bit only for real libraries Change-Id: I9f68f83472844cabe6a36f70a00f2d2cd319fc62 Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-on: https://review.gerrithub.io/431169 Reviewed-by: Seth Howell <seth.howell5141@gmail.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com>
2018-10-29 15:17:31 +00:00
perm_mode=755; \
else \
perm_mode=644; \
fi; \
install -m $$perm_mode "$(SHARED_REALNAME_LIB)" "$(DESTDIR)$(libdir)/"; \
Make: Build shared libs while building static libs This will allow us to specify more granular system dependencies for each .so file. Change-Id: I759876e09ffb36380a503962b4be8fc9d7c71b63 Signed-off-by: Seth Howell <seth.howell@intel.com> Reviewed-on: https://review.gerrithub.io/426129 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2018-09-19 17:11:18 +00:00
$(call spdk_install_lib_symlink,$(notdir $(SHARED_REALNAME_LIB)),$(notdir $(SHARED_LINKED_LIB)));
build: add combined shared library (libspdk.so) Change-Id: If48df087c145a3fd278c0ae04558d8352b01cc1a Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/414687 Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Tested-by: SPDK Automated Test System <sys_sgsw@intel.com>
2018-06-11 19:40:29 +00:00
Makefile: Add possibility to uninstall spdk. Add uninstall target to makefiles to be able to perform reverse of install target. Fixes #464 This patch adds 'uninstall' target to makefile. 'make uninstall' will remove spdk_tgt app, headers, libraries and shared libraries from system directories defined by $DESTDIR. Additionaly, if there will be any empty directories left after this operation, they will be removed as well. Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I7b07fb4b81081d3914ff09165991fbe3a26b9067 Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/431471 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-02 09:28:02 +00:00
# Uninstall an shared library
UNINSTALL_SHARED_LIB=\
$(Q)echo " UNINSTALL $(DESTDIR)$(libdir)/$(notdir $(SHARED_LINKED_LIB))"; \
rm -f "$(DESTDIR)$(libdir)/$(notdir $(SHARED_LINKED_LIB))"; \
rm -f "$(DESTDIR)$(libdir)/$(notdir $(SHARED_REALNAME_LIB))"; \
if [ -d "$(DESTDIR)$(libdir)" ] && [ $$(ls -A "$(DESTDIR)$(libdir)" | wc -l) -eq 0 ]; then rm -rf "$(DESTDIR)$(libdir)"; fi
app/spdk_tgt: add 'make install' rule Change-Id: Ib76031972824231ed824e53a327c7d648842ad6a Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/403224 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-03-08 22:29:44 +00:00
# Install an app binary
INSTALL_APP=\
build: Output executables from the app directory to build/bin Automatically place binaries produced from the app directory into build/bin. This matches with the output in build/lib that already exists. Change-Id: I13cd2da71d2f88592e22308fe8a907bf458458b5 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2379 Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2020-05-11 21:15:03 +00:00
$(Q)echo " INSTALL $(DESTDIR)$(bindir)/$(notdir $<)"; \
app/spdk_tgt: add 'make install' rule Change-Id: Ib76031972824231ed824e53a327c7d648842ad6a Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/403224 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-03-08 22:29:44 +00:00
install -d -m 755 "$(DESTDIR)$(bindir)"; \
build: Output executables from the app directory to build/bin Automatically place binaries produced from the app directory into build/bin. This matches with the output in build/lib that already exists. Change-Id: I13cd2da71d2f88592e22308fe8a907bf458458b5 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2379 Community-CI: Mellanox Build Bot Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2020-05-11 21:15:03 +00:00
install -m 755 "$<" "$(DESTDIR)$(bindir)/"
app/spdk_tgt: add 'make install' rule Change-Id: Ib76031972824231ed824e53a327c7d648842ad6a Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/403224 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com>
2018-03-08 22:29:44 +00:00
Makefile: Add possibility to uninstall spdk. Add uninstall target to makefiles to be able to perform reverse of install target. Fixes #464 This patch adds 'uninstall' target to makefile. 'make uninstall' will remove spdk_tgt app, headers, libraries and shared libraries from system directories defined by $DESTDIR. Additionaly, if there will be any empty directories left after this operation, they will be removed as well. Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I7b07fb4b81081d3914ff09165991fbe3a26b9067 Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/431471 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-02 09:28:02 +00:00
# Uninstall an app binary
UNINSTALL_APP=\
$(Q)echo " UNINSTALL $(DESTDIR)$(bindir)/$(notdir $(APP))"; \
rm -f "$(DESTDIR)$(bindir)/$(notdir $(APP))"; \
if [ -d "$(DESTDIR)$(bindir)" ] && [ $$(ls -A "$(DESTDIR)$(bindir)" | wc -l) -eq 0 ]; then rm -rf "$(DESTDIR)$(bindir)"; fi
build: Install targets for nvme perf and identify Introduces new macro INSTALL_EXAMPLE and two example apps, examples/nvme/perf and example/nvme/identify that make use of it to install them while at the same time renaming them in the target directory based on the source directory path relative to examples. Change-Id: I2d850458bb2589f80e0af6fb7a9d00aa3bbc6907 Signed-off-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-on: https://review.gerrithub.io/429963 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-10-18 18:48:49 +00:00
INSTALL_EXAMPLE=\
$(Q)echo " INSTALL $(DESTDIR)$(bindir)/spdk_$(strip $(subst /,_,$(subst $(SPDK_ROOT_DIR)/examples/, ,$(CURDIR))))"; \
install -d -m 755 "$(DESTDIR)$(bindir)"; \
build: Example applications build to build/example This mirrors build/bin and build/lib Change-Id: Ide1d17dfc8b425adfbe67f381c93c236653bd301 Signed-off-by: Ben Walker <benjamin.walker@intel.com> Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/2380 Community-CI: Broadcom CI Community-CI: Mellanox Build Bot Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
2020-05-11 22:02:01 +00:00
install -m 755 "$<" "$(DESTDIR)$(bindir)/spdk_$(strip $(subst /,_,$(subst $(SPDK_ROOT_DIR)/examples/, ,$(CURDIR))))"
build: Install targets for nvme perf and identify Introduces new macro INSTALL_EXAMPLE and two example apps, examples/nvme/perf and example/nvme/identify that make use of it to install them while at the same time renaming them in the target directory based on the source directory path relative to examples. Change-Id: I2d850458bb2589f80e0af6fb7a9d00aa3bbc6907 Signed-off-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-on: https://review.gerrithub.io/429963 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Pawel Wodkowski <pawelx.wodkowski@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2018-10-18 18:48:49 +00:00
Makefile: Add possibility to uninstall spdk. Add uninstall target to makefiles to be able to perform reverse of install target. Fixes #464 This patch adds 'uninstall' target to makefile. 'make uninstall' will remove spdk_tgt app, headers, libraries and shared libraries from system directories defined by $DESTDIR. Additionaly, if there will be any empty directories left after this operation, they will be removed as well. Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I7b07fb4b81081d3914ff09165991fbe3a26b9067 Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/431471 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-02 09:28:02 +00:00
# Uninstall an example binary
UNINSTALL_EXAMPLE=\
$(Q)echo " UNINSTALL $(DESTDIR)$(bindir)/spdk_$(strip $(subst /,_,$(subst $(SPDK_ROOT_DIR)/examples/, ,$(CURDIR))))"; \
rm -f "$(DESTDIR)$(bindir)/spdk_$(strip $(subst /,_,$(subst $(SPDK_ROOT_DIR)/examples/, ,$(CURDIR))))"; \
if [ -d "$(DESTDIR)$(bindir)" ] && [ $$(ls -A "$(DESTDIR)$(bindir)" | wc -l) -eq 0 ]; then rm -rf "$(DESTDIR)$(bindir)"; fi
build: add 'make install' rule For now, this only installs libraries and headers; we will need to consider which binaries should be installed and what they should be named before we add them to the install rule. Change-Id: I78dc8631f793d0df88cd884b0ac66406df9e4427 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/387637 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-11-15 17:36:36 +00:00
# Install a header
INSTALL_HEADER=\
$(Q)echo " INSTALL $@"; \
install -d -m 755 "$(DESTDIR)$(includedir)/$(dir $(patsubst $(DESTDIR)$(includedir)/%,%,$@))"; \
Makefile: Add possibility to uninstall spdk. Add uninstall target to makefiles to be able to perform reverse of install target. Fixes #464 This patch adds 'uninstall' target to makefile. 'make uninstall' will remove spdk_tgt app, headers, libraries and shared libraries from system directories defined by $DESTDIR. Additionaly, if there will be any empty directories left after this operation, they will be removed as well. Signed-off-by: Piotr Pelplinski <piotr.pelplinski@intel.com> Change-Id: I7b07fb4b81081d3914ff09165991fbe3a26b9067 Signed-off-by: Pawel Kaminski <pawelx.kaminski@intel.com> Reviewed-on: https://review.gerrithub.io/c/spdk/spdk/+/431471 Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2019-01-02 09:28:02 +00:00
install -m 644 "$(patsubst $(DESTDIR)$(includedir)/%,%,$@)" "$(DESTDIR)$(includedir)/$(dir $(patsubst $(DESTDIR)$(includedir)/%,%,$@))";
# Uninstall a header
UNINSTALL_HEADER=\
$(Q)echo " UNINSTALL $@"; \
rm -rf "$(DESTDIR)$(includedir)/$(dir $(patsubst $(DESTDIR)$(includedir)/%,%,$@))$(notdir $@)"; \
if [ -d "$(DESTDIR)$(includedir)/$(dir $(patsubst $(DESTDIR)$(includedir)/%,%,$@))" ] \
&& [ $$(ls -A "$(DESTDIR)$(includedir)/$(dir $(patsubst $(DESTDIR)$(includedir)/%,%,$@))" | wc -l) -eq 0 ]; \
then rm -rf "$(DESTDIR)$(includedir)/$(dir $(patsubst $(DESTDIR)$(includedir)/%,%,$@))"; fi
build: add 'make install' rule For now, this only installs libraries and headers; we will need to consider which binaries should be installed and what they should be named before we add them to the install rule. Change-Id: I78dc8631f793d0df88cd884b0ac66406df9e4427 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/387637 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com>
2017-11-15 17:36:36 +00:00
build: simplify dependency generation Modern GCC and Clang versions can generate .d files without needing the complex sequence of sed scripts that we currently use. Also adjust the .o rule so the .d file is regenerated if it gets deleted. Also make the .o depend on all of the Makefile fragments in $(MAKEFILE_LIST) so that it is rebuilt if the Makefile is changed. Change-Id: I44e186c0f34dabfa0cf35db1ffa66b84d9dae87d Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-09 23:40:44 +00:00
%.o: %.c %.d $(MAKEFILE_LIST)
build: factor out common compile and link commands Add common $(COMPILE_C), $(LINK_C), and $(LIB_C) variables that contain the commands to build a .o from a .c, an app from objects and libraries, and a library from objects, respectively. Change-Id: Ie2eaa13156b8bf3db7a4ffa66161382d829aef07 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-10 22:54:04 +00:00
$(COMPILE_C)
build: simplify dependency generation Modern GCC and Clang versions can generate .d files without needing the complex sequence of sed scripts that we currently use. Also adjust the .o rule so the .d file is regenerated if it gets deleted. Also make the .o depend on all of the Makefile fragments in $(MAKEFILE_LIST) so that it is rebuilt if the Makefile is changed. Change-Id: I44e186c0f34dabfa0cf35db1ffa66b84d9dae87d Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-09 23:40:44 +00:00
trace: add tracepoint library and app Change-Id: I472fb7e7a82e1337c6c06b1d3bb4e8a2a13d884a Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2016-05-10 23:17:51 +00:00
%.o: %.cpp %.d $(MAKEFILE_LIST)
$(COMPILE_CXX)
build: simplify dependency generation Modern GCC and Clang versions can generate .d files without needing the complex sequence of sed scripts that we currently use. Also adjust the .o rule so the .d file is regenerated if it gets deleted. Also make the .o depend on all of the Makefile fragments in $(MAKEFILE_LIST) so that it is rebuilt if the Makefile is changed. Change-Id: I44e186c0f34dabfa0cf35db1ffa66b84d9dae87d Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com>
2015-11-09 23:40:44 +00:00
%.d: ;
build: define SPDK_LIB_LIST to simplify building dependencies and linker args Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ia969f9e5ed01f4b58cec2559133347d836118131
2016-11-18 16:57:53 +00:00
mk: add spdk_lib_list_to_shared_libs While here, change spdk_lib_list_to_files to spdk_lib_list_to_static_libs to differentiate it from the new spdk_lib_list_to_shared_libs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I6e5913addfbdd556fae2451d4e2b2c43feaf33ab Reviewed-on: https://review.gerrithub.io/429286 Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2018-10-12 21:50:36 +00:00
define spdk_lib_list_to_static_libs
build: remove tab from spdk_lib_list_to_files The tab inside the define ends up in the output when called, which leads to problems if the output is quoted (the tab will be treated as part of the filename). Change-Id: I1038e1650a74861660fa4164dbde065217bc7b99 Signed-off-by: Daniel Verkamp <daniel.verkamp@intel.com> Reviewed-on: https://review.gerrithub.io/387631 Tested-by: SPDK Automated Test System <sys_sgsw@intel.com> Reviewed-by: Jim Harris <james.r.harris@intel.com> Reviewed-by: Ben Walker <benjamin.walker@intel.com>
2017-11-15 16:55:24 +00:00
$(1:%=$(SPDK_ROOT_DIR)/build/lib/libspdk_%.a)
build: define SPDK_LIB_LIST to simplify building dependencies and linker args Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ia969f9e5ed01f4b58cec2559133347d836118131
2016-11-18 16:57:53 +00:00
endef
mk: add spdk_lib_list_to_shared_libs While here, change spdk_lib_list_to_files to spdk_lib_list_to_static_libs to differentiate it from the new spdk_lib_list_to_shared_libs. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I6e5913addfbdd556fae2451d4e2b2c43feaf33ab Reviewed-on: https://review.gerrithub.io/429286 Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Lance Hartmann <lance.hartmann@oracle.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Chandler-Test-Pool: SPDK Automated Test System <sys_sgsw@intel.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2018-10-12 21:50:36 +00:00
define spdk_lib_list_to_shared_libs
$(1:%=$(SPDK_ROOT_DIR)/build/lib/libspdk_%.so)
endef
build: add add_no_as_needed and add_whole_archive macros Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: I56761830e5faac4fe27e93b103004377391721e9 Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4467 Reviewed-by: Mellanox Build Bot Reviewed-by: Ben Walker <benjamin.walker@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com> Reviewed-by: Aleksey Marchuk <alexeymar@mellanox.com> Tested-by: SPDK CI Jenkins <sys_sgci@intel.com>
2020-09-29 18:37:04 +00:00
define add_no_as_needed
-Wl,--no-as-needed $(1) -Wl,-as-needed
endef
define add_whole_archive
-Wl,--whole-archive $(1) -Wl,--no-whole-archive
endef
build: generate pkg-config files for SPDK Users can now generate the necessary linker args for their own applications using something like: PKG_CONFIG_PATH=build/lib/pkgconfig pkg-config --libs spdk_nvme Dependencies between libraries are included in the generated .pc files, so the user only needs to pass the top-level subsystems or individual SPDK libraries they are using in their application. Modules will automatically be added to the output if the associated library is specified. For example, specifying "spdk_bdev" will include the libraries not only for spdk_bdev, but also all of the bdev modules. Users still need to supply the -Wl,--no-as-needed or -Wl,--whole-archive flags. They cannot be added to the .pc files without increasing the length of the argument string by a factor of 15x to 20x. Modify the test/external_code/hello_world Makefile to use pkg-config to ensure this gets tested at some level in our autotest environment. Signed-off-by: Jim Harris <james.r.harris@intel.com> Change-Id: Ie48a75f11969d5d775d514cf10bcb82d197eabfd Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk/+/4371 Community-CI: Broadcom CI Tested-by: SPDK CI Jenkins <sys_sgci@intel.com> Reviewed-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com> Reviewed-by: Shuhei Matsumoto <shuhei.matsumoto.xt@hitachi.com>
2020-09-24 00:06:02 +00:00
define pkgconfig_filename
$(SPDK_ROOT_DIR)/build/lib/pkgconfig/$(1).pc
endef
Reference in New Issue Copy Permalink